Skip to content

Remove outputformat parameter in get_pvgis_hourly and get_pvgis_tmy #2412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AdamRJensen opened this issue Mar 14, 2025 · 2 comments
Closed

Comments

@AdamRJensen
Copy link
Member

AdamRJensen commented Mar 14, 2025

Supporting the four different outputformat options in get_pvgis_hourly and get_pvgis_tmy is proving to be a rather high maintenance burden without much benefit. I therefore suggest that we altogether get rid of the parameter and simply choose the json option as this is the easiest to parse and features more or similar metadata as other options. This issue is already mentioned in #2344 and #2399.

The issue in #2344 demonstrates how the json option is the easiest to maintain.

Here's the metadata available when outputformat='csv'
Header:
Image

Footer:
Image

Here's the metadata available when ``outputformat='json```

Image

Image

@kandersolar
Copy link
Member

I think outputformat='epw' is worth considering. It returns two additional data columns: 'aerosol_optical_depth' and 'temp_dew'. It's also even easier to parse than the JSON, as it needs only a call to the parse_epw function.

Another question: if we get rid of outputformat in get_pvgis_tmy, what will happen with read_pvgis_tmy?

@AdamRJensen
Copy link
Member Author

As long as we get rid of outputformat='basic' in #2416 I'm ok keeping the others for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants