From 30e102349c9dc5542ac231bd73a12349bbc3b2c0 Mon Sep 17 00:00:00 2001 From: Kevin Anderson Date: Tue, 22 Oct 2024 16:21:58 -0400 Subject: [PATCH 1/6] add step to print dist file sizes --- .github/workflows/publish.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index 80d6b61470..da90914f56 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -33,6 +33,9 @@ jobs: - name: Build packages run: python -m build + - name: List distribution file sizes + run: ls -hl dist/* + - name: Check metadata verification run: python -m twine check --strict dist/* From 19f350f99b80a85cb781e9712985225f664d7af8 Mon Sep 17 00:00:00 2001 From: Kevin Anderson Date: Tue, 22 Oct 2024 16:46:49 -0400 Subject: [PATCH 2/6] show installed size as well --- .github/workflows/publish.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index da90914f56..31f906864d 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -39,6 +39,11 @@ jobs: - name: Check metadata verification run: python -m twine check --strict dist/* + - name: Ensure that the wheel installs correctly, and show installed size + run: | + pip install $(find dist -type f -name "*.whl") + du -h $(python -c "import pvlib; print(pvlib.__path__[0])") + # only publish distribution to PyPI for tagged commits - name: Publish distribution to PyPI if: startsWith(github.ref, 'refs/tags/v') From 526ce8412016fd080a365b4826228ecac226e845 Mon Sep 17 00:00:00 2001 From: Kevin Anderson Date: Tue, 22 Oct 2024 16:54:24 -0400 Subject: [PATCH 3/6] tweak how installed file sizes are checked --- .github/workflows/publish.yml | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index 31f906864d..28ae35f6c5 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -39,11 +39,14 @@ jobs: - name: Check metadata verification run: python -m twine check --strict dist/* - - name: Ensure that the wheel installs correctly, and show installed size + - name: Ensure that the wheel installs successfully run: | - pip install $(find dist -type f -name "*.whl") - du -h $(python -c "import pvlib; print(pvlib.__path__[0])") - + mkdir ./tmp + pip install $(find dist -type f -name "*.whl") --target=./tmp + + - name: List installed file sizes + du -h ./tmp + # only publish distribution to PyPI for tagged commits - name: Publish distribution to PyPI if: startsWith(github.ref, 'refs/tags/v') From c7b0c3ae3b75c713c1983a5d6499990e7a2c5f5b Mon Sep 17 00:00:00 2001 From: Kevin Anderson Date: Tue, 22 Oct 2024 16:55:27 -0400 Subject: [PATCH 4/6] fix syntax issue --- .github/workflows/publish.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index 28ae35f6c5..97f08d1a3e 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -45,6 +45,7 @@ jobs: pip install $(find dist -type f -name "*.whl") --target=./tmp - name: List installed file sizes + run: | du -h ./tmp # only publish distribution to PyPI for tagged commits From decf4683566982907d233d2e9a98df8af041c058 Mon Sep 17 00:00:00 2001 From: Kevin Anderson Date: Tue, 22 Oct 2024 16:58:20 -0400 Subject: [PATCH 5/6] one more tweak --- .github/workflows/publish.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index 97f08d1a3e..8a65dc596c 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -46,7 +46,7 @@ jobs: - name: List installed file sizes run: | - du -h ./tmp + cd ./tmp && du -h pvlib # only publish distribution to PyPI for tagged commits - name: Publish distribution to PyPI From 55ede8954a2967a829460e8a8fcc77f44c355515 Mon Sep 17 00:00:00 2001 From: Kevin Anderson Date: Wed, 23 Oct 2024 12:18:53 -0400 Subject: [PATCH 6/6] Apply suggestions from code review Co-authored-by: Echedey Luis <80125792+echedey-ls@users.noreply.github.com> --- .github/workflows/publish.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index 8a65dc596c..b8901ef6c3 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -34,7 +34,7 @@ jobs: run: python -m build - name: List distribution file sizes - run: ls -hl dist/* + run: du -h dist/* - name: Check metadata verification run: python -m twine check --strict dist/* @@ -45,8 +45,8 @@ jobs: pip install $(find dist -type f -name "*.whl") --target=./tmp - name: List installed file sizes - run: | - cd ./tmp && du -h pvlib + run: du -h pvlib + working-directory: ./tmp # only publish distribution to PyPI for tagged commits - name: Publish distribution to PyPI