From 5b5be018be6482739cde25952ca744b01f1f3686 Mon Sep 17 00:00:00 2001 From: RDaxini Date: Tue, 3 Dec 2024 10:14:58 -0700 Subject: [PATCH 1/5] add parameters, capital letters... --- pvlib/ivtools/sdm.py | 31 +++++++++++++++++++++---------- 1 file changed, 21 insertions(+), 10 deletions(-) diff --git a/pvlib/ivtools/sdm.py b/pvlib/ivtools/sdm.py index ebc63898bc..e3ef7ba925 100644 --- a/pvlib/ivtools/sdm.py +++ b/pvlib/ivtools/sdm.py @@ -564,25 +564,36 @@ def fit_desoto_sandia(ivcurves, specs, const=None, maxiter=5, eps1=1.e-3): I_L_ref : float light current at STC [A] I_o_ref : float - dark current at STC [A] + Dark current at STC [A] EgRef : float - effective band gap at STC [eV] + Effective band gap at STC [eV] R_s : float - series resistance at STC [ohm] + Series resistance at STC [ohm] R_sh_ref : float - shunt resistance at STC [ohm] + Shunt resistance at STC [ohm] cells_in_series : int - number of cells in series + Number of cells in series iph : array - light current for each IV curve [A] + Light current for each IV curve [A] io : array - dark current for each IV curve [A] + Dark current for each IV curve [A] rs : array - series resistance for each IV curve [ohm] + Series resistance for each IV curve [ohm] rsh : array - shunt resistance for each IV curve [ohm] + Shunt resistance for each IV curve [ohm] + a_ref : float + The product of the usual diode ideality factor (n, unitless), + number of cells in series (Ns), and cell thermal voltage at + reference conditions, in units of V. + dEgdT : float + The temperature dependence of the energy bandgap (Eg) at reference + conditions in units of 1/K. May be either a scalar value + (e.g. -0.0002677 as in _[1]) or a DataFrame (this may be useful if + dEgdT is a modeled as a function of temperature). For parameters + from the SAM CEC module database, dEgdT=-0.0002677 is implicit for + all cell types in the parameter estimation algorithm used by NREL. u : array - boolean for each IV curve indicating that the parameter values + Boolean for each IV curve indicating that the parameter values are deemed reasonable by the private function ``_filter_params`` Notes From 9b3b2b739d3ca4c712fddeb2b66835bc357bc966 Mon Sep 17 00:00:00 2001 From: RDaxini Date: Tue, 3 Dec 2024 10:25:41 -0700 Subject: [PATCH 2/5] correct units and reference --- pvlib/ivtools/sdm.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pvlib/ivtools/sdm.py b/pvlib/ivtools/sdm.py index e3ef7ba925..f70cde50dc 100644 --- a/pvlib/ivtools/sdm.py +++ b/pvlib/ivtools/sdm.py @@ -587,8 +587,8 @@ def fit_desoto_sandia(ivcurves, specs, const=None, maxiter=5, eps1=1.e-3): reference conditions, in units of V. dEgdT : float The temperature dependence of the energy bandgap (Eg) at reference - conditions in units of 1/K. May be either a scalar value - (e.g. -0.0002677 as in _[1]) or a DataFrame (this may be useful if + conditions [eV/K]. May be either a scalar value + (e.g. -0.0002677 as in [1]_) or a DataFrame (this may be useful if dEgdT is a modeled as a function of temperature). For parameters from the SAM CEC module database, dEgdT=-0.0002677 is implicit for all cell types in the parameter estimation algorithm used by NREL. From 2c6921879245fad8183a9bac3890a8052f9dc0c2 Mon Sep 17 00:00:00 2001 From: RDaxini Date: Tue, 3 Dec 2024 10:31:56 -0700 Subject: [PATCH 3/5] units --- pvlib/ivtools/sdm.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pvlib/ivtools/sdm.py b/pvlib/ivtools/sdm.py index f70cde50dc..8e4fb25f15 100644 --- a/pvlib/ivtools/sdm.py +++ b/pvlib/ivtools/sdm.py @@ -587,7 +587,7 @@ def fit_desoto_sandia(ivcurves, specs, const=None, maxiter=5, eps1=1.e-3): reference conditions, in units of V. dEgdT : float The temperature dependence of the energy bandgap (Eg) at reference - conditions [eV/K]. May be either a scalar value + conditions [1/K]. May be either a scalar value (e.g. -0.0002677 as in [1]_) or a DataFrame (this may be useful if dEgdT is a modeled as a function of temperature). For parameters from the SAM CEC module database, dEgdT=-0.0002677 is implicit for From a5fdc1c93dfdfcf74d7b0b5538bf74b14a25cd64 Mon Sep 17 00:00:00 2001 From: RDaxini <143435106+RDaxini@users.noreply.github.com> Date: Tue, 3 Dec 2024 11:45:01 -0700 Subject: [PATCH 4/5] Update pvlib/ivtools/sdm.py Co-authored-by: Kevin Anderson --- pvlib/ivtools/sdm.py | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/pvlib/ivtools/sdm.py b/pvlib/ivtools/sdm.py index 8e4fb25f15..7d950e0107 100644 --- a/pvlib/ivtools/sdm.py +++ b/pvlib/ivtools/sdm.py @@ -587,11 +587,7 @@ def fit_desoto_sandia(ivcurves, specs, const=None, maxiter=5, eps1=1.e-3): reference conditions, in units of V. dEgdT : float The temperature dependence of the energy bandgap (Eg) at reference - conditions [1/K]. May be either a scalar value - (e.g. -0.0002677 as in [1]_) or a DataFrame (this may be useful if - dEgdT is a modeled as a function of temperature). For parameters - from the SAM CEC module database, dEgdT=-0.0002677 is implicit for - all cell types in the parameter estimation algorithm used by NREL. + conditions [1/K]. u : array Boolean for each IV curve indicating that the parameter values are deemed reasonable by the private function ``_filter_params`` From 690d5653b6cfcc8ceaf8a6c1e25b5e9c60e21e4c Mon Sep 17 00:00:00 2001 From: RDaxini <143435106+RDaxini@users.noreply.github.com> Date: Tue, 3 Dec 2024 11:59:39 -0700 Subject: [PATCH 5/5] Update pvlib/ivtools/sdm.py Co-authored-by: Cliff Hansen --- pvlib/ivtools/sdm.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pvlib/ivtools/sdm.py b/pvlib/ivtools/sdm.py index 7d950e0107..c0342f8ea9 100644 --- a/pvlib/ivtools/sdm.py +++ b/pvlib/ivtools/sdm.py @@ -562,7 +562,7 @@ def fit_desoto_sandia(ivcurves, specs, const=None, maxiter=5, eps1=1.e-3): ------- dict I_L_ref : float - light current at STC [A] + Light current at STC [A] I_o_ref : float Dark current at STC [A] EgRef : float