Skip to content

Commit 68c676f

Browse files
committed
Add PR checklist and a 5th module
1 parent a6dca60 commit 68c676f

File tree

3 files changed

+31
-4
lines changed

3 files changed

+31
-4
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ jobs:
1111
matrix:
1212
# The MODULE environment variable is evaluated in build-all.sh to run a subset
1313
# of the builds. This way, multiple modules can be built in parallel.
14-
module: [ "module1", "module2", "module3", "module4" ]
14+
module: [ "module1", "module2", "module3", "module4", "module5" ]
1515

1616
steps:
1717

build-all.sh

Lines changed: 16 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,22 @@ build_maven_module() {
8282
}
8383
}
8484

85+
if [[ "$MODULE" == "module5" ]]
86+
then
87+
# ADD NEW MODULES HERE
88+
# (add new modules above the rest so you get quicker feedback if it fails)
89+
90+
build_gradle_module "spring-boot/hazelcast/hazelcast-embedded-cache"
91+
build_gradle_module "spring-boot/hazelcast/hazelcast-client-server"
92+
build_gradle_module "spring-boot/cache"
93+
94+
echo ""
95+
echo "+++"
96+
echo "+++ MODULE 5 SUCCESSFUL"
97+
echo "+++"
98+
fi
99+
100+
85101
if [[ "$MODULE" == "module1" ]]
86102
then
87103
build_maven_module "spring-boot/spring-boot-kafka"
@@ -154,9 +170,6 @@ then
154170
build_gradle_module "spring-boot/profiles"
155171
build_gradle_module "spring-boot/password-encoding"
156172
build_gradle_module "spring-boot/testcontainers"
157-
build_gradle_module "spring-boot/hazelcast/hazelcast-embedded-cache"
158-
build_gradle_module "spring-boot/hazelcast/hazelcast-client-server"
159-
build_gradle_module "spring-boot/cache"
160173

161174
echo ""
162175
echo "+++"

pull_request_template.md

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
Please review the changes you did in this PR and check these points to make sure that the code examples are of high quality:
2+
3+
- [ ] the source branch for this PR is NOT the master branch of your fork (please create a dedicated branch for the PR)
4+
- [ ] the PR doesn't contain code that is irrelevant to the topic of the article
5+
- [ ] the PR doesn't contain any other files that are irrelevant to the topic of the article
6+
- [ ] the PR contains a README.md file that explains in a sentence or two what the code example is about and links to the article on reflectoring.io (if you added to an existing module, please add the link to the existing README.md file)
7+
- [ ] the code is covered with tests where it makes sense
8+
- [ ] if you have created a new Maven or Gradle module, please add it to the CI build (search for "# ADD NEW MODULES HERE" in `build-all.sh`)
9+
- [ ] the [GitHub Actions build](https://github.com/thombergs/code-examples/actions?query=workflow%3ACI) is successful for your PR branch
10+
11+
**Feel free to raise the PR even if the checklist hasn't been worked through, yet**. But please only flag it to be reviewed after going through the checklist above.
12+
13+
Also feel free to reach out if you have any trouble with any of the steps.
14+

0 commit comments

Comments
 (0)