Skip to content

Bug: peer review project board automation has a bug with the pending maintainers response label (because of emoji + missing from json schema #389

Description

@lwasser

What's happening

We have a GitHub action in the software submission repo that is triggered when an editor labels an issue to keep track of hte state of peer review.
When an software submission issue issue is labeled ⌛ pending-maintainer-response, the workflow fails with a jq syntax error because there is an emoji there:

  1. The emoji in the label name breaks shell quoting in the jq query: i've in the past just removed emoji's we can just do that with this specific label
  2. The label itself however is also is missing from update-project.jsonwhich maps label to "status"

To fix

  1. Rename the GitHub label to remove the emoji: pending-maintainer-response that's simplest.

  2. Find the correct column ID for this status in project Added good/better/best recommendations to packaging guide #7 (query via GraphQL API or check existing IDs in update-project.json)

  3. Add the label + ID to update-project.json

Image

i can map to onhold - pending response here in the project
5. Update the workflow jq query to use the safer --arg syntax (fixes emoji/quoting issues for all labels):

   value=$(jq -r --arg key "${{ github.event.label.name }}" '.labelToColumnId[$key]' update-project.json)

The above is a simple fix but it's one that claude gave me so that fix should be checked to ensure we want to do that. alterantively we could skip this because we will just remove the emoji in step 1 (let's do that)

Metadata

Metadata

Assignees

No one assigned

    Labels

    help wantedWe'd love help fixing this issue!! Can you help us?

    Type

    Projects

    Status
    Dev Ops / GitHub actions or GitHub related

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions