You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Changed duck typing exception to: (ImportError, AttributeError) (#7874)
* Changed duck typing exception to (ImportError, AttributeError) to allow checking for missing attributes in imported packages
* Updated whats-new.rst with the duck typing exception catch update of PR 7874.
* Remove accidental url in whats-new
* Issue number in whats-new.rst
---------
Co-authored-by: Tom Nicholas <[email protected]>
Copy file name to clipboardExpand all lines: doc/whats-new.rst
+1Lines changed: 1 addition & 0 deletions
Original file line number
Diff line number
Diff line change
@@ -51,6 +51,7 @@ Internal Changes
51
51
(:pull:`7847`) By `Tom Nicholas <https://github.com/TomNicholas>`_.
52
52
- Xarray now uploads nightly wheels to https://pypi.anaconda.org/scientific-python-nightly-wheels/simple/.
53
53
By `Martin Fleischmann <https://github.com/martinfleis>`_.
54
+
- Added an exception catch for ``AttributeError`` along with ``ImportError`` when duck typing the dynamic imports in pycompat.py. This catches some name collisions between packages. (:issue:`7870`, :pull:`7874`)
0 commit comments