Skip to content

Commit 88c861b

Browse files
authored
Merge branch 'master' into emaclean-patch-1
2 parents 61b1839 + 9da9c3d commit 88c861b

34 files changed

+193
-149
lines changed

docs/guis/about.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ If you encounter a complaint about `Java` being too old, try using `/mcr/bin/jws
101101
```bash
102102
javaws https://bewww.cern.ch/ap/deployments/applications/cern/lhc/lhc-app-beta-beating-omc3/PRO/BetaBeatingOMC3-Control-3t.jnlp
103103
```
104-
:material-arrow-right-bold: Disabling Java as it is too old and likely to be insecure. To reenable use jcontrol utility
104+
:material-arrow-right-bold: Disabling Java as it is too old and likely to be insecure. To re-enable use jcontrol utility
105105

106106
!!! success
107107
```bash

docs/guis/betabeat/analysis_panel.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ These include phase (`PHASE`), frequency (`FREQ`) and amplitude (`AMP`) of the l
5050
The lines are multiples of the found tunes (`TUNE`) and can be identified by the two numbers in their name,
5151
which correspond to the multiples of the horizontal and vertical tune, respectively, using underscores to represent a minus sign;
5252
e.g. `PHASE1_2`, as seen in the screenshot above, corresponds to the phase of the line at frequency `Qx - 2Qy`.
53-
In addtion, further data from the harmonic analysis is available, such as:
53+
In addition, further data from the harmonic analysis is available, such as:
5454

5555
- `TUNE`: (driven) tune
5656
- `NATTUNE`: natural tune (if available)
@@ -63,7 +63,7 @@ In addtion, further data from the harmonic analysis is available, such as:
6363
It is possible to select multiple files (++ctrl++ / ++shift++) at once, to compare the same quantities between measurements, and also multiple entries, e.g. to compare the amplitudes of different lines.
6464

6565
!!! tip "Deselection"
66-
To see the data of one plane only, one can deselect the other plane by either chosing `None` at the bottom of the list
66+
To see the data of one plane only, one can deselect the other plane by either choosing `None` at the bottom of the list
6767
or by right-clicking into the respective list.
6868

6969
### Cleaning
@@ -164,7 +164,7 @@ It is possible to select multiple files (++ctrl++ / ++shift++) as well as multip
164164
Depending on the number of selected files and BPMs as well as the frequency resolution of the spectra, the GUI may take a few seconds to display all data.
165165

166166
!!! tip "Deselection"
167-
To see the frequency data of one plane only, one can deselect the other plane by either chosing `None` at the bottom of the list of BPMs
167+
To see the frequency data of one plane only, one can deselect the other plane by either choosing `None` at the bottom of the list of BPMs
168168
or by right-clicking into the respective list.
169169

170170
!!! tip "Find BPMs"
@@ -267,7 +267,7 @@ To update the natural tune in the lin-file, first activate the vertical cursors
267267
they will appear at their last set position or at 0 if they have not been set yet.
268268

269269
!!! tip "Cursors for each plane"
270-
If BPMs from both planes are selected, two sets of cursors will appear: blue for the horizonal spectrum and red for the vertical spectrum.
270+
If BPMs from both planes are selected, two sets of cursors will appear: blue for the horizontal spectrum and red for the vertical spectrum.
271271
In case only one plane is selected, only one set of cursors will appear.
272272
To update the amount of cursors shown, select BPMs in the desired planes, then untick and re-activate the **Show** checkbox.
273273

docs/guis/betabeat/beam_selection.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ Depending on your choice of `Beam` a default is already preselected for you.
4242
#### Folder Structure
4343

4444
Within your selected output folder, a new folder for the current date will be created.
45-
Withing that folder, a folder for the selected beam/accelerator will be created.
45+
Within that folder, a folder for the selected beam/accelerator will be created.
4646
Within that folder in turn, folders for `Measurements`, `Results` and `Models` will be created.
4747
If any of these folders already exist, they will be used, e.g.:
4848

docs/guis/betabeat/betabeatsource.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ One can compensate for this deviation in different ways, which is why there are
2121
| :---------------- | :------------------------------------------------------------------------------------------------------------- |
2222
| `get_*.out` | The optics functions **without** compensation, from the driven excitation data. |
2323
| `get_*_free.out` | The optics functions compensated **analytically** using an equation[^MiyamotoMeasurementCouplingRDTsACDipole]. |
24-
| `get_*_free2.out` | The optics functions compensated **the other way**, see bellow. |
24+
| `get_*_free2.out` | The optics functions compensated **the other way**, see below. |
2525

2626
In the case of the `get_*_free2.out` files, the compensation is done differently depending on the computed quantity.
2727
For some quantities (for instance for $\beta$ from phase) this uses the model values, for others (for instance the coupling RDTs $f_{1001}$ and $f_{1010}$) it is a rescaling in which the model values are used *indirectly*.

docs/guis/betabeat/common_components.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ If you are using an older version than recommended, a lot of the functionality m
5353
features might be missing or not work with the arguments the GUI provides.
5454

5555
The colored button and dropdown menu that follows is the **RBAC** (Role Based Access Control) menu,
56-
which shows you the current status of, and allows you to aquire, an access token,
56+
which shows you the current status of, and allows you to acquire, an access token,
5757
e.g. for the [creation of knobs](correction_panel.md#knob-creation).
5858

5959
Next, in the middle of the screen, the **currently selected model** is shown.
@@ -114,7 +114,7 @@ additional logging information will be printed to the terminal.
114114
</figure>
115115

116116
A "task" in the context of this GUI means the running of an external program in a separate process.
117-
Sometimes even multiple processes might be started consecutively in the same taks, if they are dependent on each other.
117+
Sometimes even multiple processes might be started consecutively in the same tasks, if they are dependent on each other.
118118
As the GUI is a front-end for our `python` library, the external processes are usually calls to `python` modules,
119119
constructed from the currently selected files and [settings](settings.md).
120120
The exact call can often be found in the [terminal](#terminal) or in the `command.run` files often created by th GUI in the selected output folder,
@@ -152,12 +152,12 @@ Go to the path set as [_Input Path_ in the beam selection window](beam_selection
152152
Go to the path set as [_Output Path_ in the beam selection window](beam_selection.md#output).
153153
- **Root Path** (**<>**)
154154
Go to the root-path for the current GUI instance, i.e. the path in which the accelerator-folder (e.g. `LHCB1`) is located.
155-
This is usually the date-directory within the output folder, unless you have choosen that folder as the _Output Path_,
155+
This is usually the date-directory within the output folder, unless you have chosen that folder as the _Output Path_,
156156
in which case it will be the same as the _Output Path_ (see the [Continue Analysis Admonition in the Beam Selection Window](beam_selection.md#folder-structure)).
157157
- **Fill Dir** (:fontawesome-solid-arrow-right:) _(Only available for the LHC and only if the folder is mounted)_:
158-
Go to the fill-directory of [the choosen accelerator](beam_selection.md#beam).
158+
Go to the fill-directory of [the chosen accelerator](beam_selection.md#beam).
159159
- **Accelerator Dir** (:fontawesome-solid-star:) _(Only available for LHC, SPS, PS and PSB, and only if the folder is mounted)_:
160-
Go to the default OMC analyis directory of [the choosen accelerator](beam_selection.md#beam),
160+
Go to the default OMC analysis directory of [the chosen accelerator](beam_selection.md#beam),
161161
which is usually the same as [the _Output Dir_, if the default is used in the beam selection window](beam_selection.md#output).
162162

163163
[omc3]: https://github.com/omc3

docs/guis/betabeat/defaults.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ clean.bounds=0.7 # this ratio of points needs to remain otherwise cleaning a
4949
ampdet.tunecut=0.05 # limit around the given tune to exclude from the BBQ tune
5050
ampdet.window=100 # length of the moving average window for the BBQ tune
5151
ampdet.outlierLimit=0.0002 # Cut on outliers around the mean
52-
ampdet.usePreviousBBQ=False # Use previously extraced BBQ data if present
52+
ampdet.usePreviousBBQ=False # Use previously extracted BBQ data if present
5353
```
5454

5555
For more details about these functions see the [BPM-Panel](bpm_panel.md), [Analysis-Panel](analysis_panel.md) and [Amplitude-Detuning](ampdet.md) pages.

docs/guis/betabeat/model_creation.md

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,8 @@ A window will open to select a time to extract the MQTs from, which default to t
5858
It checks in the model folder if the `extracted_mqts.str` file is present, which it updates,
5959
and if `job.create_model_best_knowledge.madx` exists, which is then reused to re-run.
6060

61-
!!! warning "Updating MQTs to re-use model"
62-
It is **heavily discouraged** to update the MQTs to re-use a model later during a shift,
61+
!!! warning "Updating MQTs to reuse model"
62+
It is **heavily discouraged** to update the MQTs to reuse a model later during a shift,
6363
as it will lead to confusion if optics have already been analyzed with this model and someone tries to reproduce the results later.
6464
It is therefore usually better to create a new model from scratch and **only use this functionality before doing any analysis**,
6565
e.g. if you extracted the MQTs too early, or if you created a copy of an older model.
@@ -131,7 +131,7 @@ The value by which each variable will be changed to check the response.
131131
!!! note "FullResponse Task"
132132
The full-response creation will only start after the model is fully created and you have closed the popup-window
133133
asking you to load the model or not (see below).
134-
By that time you can **already use the model** as if it was fully created and you **do not need to wait for this taks to finish** for the _standard_ analysis, until you want to calculate [global corrections](correction_panel.md).<br>
134+
By that time you can **already use the model** as if it was fully created and you **do not need to wait for this tasks to finish** for the _standard_ analysis, until you want to calculate [global corrections](correction_panel.md).<br>
135135
The full-response creation is also heavily parallelized where possible, so expect a few processes to run at the same time.
136136

137137
#### User
@@ -180,14 +180,14 @@ which are our default tunes for LHC measurements.
180180
#### Accelerator (LHC)
181181

182182
- **Beam**:
183-
The beam is pre-defined by the accelerator choosen in the [beam selection window](beam_selection.md).
183+
The beam is pre-defined by the accelerator chosen in the [beam selection window](beam_selection.md).
184184
- **Year/Tag**:
185185
This field is automatically filled by the fetcher with the first layer of subfolders in the `acc-models/lhc` repository by the fetcher.
186186
- **Energy**:
187187
The energy at which the accelerator is running in GeV.
188188
- **Optics File**:
189189
The optics used for the model, which has the same name as the one used in the machine.
190-
The **File** dropdown is automatically filled by the fetcher with the files in the `operation/optics` folder within the choosen _year/tag_
190+
The **File** dropdown is automatically filled by the fetcher with the files in the `operation/optics` folder within the chosen _year/tag_
191191
of the `acc-models/lhc` repository.
192192
You can search through the list via regular expression in the **Filter** field.
193193
- **dpp**: The momentum deviation for the model.
@@ -217,7 +217,7 @@ In addition, this model contains also the $b_2$ errors of the main dipoles from
217217
This will result in additional `*_best_knowledge.dat` twiss-output files, which are used in the N-BPM method of the beta-from-phase analysis
218218
(see _[Langner et al. - Utilizing the N beam position monitor method for turn-by-turn optics measurements][langner2016]{target=_blank}_).
219219
- **$b_2$ error table**:
220-
As these errors are dependend on the powering of the dipoles, you need to choose the table with the closest energy to the one you are creating the model for.
220+
As these errors are dependent on the powering of the dipoles, you need to choose the table with the closest energy to the one you are creating the model for.
221221
- **:fontawesome-solid-triangle-exclamation:{.warning-colored} Extract MQTs**:
222222
As the $b_2$ errors change the tunes, you should **always also extract the MQTs** when creating the best knowledge model.
223223

@@ -249,7 +249,7 @@ The **fractional tunes** are set by default to some values, that have suited us
249249
but as the settings of the SPS can differ quite drastically, you need to check the currently used values in the SPS multiturn application.
250250

251251
!!! warning "Integer Tunes"
252-
The **integer part of the tunes** is set from the filename of the choosen _Strength File_ (below).
252+
The **integer part of the tunes** is set from the filename of the chosen _Strength File_ (below).
253253
To set them manually, make sure to **first select a strength file and then change the integer tunes**.
254254

255255
#### Accelerator (SPS)
@@ -259,7 +259,7 @@ Which year to create the model for.
259259
This field is automatically filled by the fetcher with the first layer of subfolders in the `acc-models/sps` repository.
260260
- **Strength File**:
261261
Strength file to use.
262-
This field is automatically filled by fetcher with the files in the `strengths` folder within the choosen _year_ of the `acc-models/sps` repository.
262+
This field is automatically filled by fetcher with the files in the `strengths` folder within the chosen _year_ of the `acc-models/sps` repository.
263263
- **Kinetic Energy**: Activate and set the energy at which the accelerator is running in GeV, if needed for your model.
264264

265265
### PS Model Creation
@@ -284,7 +284,7 @@ Which year to create the model for.
284284
This field is automatically filled by the fetcher with the first layer of subfolders in the `acc-models/ps` repository.
285285
- **Scenario**:
286286
Operational scenario of the PS accelerator.
287-
This field is automatically filled by the fetcher with the content of the `scenarios` folder within the choosen _year_ of the `acc-models/ps` repository.
287+
This field is automatically filled by the fetcher with the content of the `scenarios` folder within the chosen _year_ of the `acc-models/ps` repository.
288288
- **Cycle Point**:
289289
Desired point in the cycle.
290290
This field is automatically filled by the fetcher with the content of the chosen _scenario_ folder above.
@@ -325,7 +325,7 @@ Which year to create the model for.
325325
This field is automatically filled by the fetcher with the first layer of subfolders in the `acc-models/psb` repository.
326326
- **Scenario**:
327327
Operational scenario of the PSBooster.
328-
This field is automatically filled by the fetcher with the content of the `scenarios` folder within the choosen _year_ of the `acc-models/psb` repository.
328+
This field is automatically filled by the fetcher with the content of the `scenarios` folder within the chosen _year_ of the `acc-models/psb` repository.
329329
- **Cycle Point**:
330330
Desired point in the cycle.
331331
This field is automatically filled by the fetcher with the content of the chosen _scenario_ folder above.

docs/guis/betabeat/settings.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ There is some general behaviour, that is true for all settings-tabs:
3333
Entries in the file, that are not recognized as settings will be ignored.
3434

3535
!!! info "Some Background on the Internals"
36-
To "apply" settings simply means that the current values in the UI are assinged to the corresponding settings class,
36+
To "apply" settings simply means that the current values in the UI are assigned to the corresponding settings class,
3737
each an internal representation of a settings tab,
3838
which is used to persistently store the settings in memory and pass them between different parts of the application.
3939
To "reset" the settings, the stored values are reloaded from this internal representation to the UI.
@@ -80,7 +80,7 @@ This is in contrast to the other settings tabs, which control the settings passe
8080
If active, the GUI will run the `python` script with the `-d` flag, which initializes the logging level in our scripts automatically to `DEBUG`.
8181

8282
- **Use Server for Analysis**:
83-
When set, all `python` tasks requireing lots of memory and processing power (e.g. `hole-in-one` for `harpy` and `optics`) will be run on that server.
83+
When set, all `python` tasks requiring lots of memory and processing power (e.g. `hole-in-one` for `harpy` and `optics`) will be run on that server.
8484
If you click the ++"Test"++ button, file creation and reading of the created files from the local machine will be tested and you will be prompted with the results after a few seconds.
8585

8686
- **Always use Server**:
@@ -91,7 +91,7 @@ This is in contrast to the other settings tabs, which control the settings passe
9191
e.g. the `harpy` analysis will be run in parallel for each turn-by-turn file, even if started with multiple files selected at once.
9292
When running `optics analysis` with _"combine analysis"_ **deactivated** the analysis will be run in parallel for each file.
9393
Conversely, if opting to run the `optics analysis` directly from the BPM-Panel with _"combine analysis"_ **activated**,
94-
the `harpy` analysis of the selected files will be run sequentially per file, as it is not explicitely parallelized on the python side.
94+
the `harpy` analysis of the selected files will be run sequentially per file, as it is not explicitly parallelized on the python side.
9595

9696
## Tunes Tab
9797

@@ -140,7 +140,7 @@ The fields are non-editable when it does not make sense in the current settings
140140
Otherwise the main tune is defined as the highest peak in the spectrum around the tunes given in the first row &plusmn; the tolerance.
141141

142142
- **Clean Limit**:
143-
When cleaning is active, BPM outliers are detemined as those that are further away than others from the average.
143+
When cleaning is active, BPM outliers are determined as those that are further away than others from the average.
144144
This limit sets a hard border to the cleaning, where **outliers closer than the given limit to the average tune will not be removed**.
145145

146146
- **Tolerance**:
@@ -375,7 +375,7 @@ introduced by the AC-Dipole and if they are not found in the data, the optics an
375375
Default: `False`.
376376

377377
- **Calculate only coupling**:
378-
When active, skips most of the optics calcualtions and calculates only phases and coupling RDTs.
378+
When active, skips most of the optics calculations and calculates only phases and coupling RDTs.
379379
Useful for quick analysis or machines that do not support (e.g. not enough BPMs) some of the other analysis methods.
380380
Default: `False`.
381381

@@ -471,7 +471,7 @@ which is the `python`-internal representation of the accelerator and its setting
471471
In `model/settings`:
472472

473473
- add a **descriptive attritbute** to the respective settings class.
474-
- add your vlaue to the **constructor** of the class, with default values.
474+
- add your value to the **constructor** of the class, with default values.
475475
- add your value to the **copy-constructor** of the class.
476476
- add a nice **tooltip** to the label (e.g. the help text from the corresponding `python` argument).
477477
- use `getProperty()` to automatically **extract** the value from the property file in a unified way and set the attribute on the class.

0 commit comments

Comments
 (0)