fix: warn on deprecated images being set (#2312)

* fix: warn on deprecated images being set

Signed-off-by: Henry Schreiner <[email protected]>

* fix: handle repeated warning messages

Signed-off-by: Henry Schreiner <[email protected]>

* Apply suggestions from code review

Co-authored-by: Joe Rickerby <[email protected]>

* fix: try making the warnings once per Options

Signed-off-by: Henry Schreiner <[email protected]>

---------

Signed-off-by: Henry Schreiner <[email protected]>
Co-authored-by: Joe Rickerby <[email protected]>

Author: henryiii

cibuildwheel/options.py

@@ -576,6 +576,7 @@ def __init__(
         self.command_line_arguments = command_line_arguments
         self.env = env
         self._defaults = defaults
+        self._image_warnings = set[str]()
 
         self.reader = OptionsReader(
             None if defaults else self.config_file_path,
@@ -777,6 +778,24 @@ def _compute_build_options(self, identifier: str | None) -> BuildOptions:
                         # default to manylinux2014
                         image = pinned_images["manylinux2014"]
                     elif config_value in pinned_images:
+                        if (
+                            config_value
+                            in {
+                                "manylinux1",
+                                "manylinux2010",
+                                "manylinux_2_24",
+                                "musllinux_1_1",
+                            }
+                            and config_value not in self._image_warnings
+                        ):
+                            self._image_warnings.add(config_value)
+                            msg = (
+                                f"Deprecated image {config_value!r}. This value will not work"
+                                " in a future version of cibuildwheel. Either upgrade to a supported"
+                                " image or continue using the deprecated image by pinning directly"
+                                f" to {pinned_images[config_value]!r}."
+                            )
+                            log.warning(msg)
                         image = pinned_images[config_value]
                     else:
                         image = config_value