From 64077edf2d06ae8058abbf3bae5e90edcb45a22f Mon Sep 17 00:00:00 2001 From: Damian Shaw Date: Thu, 9 Jan 2025 20:30:09 -0500 Subject: [PATCH 1/3] Fix mypy 1.14.1 error --- .pre-commit-config.yaml | 2 +- src/pip/_internal/utils/unpacking.py | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 3353bf682fc..c1153ef3bcc 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -28,7 +28,7 @@ repos: args: [--fix, --exit-non-zero-on-fix] - repo: https://github.com/pre-commit/mirrors-mypy - rev: v1.13.0 + rev: v1.14.1 hooks: - id: mypy exclude: tests/data diff --git a/src/pip/_internal/utils/unpacking.py b/src/pip/_internal/utils/unpacking.py index 875e30e13ab..e7fcb8daa69 100644 --- a/src/pip/_internal/utils/unpacking.py +++ b/src/pip/_internal/utils/unpacking.py @@ -22,7 +22,6 @@ logger = logging.getLogger(__name__) - SUPPORTED_EXTENSIONS = ZIP_EXTENSIONS + TAR_EXTENSIONS try: @@ -176,7 +175,7 @@ def untar_file(filename: str, location: str) -> None: ) mode = "r:*" - tar = tarfile.open(filename, mode, encoding="utf-8") + tar = tarfile.open(filename, mode, encoding="utf-8") # type: ignore try: leading = has_leading_dir([member.name for member in tar.getmembers()]) From 7760b94ac47103913fee54990076210f3351e224 Mon Sep 17 00:00:00 2001 From: Damian Shaw Date: Thu, 9 Jan 2025 20:30:17 -0500 Subject: [PATCH 2/3] NEWS ENTRY --- news/13148.trivial.rst | 1 + 1 file changed, 1 insertion(+) create mode 100644 news/13148.trivial.rst diff --git a/news/13148.trivial.rst b/news/13148.trivial.rst new file mode 100644 index 00000000000..dcdd0bf5e8d --- /dev/null +++ b/news/13148.trivial.rst @@ -0,0 +1 @@ +Fix mypy 1.14.1 error From 6c2850eceff96e27ae0c92b00cf4d89ac36265e2 Mon Sep 17 00:00:00 2001 From: Damian Shaw Date: Sat, 11 Jan 2025 17:36:04 -0500 Subject: [PATCH 3/3] Add empty line back --- src/pip/_internal/utils/unpacking.py | 1 + 1 file changed, 1 insertion(+) diff --git a/src/pip/_internal/utils/unpacking.py b/src/pip/_internal/utils/unpacking.py index e7fcb8daa69..87a6d19ab5a 100644 --- a/src/pip/_internal/utils/unpacking.py +++ b/src/pip/_internal/utils/unpacking.py @@ -22,6 +22,7 @@ logger = logging.getLogger(__name__) + SUPPORTED_EXTENSIONS = ZIP_EXTENSIONS + TAR_EXTENSIONS try: