Skip to content

Commit 8e96382

Browse files
authored
Move static-checkers-only dependencies into their dedicated extras (#4586)
2 parents c117671 + 27c258f commit 8e96382

File tree

2 files changed

+7
-11
lines changed

2 files changed

+7
-11
lines changed

pyproject.toml

+5-8
Original file line numberDiff line numberDiff line change
@@ -54,14 +54,6 @@ test = [
5454
# for tools/finalize.py
5555
'jaraco.develop >= 7.21; python_version >= "3.9" and sys_platform != "cygwin"',
5656
"pytest-home >= 0.5",
57-
# pin mypy version so a new version doesn't suddenly cause the CI to fail,
58-
# until types-setuptools is removed from typeshed.
59-
# For help with static-typing issues, or mypy update, ping @Avasam
60-
"mypy==1.11.*",
61-
# No Python 3.11 dependencies require tomli, but needed for type-checking since we import it directly
62-
"tomli",
63-
# No Python 3.12 dependencies require importlib_metadata, but needed for type-checking since we import it directly
64-
"importlib_metadata",
6557
"pytest-subprocess",
6658

6759
# workaround for pypa/setuptools#4333
@@ -134,6 +126,11 @@ type = [
134126
"pytest-mypy",
135127

136128
# local
129+
130+
# pin mypy version so a new version doesn't suddenly cause the CI to fail,
131+
# until types-setuptools is removed from typeshed.
132+
# For help with static-typing issues, or mypy update, ping @Avasam
133+
"mypy==1.11.*",
137134
]
138135

139136

setuptools/tests/integration/test_pip_install_sdist.py

+2-3
Original file line numberDiff line numberDiff line change
@@ -202,13 +202,12 @@ def build_deps(package, sdist_file):
202202
"Manually" install them, since pip will not install build
203203
deps with `--no-build-isolation`.
204204
"""
205-
import tomli as toml
206-
207205
# delay importing, since pytest discovery phase may hit this file from a
208206
# testenv without tomli
207+
from setuptools.compat.py310 import tomllib
209208

210209
archive = Archive(sdist_file)
211-
info = toml.loads(_read_pyproject(archive))
210+
info = tomllib.loads(_read_pyproject(archive))
212211
deps = info.get("build-system", {}).get("requires", [])
213212
deps += EXTRA_BUILD_DEPS.get(package, [])
214213
# Remove setuptools from requirements (and deduplicate)

0 commit comments

Comments
 (0)