mypy check for untyped imports

Author: Avasam

mypy.ini

@@ -13,28 +13,20 @@ exclude = (?x)(
 	| ^setuptools/_distutils/ # Vendored
 	| ^setuptools/config/_validate_pyproject/ # Auto-generated
 	)
-disable_error_code = 
-	# TODO: Not all dependencies are typed. Namely: distutils._modified, wheel.wheelfile, and jaraco.*
-	; import-untyped,
-	# Ignoring attr-defined because setuptools wraps a lot of distutils classes, adding new attributes,
-	# w/o updating all the attributes and return types from the base classes for type-checkers to understand
-	# Especially with setuptools.dist.command vs distutils.dist.command vs setuptools._distutils.dist.command
-	# *.extern modules that actually live in *._vendor will also cause attr-defined issues on import
-	attr-defined,
+# Ignoring attr-defined because setuptools wraps a lot of distutils classes, adding new attributes,
+# w/o updating all the attributes and return types from the base classes for type-checkers to understand
+# Especially with setuptools.dist.command vs distutils.dist.command vs setuptools._distutils.dist.command
+# *.extern modules that actually live in *._vendor will also cause attr-defined issues on import
+disable_error_code = attr-defined
 
 # Avoid raising issues when importing from "extern" modules, as those are added to path dynamically.
 # https://github.com/pypa/setuptools/pull/3979#discussion_r1367968993
-[mypy-pkg_resources.extern.*,setuptools.extern.*]
+# All jaraco modules are still untyped
+[mypy-pkg_resources.extern.*,setuptools.extern.*,jaraco.*]
 ignore_missing_imports = True
 
-; [mypy-pkg_resources.tests.*,setuptools.tests.*]
-; disable_error_code =
-; 	# Tests include creating dynamic modules that won't exists statically before the test is run.
-; 	# Let's ignore all "import-not-found", as if an import really wasn't found, then the test would fail.
-; 	import-not-found,
-; 	# Many untyped "jaraco" modules
-; 	import-untyped,
-
-# Mypy issue, this vendored module is already excluded!
-[mypy-setuptools._vendor.packaging._manylinux]
+# pkg_resources tests create modules that won't exists statically before the test is run.
+# Let's ignore all "import-not-found" since, if an import really wasn't found, then the test would fail.
+# setuptools._vendor.packaging._manylinux: Mypy issue, this vendored module is already excluded!
+[mypy-pkg_resources.tests.*,setuptools._vendor.packaging._manylinux]
 disable_error_code = import-not-found

setuptools/command/build_clib.py

@@ -3,7 +3,7 @@
 from distutils import log
 
 try:
-    from distutils._modified import newer_pairwise_group  # type: ignore[import-not-found]
+    from distutils._modified import newer_pairwise_group  # type: ignore[import-untyped]
 except ImportError:
     # fallback for SETUPTOOLS_USE_DISTUTILS=stdlib
     from .._distutils._modified import newer_pairwise_group

setuptools/command/editable_wheel.py

@@ -59,7 +59,7 @@
 from .install_scripts import install_scripts as install_scripts_cls
 
 if TYPE_CHECKING:
-    from wheel.wheelfile import WheelFile  # noqa
+    from wheel.wheelfile import WheelFile  # type: ignore[import-untyped] # noqa
 
 _Path = Union[str, Path]
 _P = TypeVar("_P", bound=_Path)