WIP

Author: di

tests/unit/packaging/test_services.py

@@ -1059,6 +1059,13 @@ def test_check_project_name_typosquatting_prohibited(self, db_session):
         with pytest.raises(ProjectNameUnavailableTypoSquattingError):
             service.check_project_name_after_commit("numpi")
 
+    def test_check_project_name_typosquatting_no_typo(self, db_session):
+        # TODO: Update this test once we have a dynamic TopN approach
+        service = ProjectService(session=db_session)
+        ProhibitedProjectFactory.create(name="numpy")
+
+        assert service.check_project_name_after_commit("foobar") is None
+
     def test_check_project_name_ok(self, db_session):
         service = ProjectService(session=db_session)
 

tests/unit/packaging/test_typosnyper.py

@@ -10,14 +10,18 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
+import pretend
 import pytest
 
+from warehouse.packaging import typosnyper
+from warehouse.packaging.models import Project
 from warehouse.packaging.typosnyper import typo_check_name
 
 
 @pytest.mark.parametrize(
     ("name", "expected"),
     [
+        ("x", None),  # Pass, shorter than 4 characters
         ("numpy", None),  # Pass, no typos, exists
         ("NuMpy", None),  # Pass, same as `numpy` after canonicalization
         ("nuumpy", ("repeated_characters", "numpy")),
@@ -43,3 +47,13 @@ def test_typo_check_name(name, expected):
     }
 
     assert typo_check_name(name, corpus=test_names_corpus) == expected
+
+
+def test_check_typo_after_commit(db_request, monkeypatch):
+    # db_request.config.find_service_factory = pretend.raiser(LookupError)
+
+    project = Project(name="foobar")
+    db_request.db.add(project)
+    db_request.db.commit()
+
+    assert typosnyper.check_typo_after_commit.calls == []