https://github.com/pypi/warehouse/actions/runs/29690472841/job/88202227081 all tests pass but coverage failed I think because of some network flakiness (?)
DNS succeeded in the pr run -> PTR lines executed > 100% coverage.
then dns failed after merge -> the error was suppressed -> tests still passed, but PTR lines were skipped -> 99% coverage. (?)
Mock both of these calls in the relevant unit test:
- `dns.resolver.resolve``
dns.resolver.resolve_address
Do not use pretend.
Good First Issue: This issue is good for first time contributors. If you've already contributed to Warehouse, work on another issue without this label instead. If there is not a corresponding pull request for this issue, it is up for grabs. For directions for getting set up, see our Getting Started Guide.
If you are working on this issue and have questions, feel free to ask them here, in the #pypa-dev chat channel on Libera, the PyPA Discord or on the Discourse.
Screenshot Required: If your pull request makes a visual change, include a screenshot of your update. This helps our team give you feedback faster.
https://github.com/pypi/warehouse/actions/runs/29690472841/job/88202227081 all tests pass but coverage failed I think because of some network flakiness (?)
DNS succeeded in the pr run -> PTR lines executed > 100% coverage.
then dns failed after merge -> the error was suppressed -> tests still passed, but PTR lines were skipped -> 99% coverage. (?)
Mock both of these calls in the relevant unit test:
dns.resolver.resolve_addressDo not use
pretend.Good First Issue: This issue is good for first time contributors. If you've already contributed to Warehouse, work on another issue without this label instead. If there is not a corresponding pull request for this issue, it is up for grabs. For directions for getting set up, see our Getting Started Guide.
If you are working on this issue and have questions, feel free to ask them here, in the
#pypa-devchat channel on Libera, the PyPA Discord or on the Discourse.Screenshot Required: If your pull request makes a visual change, include a screenshot of your update. This helps our team give you feedback faster.