Release 0.0.7 and fix error related to --outputdirectory. (#10)

Author: tobiasraabe

CHANGES.rst

@@ -7,6 +7,13 @@ all releases are available on `Anaconda.org
 <https://anaconda.org/pytask/pytask-latex>`_.
 
 
+0.0.7 - 2020-10-14
+------------------
+
+- :gh:`10` fixes error that ``outputdirectory`` has to be relative to latex document due
+  to security problems.
+
+
 0.0.6 - 2020-10-14
 ------------------
 

setup.cfg

@@ -1,5 +1,5 @@
 [bumpversion]
-current_version = 0.0.6
+current_version = 0.0.7
 parse = (?P<major>\d+)\.(?P<minor>\d+)(\.(?P<patch>\d+))(\-?((dev)?(?P<dev>\d+))?)
 serialize = 
 	{major}.{minor}.{patch}dev{dev}

setup.py

@@ -3,7 +3,7 @@
 
 setup(
     name="pytask-latex",
-    version="0.0.6",
+    version="0.0.7",
     packages=find_packages(where="src"),
     package_dir={"": "src"},
     entry_points={"pytask": ["pytask_latex = pytask_latex.plugin"]},

src/pytask_latex/__init__.py

@@ -1 +1 @@
-__version__ = "0.0.6"
+__version__ = "0.0.7"

src/pytask_latex/collect.py

@@ -1,7 +1,9 @@
 """Collect tasks."""
 import copy
 import functools
+import os
 import subprocess
+from pathlib import Path
 from typing import Iterable
 from typing import Optional
 from typing import Union
@@ -61,14 +63,15 @@ def compile_latex_document(depends_on, produces, latex):
         latex.append(f"--jobname={compiled_document.stem}")
 
     # See comment in doc string.
-    out_relative_to_latex_source = compiled_document.parent.relative_to(
-        latex_document.parent
-    )
+    out_relative_to_latex_source = Path(
+        os.path.relpath(compiled_document.parent, latex_document.parent)
+    ).as_posix()
+
     subprocess.run(
         [
             "latexmk",
             *latex,
-            f"--output-directory={out_relative_to_latex_source.as_posix()}",
+            f"--output-directory={out_relative_to_latex_source}",
             f"{latex_document.as_posix()}",
         ],
         check=True,

tests/test_execute.py

@@ -97,6 +97,39 @@ def task_compile_document():
     assert tmp_path.joinpath("document.pdf").exists()
 
 
+@needs_latexmk
+@skip_on_github_actions_with_win
+@pytest.mark.end_to_end
+def test_compile_latex_document_w_relative(runner, tmp_path):
+    """Test simple compilation."""
+    task_source = f"""
+    import pytask
+
+    @pytask.mark.latex
+    @pytask.mark.depends_on("document.tex")
+    @pytask.mark.produces("{tmp_path.joinpath("bld", "document.pdf").as_posix()}")
+    def task_compile_document():
+        pass
+
+    """
+    tmp_path.joinpath("bld").mkdir()
+    tmp_path.joinpath("src").mkdir()
+    tmp_path.joinpath("src", "task_dummy.py").write_text(textwrap.dedent(task_source))
+
+    latex_source = r"""
+    \documentclass{report}
+    \begin{document}
+    I was tired of my lady
+    \end{document}
+    """
+    tmp_path.joinpath("src", "document.tex").write_text(textwrap.dedent(latex_source))
+
+    result = runner.invoke(cli, [tmp_path.as_posix()])
+
+    assert result.exit_code == 0
+    assert tmp_path.joinpath("bld", "document.pdf").exists()
+
+
 @needs_latexmk
 @skip_on_github_actions_with_win
 @pytest.mark.end_to_end