Remove unnecessary hook. (#20)

Author: tobiasraabe

.github/workflows/continuous-integration-workflow.yml renamed to .github/workflows/main.yml

@@ -1,4 +1,4 @@
-name: Continuous Integration Workflow
+name: main
 
 # Automatically cancel a previous run.
 concurrency:

CHANGES.rst

@@ -7,6 +7,12 @@ all releases are available on `PyPI <https://pypi.org/project/pytask-stata>`_ an
 `Anaconda.org <https://anaconda.org/conda-forge/pytask-stata>`_.
 
 
+0.2.0 - 2022-xx-xx
+------------------
+
+- :gh`:`20` removes an unnecessary hook implementation.
+
+
 0.1.2 - 2022-02-08
 ------------------
 

README.rst

@@ -16,7 +16,7 @@
     :alt: PyPI - License
     :target: https://pypi.org/project/pytask-stata
 
-.. image:: https://img.shields.io/github/workflow/status/pytask-dev/pytask-stata/Continuous%20Integration%20Workflow/main
+.. image:: https://img.shields.io/github/workflow/status/pytask-dev/pytask-stata/main/main
    :target: https://github.com/pytask-dev/pytask-stata/actions?query=branch%3Amain
 
 .. image:: https://codecov.io/gh/pytask-dev/pytask-stata/branch/main/graph/badge.svg

src/pytask_stata/collect.py

@@ -9,9 +9,7 @@
 
 from _pytask.config import hookimpl
 from _pytask.mark_utils import get_specific_markers_from_task
-from _pytask.mark_utils import has_marker
 from _pytask.nodes import FilePathNode
-from _pytask.nodes import PythonFunctionTask
 from _pytask.parametrize import _copy_func
 from pytask_stata.shared import convert_task_id_to_name_of_log_file
 from pytask_stata.shared import get_node_from_dictionary
@@ -37,23 +35,6 @@ def run_stata_script(stata, cwd):
     subprocess.run(stata, cwd=cwd, check=True)
 
 
-@hookimpl
-def pytask_collect_task(session, path, name, obj):
-    """Collect a task which is a function.
-
-    There is some discussion on how to detect functions in this `thread
-    <https://stackoverflow.com/q/624926/7523785>`_. :class:`types.FunctionType` does not
-    detect built-ins which is not possible anyway.
-
-    """
-    if name.startswith("task_") and callable(obj) and has_marker(obj, "stata"):
-        task = PythonFunctionTask.from_path_name_function_session(
-            path, name, obj, session
-        )
-
-        return task
-
-
 @hookimpl
 def pytask_collect_task_teardown(session, task):
     """Perform some checks and prepare the task function."""

tests/test_collect.py

@@ -8,7 +8,6 @@
 from _pytask.nodes import FilePathNode
 from pytask_stata.collect import _merge_all_markers
 from pytask_stata.collect import _prepare_cmd_options
-from pytask_stata.collect import pytask_collect_task
 from pytask_stata.collect import pytask_collect_task_teardown
 from pytask_stata.collect import stata
 from pytask_stata.shared import get_node_from_dictionary
@@ -97,25 +96,6 @@ def test_prepare_cmd_options(args, stata_source_key, platform):
     assert result == expected
 
 
-@pytest.mark.unit
-@pytest.mark.parametrize(
-    "name, expected",
-    [("task_dummy", True), ("invalid_name", None)],
-)
-def test_pytask_collect_task(name, expected):
-    session = DummyClass()
-    session.config = {"stata": "stata"}
-    path = Path("some_path")
-    task_dummy.pytaskmark = [Mark("stata", (), {})]
-
-    task = pytask_collect_task(session, path, name, task_dummy)
-
-    if expected:
-        assert task
-    else:
-        assert not task
-
-
 @pytest.mark.unit
 @pytest.mark.parametrize(
     "depends_on, produces, expectation",

tests/test_parallel.py

@@ -37,14 +37,14 @@ def task_execute_do_file():
     tmp_path.joinpath("task_dummy.py").write_text(textwrap.dedent(source))
 
     do_file = """
-    sleep 2000
+    sleep 4000
     sysuse auto, clear
     save 1
     """
     tmp_path.joinpath("script_1.do").write_text(textwrap.dedent(do_file))
 
     do_file = """
-    sleep 2000
+    sleep 4000
     sysuse auto, clear
     save 2
     """
@@ -83,7 +83,7 @@ def task_execute_do_file():
     tmp_path.joinpath("task_dummy.py").write_text(textwrap.dedent(source))
 
     do_file = """
-    sleep 2000
+    sleep 4000
     sysuse auto, clear
     args produces
     save "`produces'"