implementation that cannot extend the cli anymore.

Author: tobiasraabe

src/_pytask/build.py

@@ -15,7 +15,6 @@
 from _pytask.capture_utils import CaptureMethod
 from _pytask.capture_utils import ShowCapture
 from _pytask.click import ColoredCommand
-from _pytask.config import hookimpl
 from _pytask.config_utils import find_project_root_and_config
 from _pytask.config_utils import read_config
 from _pytask.console import console
@@ -26,6 +25,7 @@
 from _pytask.outcomes import ExitCode
 from _pytask.path import HashPathCache
 from _pytask.pluginmanager import get_plugin_manager
+from _pytask.pluginmanager import hookimpl
 from _pytask.session import Session
 from _pytask.shared import parse_paths
 from _pytask.shared import to_list
@@ -91,7 +91,7 @@ def build(  # noqa: C901, PLR0912, PLR0913
     sort_table: bool = True,
     stop_after_first_failure: bool = False,
     strict_markers: bool = False,
-    tasks: Callable[..., Any] | PTask | Iterable[Callable[..., Any] | PTask] = (),
+    tasks: Iterable[Callable[..., Any] | PTask] = (),
     task_files: str | Iterable[str] = "task_*.py",
     trace: bool = False,
     verbose: int = 1,
@@ -161,7 +161,8 @@ def build(  # noqa: C901, PLR0912, PLR0913
     strict_markers
         Raise errors for unknown markers.
     tasks
-        A task or a collection of tasks that is passed to ``pytask.build(tasks=...)``.
+        A collection of tasks that is passed to
+        :func:`pytask.build(tasks=...) <pytask.build>`.
     task_files
         A pattern to describe modules that contain tasks.
     trace
@@ -171,7 +172,7 @@ def build(  # noqa: C901, PLR0912, PLR0913
 
     Returns
     -------
-    session : pytask.Session
+    session: Session
         The session captures all the information of the current run.
 
     """

src/_pytask/capture.py

@@ -44,7 +44,7 @@
 from _pytask.capture_utils import CaptureMethod
 from _pytask.capture_utils import ShowCapture
 from _pytask.click import EnumChoice
-from _pytask.config import hookimpl
+from _pytask.pluginmanager import hookimpl
 from _pytask.shared import convert_to_enum
 
 if TYPE_CHECKING:

src/_pytask/clean.py

@@ -14,7 +14,6 @@
 import click
 from _pytask.click import ColoredCommand
 from _pytask.click import EnumChoice
-from _pytask.config import hookimpl
 from _pytask.console import console
 from _pytask.exceptions import CollectionError
 from _pytask.git import get_all_files
@@ -27,6 +26,7 @@
 from _pytask.path import find_common_ancestor
 from _pytask.path import relative_to
 from _pytask.pluginmanager import get_plugin_manager
+from _pytask.pluginmanager import hookimpl
 from _pytask.session import Session
 from _pytask.shared import to_list
 from _pytask.traceback import Traceback

src/_pytask/cli.py

@@ -2,34 +2,29 @@
 from __future__ import annotations
 
 from typing import Any
-from typing import TYPE_CHECKING
 
 import click
 from _pytask.click import ColoredGroup
-from _pytask.config import hookimpl
 from _pytask.pluginmanager import get_plugin_manager
 from packaging.version import parse as parse_version
 
-if TYPE_CHECKING:
-    import pluggy
-
 
 _CONTEXT_SETTINGS: dict[str, Any] = {
     "help_option_names": ("-h", "--help"),
     "show_default": True,
 }
 
 
-if parse_version(click.__version__) < parse_version("8"):  # pragma: no cover
-    _VERSION_OPTION_KWARGS: dict[str, Any] = {}
-else:  # pragma: no cover
+if parse_version(click.__version__) >= parse_version("8"):  # pragma: no cover
     _VERSION_OPTION_KWARGS = {"package_name": "pytask"}
+else:  # pragma: no cover
+    _VERSION_OPTION_KWARGS = {}
 
 
 def _extend_command_line_interface(cli: click.Group) -> click.Group:
     """Add parameters from plugins to the commandline interface."""
     pm = get_plugin_manager()
-    pm.hook.pytask_extend_command_line_interface(cli=cli)
+    pm.hook.pytask_extend_command_line_interface.call_historic(kwargs={"cli": cli})
     _sort_options_for_each_command_alphabetically(cli)
     return cli
 
@@ -42,54 +37,6 @@ def _sort_options_for_each_command_alphabetically(cli: click.Group) -> None:
         )
 
 
-@hookimpl
-def pytask_add_hooks(pm: pluggy.PluginManager) -> None:
-    """Add hooks."""
-    from _pytask import build
-    from _pytask import capture
-    from _pytask import clean
-    from _pytask import collect
-    from _pytask import collect_command
-    from _pytask import config
-    from _pytask import database
-    from _pytask import debugging
-    from _pytask import execute
-    from _pytask import dag_command
-    from _pytask import live
-    from _pytask import logging
-    from _pytask import mark
-    from _pytask import nodes
-    from _pytask import parameters
-    from _pytask import persist
-    from _pytask import profile
-    from _pytask import dag
-    from _pytask import skipping
-    from _pytask import task
-    from _pytask import warnings
-
-    pm.register(build)
-    pm.register(capture)
-    pm.register(clean)
-    pm.register(collect)
-    pm.register(collect_command)
-    pm.register(config)
-    pm.register(database)
-    pm.register(debugging)
-    pm.register(execute)
-    pm.register(dag_command)
-    pm.register(live)
-    pm.register(logging)
-    pm.register(mark)
-    pm.register(nodes)
-    pm.register(parameters)
-    pm.register(persist)
-    pm.register(profile)
-    pm.register(dag)
-    pm.register(skipping)
-    pm.register(task)
-    pm.register(warnings)
-
-
 @click.group(
     cls=ColoredGroup,
     context_settings=_CONTEXT_SETTINGS,

src/_pytask/collect.py

@@ -15,7 +15,6 @@
 from _pytask.collect_utils import create_name_of_python_node
 from _pytask.collect_utils import parse_dependencies_from_task_function
 from _pytask.collect_utils import parse_products_from_task_function
-from _pytask.config import hookimpl
 from _pytask.config import IS_FILE_SYSTEM_CASE_SENSITIVE
 from _pytask.console import console
 from _pytask.console import create_summary_panel
@@ -36,6 +35,7 @@
 from _pytask.path import find_case_sensitive_path
 from _pytask.path import import_path
 from _pytask.path import shorten_path
+from _pytask.pluginmanager import hookimpl
 from _pytask.reports import CollectionReport
 from _pytask.shared import find_duplicates
 from _pytask.task_utils import COLLECTED_TASKS

src/_pytask/collect_command.py

@@ -8,7 +8,6 @@
 
 import click
 from _pytask.click import ColoredCommand
-from _pytask.config import hookimpl
 from _pytask.console import console
 from _pytask.console import create_url_style_for_path
 from _pytask.console import FILE_ICON
@@ -28,6 +27,7 @@
 from _pytask.path import find_common_ancestor
 from _pytask.path import relative_to
 from _pytask.pluginmanager import get_plugin_manager
+from _pytask.pluginmanager import hookimpl
 from _pytask.session import Session
 from _pytask.tree_util import tree_leaves
 from rich.text import Text

src/_pytask/config.py

@@ -4,14 +4,15 @@
 import tempfile
 from pathlib import Path
 from typing import Any
+from typing import TYPE_CHECKING
 
-import pluggy
+from _pytask.pluginmanager import hookimpl
 from _pytask.shared import parse_markers
 from _pytask.shared import parse_paths
 from _pytask.shared import to_list
 
-
-hookimpl = pluggy.HookimplMarker("pytask")
+if TYPE_CHECKING:
+    import pluggy
 
 
 _IGNORED_FOLDERS: list[str] = [".git/*", ".venv/*"]

src/_pytask/dag.py

@@ -6,7 +6,6 @@
 from typing import TYPE_CHECKING
 
 import networkx as nx
-from _pytask.config import hookimpl
 from _pytask.console import ARROW_DOWN_ICON
 from _pytask.console import console
 from _pytask.console import FILE_ICON
@@ -19,6 +18,7 @@
 from _pytask.node_protocols import PNode
 from _pytask.node_protocols import PTask
 from _pytask.nodes import PythonNode
+from _pytask.pluginmanager import hookimpl
 from _pytask.reports import DagReport
 from _pytask.shared import reduce_names_of_multiple_nodes
 from _pytask.tree_util import tree_map

src/_pytask/dag_command.py

@@ -12,7 +12,6 @@
 from _pytask.click import EnumChoice
 from _pytask.compat import check_for_optional_program
 from _pytask.compat import import_optional_dependency
-from _pytask.config import hookimpl
 from _pytask.config_utils import find_project_root_and_config
 from _pytask.config_utils import read_config
 from _pytask.console import console
@@ -21,6 +20,7 @@
 from _pytask.exceptions import ResolvingDependenciesError
 from _pytask.outcomes import ExitCode
 from _pytask.pluginmanager import get_plugin_manager
+from _pytask.pluginmanager import hookimpl
 from _pytask.session import Session
 from _pytask.shared import parse_paths
 from _pytask.shared import reduce_names_of_multiple_nodes

src/_pytask/database.py

@@ -4,8 +4,8 @@
 from pathlib import Path
 from typing import Any
 
-from _pytask.config import hookimpl
 from _pytask.database_utils import create_database
+from _pytask.pluginmanager import hookimpl
 from sqlalchemy.engine import make_url
 
 

src/_pytask/debugging.py

@@ -10,10 +10,10 @@
 from typing import TYPE_CHECKING
 
 import click
-from _pytask.config import hookimpl
 from _pytask.console import console
 from _pytask.node_protocols import PTask
 from _pytask.outcomes import Exit
+from _pytask.pluginmanager import hookimpl
 from _pytask.traceback import Traceback
 
 

src/_pytask/execute.py

@@ -7,7 +7,6 @@
 from typing import Any
 from typing import TYPE_CHECKING
 
-from _pytask.config import hookimpl
 from _pytask.config import IS_FILE_SYSTEM_CASE_SENSITIVE
 from _pytask.console import console
 from _pytask.console import create_summary_panel
@@ -33,6 +32,7 @@
 from _pytask.outcomes import SkippedUnchanged
 from _pytask.outcomes import TaskOutcome
 from _pytask.outcomes import WouldBeExecuted
+from _pytask.pluginmanager import hookimpl
 from _pytask.reports import ExecutionReport
 from _pytask.traceback import remove_traceback_from_exc_info
 from _pytask.tree_util import tree_leaves

src/_pytask/hookspecs.py

@@ -46,7 +46,7 @@ def pytask_add_hooks(pm: pluggy.PluginManager) -> None:
 # Hooks for the command-line interface.
 
 
-@hookspec
+@hookspec(historic=True)
 def pytask_extend_command_line_interface(cli: click.Group) -> None:
     """Extend the command line interface.
 

src/_pytask/live.py

@@ -7,11 +7,11 @@
 from typing import TYPE_CHECKING
 
 import click
-from _pytask.config import hookimpl
 from _pytask.console import console
 from _pytask.console import format_task_name
 from _pytask.outcomes import CollectionOutcome
 from _pytask.outcomes import TaskOutcome
+from _pytask.pluginmanager import hookimpl
 from attrs import define
 from attrs import field
 from rich.box import ROUNDED

src/_pytask/logging.py

@@ -12,9 +12,9 @@
 import _pytask
 import click
 import pluggy
-from _pytask.config import hookimpl
 from _pytask.console import console
 from _pytask.console import IS_WINDOWS_TERMINAL
+from _pytask.pluginmanager import hookimpl
 from _pytask.reports import ExecutionReport
 from _pytask.traceback import Traceback
 from rich.text import Text

src/_pytask/mark/__init__.py

@@ -8,7 +8,6 @@
 
 import click
 from _pytask.click import ColoredCommand
-from _pytask.config import hookimpl
 from _pytask.console import console
 from _pytask.dag_utils import task_and_preceding_tasks
 from _pytask.exceptions import ConfigurationError
@@ -20,6 +19,7 @@
 from _pytask.mark.structures import MarkGenerator
 from _pytask.outcomes import ExitCode
 from _pytask.pluginmanager import get_plugin_manager
+from _pytask.pluginmanager import hookimpl
 from _pytask.session import Session
 from _pytask.shared import parse_markers
 from attrs import define