Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix packages when it doesn't include dirs with source #10

Open
thatch opened this issue Oct 2, 2020 · 1 comment
Open

Fix packages when it doesn't include dirs with source #10

thatch opened this issue Oct 2, 2020 · 1 comment
Labels
good first issue Good for newcomers

Comments

@thatch
Copy link
Member

thatch commented Oct 2, 2020

See python-packaging/highlighter#1

@thatch thatch added the good first issue Good for newcomers label Oct 3, 2020
@thatch
Copy link
Member Author

thatch commented Oct 3, 2020

A common layout is one like this:

setup.py
the_package/
  __init__.py
  foo.py
  tests/
    __init__.py
    test_foo.py

If you specify

packages =
  the_package

it should be corrected to

packages =
  the_package
  the_package.tests

The crawling logic can probably use importall.finder.find_importable_names relative to package_dir from the config.

This is an intermediate issue, and some familiarity with packaging with setuptools is helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant