Commit 346ddf2
committed
Fix sdist directory name extraction in _prepare_sdist
str.rstrip() treats its argument as a set of characters, not a
suffix string. For a .tar.gz archive, archive.suffix returns
'.gz', so rstrip('.gz') strips the characters {'.', 'g', 'z'}
from the right, giving 'package-1.0.tar' instead of 'package-1.0'.
For .zip files the character-stripping behavior can be even worse
— e.g. 'zipp-24.0.0.zip'.rstrip('.zip') over-strips because the
package name itself ends with characters in the strip set.
Replace rstrip with proper suffix matching against known archive
extensions.1 parent ad9ab00 commit 346ddf2
2 files changed
+37
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
108 | 108 | | |
109 | 109 | | |
110 | 110 | | |
111 | | - | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
112 | 119 | | |
113 | 120 | | |
114 | 121 | | |
| |||
0 commit comments