Merge pull request #75 from RatanShreshtha/Fix_test_connect_ipv6_addr

Fix test_connect_ipv6_addr.

Author: njsmith

src/urllib3/_async/connection.py

@@ -210,7 +210,16 @@ def _build_tunnel_request(host, port, headers):
     Builds a urllib3 Request object that is set up correctly to request a proxy
     to establish a TCP tunnel to the remote host.
     """
-    target = "%s:%d" % (host, port)
+
+    try:
+        socket.inet_pton(socket.AF_INET6, host)
+    except OSError:
+        # Not a raw IPv6 address
+        target = "%s:%d" % (host, port)
+    else:
+        # raw IPv6 address
+        target = "[%s]:%d" % (host, port)
+
     if not isinstance(target, bytes):
         target = target.encode('latin1')
 

test/with_dummyserver/test_socketlevel.py

@@ -1017,7 +1017,6 @@ def handler(listener):
         assert exception.response.status_code == 401
         assert exception.response.headers['x-custom-header'] == 'yougotit'
 
-    @pytest.mark.xfail
     def test_connect_ipv6_addr(self):
         ipv6_addr = '2001:4998:c:a06::2:4008'