Enable extra error codes for mypy (#3239)

Author: A5rocks

pyproject.toml

@@ -193,6 +193,7 @@ files = ["src/trio/", "docs/source/*.py"]
 ignore_missing_imports = true
 
 # Be strict about use of Mypy
+enable_error_code = ["truthy-bool", "mutable-override"]
 local_partial_types = true
 warn_unused_ignores = true
 warn_unused_configs = true

src/trio/_repl.py

@@ -17,17 +17,13 @@
 
 @final
 class TrioInteractiveConsole(InteractiveConsole):
-    # code.InteractiveInterpreter defines locals as Mapping[str, Any]
-    # but when we pass this to FunctionType it expects a dict. So
-    # we make the type more specific on our subclass
-    locals: dict[str, object]
-
     def __init__(self, repl_locals: dict[str, object] | None = None) -> None:
         super().__init__(locals=repl_locals)
         self.compile.compiler.flags |= ast.PyCF_ALLOW_TOP_LEVEL_AWAIT
 
     def runcode(self, code: types.CodeType) -> None:
-        func = types.FunctionType(code, self.locals)
+        # https://github.com/python/typeshed/issues/13768
+        func = types.FunctionType(code, self.locals)  # type: ignore[arg-type]
         if inspect.iscoroutinefunction(func):
             result = trio.from_thread.run(outcome.acapture, func)
         else:

src/trio/_tests/check_type_completeness.py

@@ -49,7 +49,7 @@ def has_docstring_at_runtime(name: str) -> bool:
     """
     # This assert is solely for stopping isort from removing our imports of trio & trio.testing
     # It could also be done with isort:skip, but that'd also disable import sorting and the like.
-    assert trio.testing
+    assert trio.testing is not None
 
     # figure out what part of the name is the module, so we can "import" it
     name_parts = name.split(".")
@@ -116,7 +116,7 @@ def check_type(
     expected_errors: list[object],
 ) -> list[object]:
     # convince isort we use the trio import
-    assert trio
+    assert trio is not None
 
     # run pyright, load output into json
     res = run_pyright(platform)

src/trio/_tests/type_tests/raisesgroup.py

@@ -169,7 +169,7 @@ def check_multiple_exceptions_1() -> None:
     d = a
     d = b
     d = c
-    assert d
+    assert isinstance(d, RaisesGroup)
 
 
 def check_multiple_exceptions_2() -> None:
@@ -182,7 +182,7 @@ def check_multiple_exceptions_2() -> None:
     d = a
     d = b
     d = c
-    assert d
+    assert isinstance(d, RaisesGroup)
 
 
 def check_raisesgroup_overloads() -> None: