Skip to content

Commit e2a80f3

Browse files
committed
gh-127146: Update test skips for Emscripten 4.0.1
1 parent 4533036 commit e2a80f3

9 files changed

+6
-13
lines changed

Lib/test/test_genericpath.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ def test_exists(self):
161161
self.assertIs(self.pathmodule.lexists(path=filename), True)
162162

163163
@unittest.skipUnless(hasattr(os, "pipe"), "requires os.pipe()")
164-
@unittest.skipIf(is_emscripten, "Emscripten pipe fds have no stat")
164+
@unittest.skipIf(is_emscripten, "Fixed in next Emscripten release after 4.0.1")
165165
def test_exists_fd(self):
166166
r, w = os.pipe()
167167
try:

Lib/test/test_io.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -3933,7 +3933,7 @@ def test_issue35928(self):
39333933
self.assertEqual(res + f.readline(), 'foo\nbar\n')
39343934

39353935
@unittest.skipUnless(hasattr(os, "pipe"), "requires os.pipe()")
3936-
@unittest.skipIf(support.is_emscripten, "Would be fixed by emscripten-core/emscripten#23306")
3936+
@unittest.skipIf(support.is_emscripten, "Fixed in next Emscripten release after 4.0.1")
39373937
def test_read_non_blocking(self):
39383938
import os
39393939
r, w = os.pipe()

Lib/test/test_ntpath.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -940,7 +940,7 @@ def check_error(paths, expected):
940940
self.assertRaises(TypeError, ntpath.commonpath, ['C:\\Foo', b'Foo\\Baz'])
941941
self.assertRaises(TypeError, ntpath.commonpath, ['Foo', b'C:\\Foo\\Baz'])
942942

943-
@unittest.skipIf(is_emscripten, "Emscripten cannot fstat unnamed files.")
943+
@unittest.skipIf(is_emscripten, "Fixed in next Emscripten release after 4.0.1")
944944
def test_sameopenfile(self):
945945
with TemporaryFile() as tf1, TemporaryFile() as tf2:
946946
# Make sure the same file is really the same

Lib/test/test_os.py

-1
Original file line numberDiff line numberDiff line change
@@ -4979,7 +4979,6 @@ def test_unpickable(self):
49794979
self.assertRaises(TypeError, pickle.dumps, scandir_iter, filename)
49804980
scandir_iter.close()
49814981

4982-
@unittest.skipIf(support.is_emscripten, "Fixed by emscripten-core/emscripten#23139, remove when next Emscripten release comes out")
49834982
def check_entry(self, entry, name, is_dir, is_file, is_symlink):
49844983
self.assertIsInstance(entry, os.DirEntry)
49854984
self.assertEqual(entry.name, name)

Lib/test/test_shutil.py

-1
Original file line numberDiff line numberDiff line change
@@ -1587,7 +1587,6 @@ def test_copyfile_same_file(self):
15871587
# the path as a directory, but on AIX the trailing slash has no effect
15881588
# and is considered as a file.
15891589
@unittest.skipIf(AIX, 'Not valid on AIX, see gh-92670')
1590-
@unittest.skipIf(support.is_emscripten, 'Fixed by emscripten-core/emscripten#23218, remove when next Emscripten release comes out')
15911590
def test_copyfile_nonexistent_dir(self):
15921591
# Issue 43219
15931592
src_dir = self.mkdtemp()

Lib/test/test_signal.py

+3-5
Original file line numberDiff line numberDiff line change
@@ -253,9 +253,7 @@ def test_invalid_socket(self):
253253
self.assertRaises((ValueError, OSError),
254254
signal.set_wakeup_fd, fd)
255255

256-
# Emscripten does not support fstat on pipes yet.
257-
# https://github.com/emscripten-core/emscripten/issues/16414
258-
@unittest.skipIf(support.is_emscripten, "Emscripten cannot fstat pipes.")
256+
@unittest.skipIf(support.is_emscripten, "Fixed in next Emscripten release after 4.0.1")
259257
@unittest.skipUnless(hasattr(os, "pipe"), "requires os.pipe()")
260258
def test_set_wakeup_fd_result(self):
261259
r1, w1 = os.pipe()
@@ -274,7 +272,7 @@ def test_set_wakeup_fd_result(self):
274272
self.assertEqual(signal.set_wakeup_fd(-1), w2)
275273
self.assertEqual(signal.set_wakeup_fd(-1), -1)
276274

277-
@unittest.skipIf(support.is_emscripten, "Emscripten cannot fstat pipes.")
275+
@unittest.skipIf(support.is_emscripten, "Fixed in next Emscripten release after 4.0.1")
278276
@unittest.skipUnless(support.has_socket_support, "needs working sockets.")
279277
def test_set_wakeup_fd_socket_result(self):
280278
sock1 = socket.socket()
@@ -295,7 +293,7 @@ def test_set_wakeup_fd_socket_result(self):
295293
# On Windows, files are always blocking and Windows does not provide a
296294
# function to test if a socket is in non-blocking mode.
297295
@unittest.skipIf(sys.platform == "win32", "tests specific to POSIX")
298-
@unittest.skipIf(support.is_emscripten, "Emscripten cannot fstat pipes.")
296+
@unittest.skipIf(support.is_emscripten, "Fixed in next Emscripten release after 4.0.1")
299297
@unittest.skipUnless(hasattr(os, "pipe"), "requires os.pipe()")
300298
def test_set_wakeup_fd_blocking(self):
301299
rfd, wfd = os.pipe()

Lib/test/test_tarfile.py

-1
Original file line numberDiff line numberDiff line change
@@ -3800,7 +3800,6 @@ def test_absolute_hardlink(self):
38003800
"'parent' is a link to an absolute path")
38013801

38023802
@symlink_test
3803-
@unittest.skipIf(support.is_emscripten, "Fixed by emscripten-core/emscripten#23136, remove when next Emscripten release comes out")
38043803
def test_sly_relative0(self):
38053804
# Inspired by 'relative0' in jwilk/traversal-archives
38063805
with ArchiveMaker() as arc:

Lib/test/test_zipfile/test_core.py

-1
Original file line numberDiff line numberDiff line change
@@ -623,7 +623,6 @@ def test_write_to_readonly(self):
623623
with self.assertRaises(ValueError):
624624
zipfp.open(TESTFN, mode='w')
625625

626-
@unittest.skipIf(is_emscripten, "Fixed by emscripten-core/emscripten#23310")
627626
def test_add_file_before_1980(self):
628627
# Set atime and mtime to 1970-01-01
629628
os.utime(TESTFN, (0, 0))

Lib/test/test_zipimport.py

-1
Original file line numberDiff line numberDiff line change
@@ -1038,7 +1038,6 @@ def testEmptyFile(self):
10381038
self.assertZipFailure(TESTMOD)
10391039

10401040
@unittest.skipIf(support.is_wasi, "mode 000 not supported.")
1041-
@unittest.skipIf(support.is_emscripten, "Fixed by emscripten-core/emscripten#23137, remove when next Emscripten release comes out")
10421041
def testFileUnreadable(self):
10431042
os_helper.unlink(TESTMOD)
10441043
fd = os.open(TESTMOD, os.O_CREAT, 000)

0 commit comments

Comments
 (0)