Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_xml_etree_c fails on Brew [email protected] #128838

Closed
shohidulhaque opened this issue Jan 14, 2025 · 8 comments
Closed

test_xml_etree_c fails on Brew [email protected] #128838

shohidulhaque opened this issue Jan 14, 2025 · 8 comments
Labels
3.13 bugs and security fixes build The build process and cross-build OS-mac tests Tests in the Lib/test dir topic-XML type-bug An unexpected behavior, bug, or error

Comments

@shohidulhaque
Copy link

shohidulhaque commented Jan 14, 2025

Bug report

Bug description:

When building on brew there is a build failure.

The details are:

==> Upgrading python@3.13
  3.13.0_1 -> 3.13.1
==> Downloading https://formulae.brew.sh/api/formula.jws.json

==> Patching
==> Applying 3.13-sysconfig.diff
==> ./configure --enable-ipv6 --datarootdir=/Users/shohidul.haque/homebrew/Cellar/python@3.13/3.13.1/share --datadir=/Users/shohidul.haque/homebrew/Cellar/python@3.13/3.13.1/share --without-ensurepip --en
==> make
Last 15 lines from /Users/shohidul.haque/Library/Logs/Homebrew/python@3.13/02.make:
0:00:36 load avg: 7.60 [39/44] test_str
0:00:36 load avg: 7.55 [40/44] test_struct
0:00:37 load avg: 7.55 [41/44] test_tabnanny
0:00:37 load avg: 7.55 [42/44] test_time
0:00:39 load avg: 7.55 [43/44] test_xml_etree
test test_xml_etree failed
0:00:39 load avg: 7.55 [44/44] test_xml_etree_c -- test_xml_etree failed (4 failures)
test test_xml_etree_c failed
test_xml_etree_c failed (3 failures)

Total duration: 40.4 sec
Total tests: run=9,394 failures=7 skipped=198
Total test files: run=44/44 failed=2
Result: FAILURE
make: *** [profile-run-stamp] Error 2

Do not report this issue to Homebrew/brew or Homebrew/homebrew-core!

CPython versions tested on:

3.13

Operating systems tested on:

macOS

@shohidulhaque shohidulhaque added the type-bug An unexpected behavior, bug, or error label Jan 14, 2025
@picnixz picnixz changed the title Build Failure on Brew [email protected] Build Failure on Brew [email protected] Jan 14, 2025
@picnixz picnixz added OS-mac build The build process and cross-build 3.13 bugs and security fixes labels Jan 14, 2025
@picnixz picnixz changed the title Build Failure on Brew [email protected] test_xml_etree_c fails on Brew [email protected] Jan 14, 2025
@picnixz picnixz added tests Tests in the Lib/test dir topic-XML labels Jan 14, 2025
@trey-pindrop
Copy link

trey-pindrop commented Jan 18, 2025

@shohidulhaque you didn't mention which version of macOS or CPU architecture (Intel or Apple Silicon) you're getting this on.

I'm getting it on macOS Sonoma 14.7.2 on Apple Silicon (M3 Pro). This r/MacOS subreddit thread had a user report this on macOS 13 and 14, but not 15 on Apple Silicon.

One other thing: since this is my work Mac I have Homebrew installed to a subdirectory in /Users/${USER}, so most brew packages I have to compile from source.

@aisk
Copy link
Contributor

aisk commented Jan 19, 2025

Hi, I'm using a Intel based mac with version 14.2 (Sonoma), and I can't reproduce the error:

❯ brew reinstall [email protected] -s
Warning: building from source is not supported!
You're on your own. Failures are expected so don't create any issues, please!
==> Fetching [email protected]
==> Downloading https://raw.githubusercontent.com/Homebrew/homebrew-core/ee87a31364fb312aed9030524269b8d2da916249/Formula/p/[email protected]
################################################################################################################################################## 100.0%
==> Downloading https://raw.githubusercontent.com/Homebrew/formula-patches/8b5bcbb262d1ea4e572bba55043bf7d2341a6821/python/3.13-sysconfig.diff
################################################################################################################################################## 100.0%
==> Downloading https://files.pythonhosted.org/packages/d5/ae/09427bea9227a33ec834ed5461432752fd5d02b14f93dd68406c91684622/flit_core-3.10.1.tar.gz
################################################################################################################################################## 100.0%
==> Downloading https://files.pythonhosted.org/packages/f4/b1/b422acd212ad7eedddaf7981eee6e5de085154ff726459cf2da7c5a184c1/pip-24.3.1.tar.gz
################################################################################################################################################## 100.0%
==> Downloading https://files.pythonhosted.org/packages/43/54/292f26c208734e9a7f067aea4a7e282c080750c4546559b58e2e45413ca0/setuptools-75.6.0.tar.gz
################################################################################################################################################## 100.0%
==> Downloading https://files.pythonhosted.org/packages/8a/98/2d9906746cdc6a6ef809ae6338005b3f21bb568bea3165cfc6a243fdc25c/wheel-0.45.1.tar.gz
################################################################################################################################################## 100.0%
==> Downloading https://www.python.org/ftp/python/3.13.1/Python-3.13.1.tgz
################################################################################################################################################## 100.0%
==> Reinstalling [email protected]
==> Patching
==> Applying 3.13-sysconfig.diff
==> ./configure --enable-ipv6 --datarootdir=/opt/homebrew-x86/Cellar/[email protected]/3.13.1/share --datadir=/opt/homebrew-x86/Cellar/[email protected]/3.13.1/share
==> make
==> make install PYTHONAPPSDIR=/opt/homebrew-x86/Cellar/[email protected]/3.13.1
==> make frameworkinstallextras PYTHONAPPSDIR=/opt/homebrew-x86/Cellar/[email protected]/3.13.1/share/[email protected]
==> /opt/homebrew-x86/Cellar/[email protected]/3.13.1/bin/python3.13 -m venv /private/tmp/pythonA3.13-20250119-74207-9gvbq4/Python-3.13.1/whl_build
==> /private/tmp/pythonA3.13-20250119-74207-9gvbq4/Python-3.13.1/whl_build/bin/pip3 install -v --no-binary :all: --no-index .
==> /private/tmp/pythonA3.13-20250119-74207-9gvbq4/Python-3.13.1/whl_build/bin/pip3 install -v --no-binary :all: --no-index .
==> /private/tmp/pythonA3.13-20250119-74207-9gvbq4/Python-3.13.1/whl_build/bin/pip3 install -v --no-binary :all: --no-index .
==> /private/tmp/pythonA3.13-20250119-74207-9gvbq4/Python-3.13.1/whl_build/bin/pip3 wheel -v --no-binary :all: --no-index --wheel-dir=/opt/homebrew-x86/C
==> /private/tmp/pythonA3.13-20250119-74207-9gvbq4/Python-3.13.1/whl_build/bin/pip3 wheel -v --no-binary :all: --no-index --wheel-dir=/opt/homebrew-x86/C
==> /opt/homebrew-x86/Cellar/[email protected]/3.13.1/bin/python3.13 -Im ensurepip
==> /opt/homebrew-x86/Cellar/[email protected]/3.13.1/bin/python3.13 -Im pip install -v --no-index --upgrade --isolated --target=/opt/homebrew-x86/lib/python3.
🍺  /opt/homebrew-x86/Cellar/[email protected]/3.13.1: 8,285 files, 191MB, built in 7 minutes 31 seconds
==> Running `brew cleanup [email protected]`...
Disable this behaviour by setting HOMEBREW_NO_INSTALL_CLEANUP.
Hide these hints with HOMEBREW_NO_ENV_HINTS (see `man brew`).
Removing: /Users/asaka/Library/Caches/Homebrew/[email protected]... (41.8KB)
Removing: /Users/asaka/Library/Caches/Homebrew/python@3.13--patch--e1c2699cf3e39731a19207ed69400a67336cda7767aa08f6f46029f26b1d733b.diff... (1.7KB)
Removing: /Users/asaka/Library/Caches/Homebrew/[email protected]... (1.8MB)
Removing: /Users/asaka/Library/Caches/Homebrew/[email protected]... (1.3MB)
Removing: /Users/asaka/Library/Caches/Homebrew/[email protected]... (105KB)

~
❯ python3
Python 3.13.1 (main, Dec  3 2024, 17:59:52) [Clang 15.0.0 (clang-1500.3.9.4)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>>

The homebrew's version is:

❯ brew --version
Homebrew 4.4.16-73-g4d3fedf
Homebrew/homebrew-core (git revision c3256b57c82; last commit 2024-12-31)
Homebrew/homebrew-cask (git revision 990fb283563; last commit 2024-12-31)

@szh
Copy link

szh commented Jan 24, 2025

I'm experiencing the same, also on an M3 chip

@hangxie
Copy link

hangxie commented Jan 26, 2025

Remove --with-system-expat from configure works for me, I'm not using XML/expat so someone can help to check if they still work after this.

I feel like python 3.13 needs newer version of expat (2.6.4?) and that's why Sequoia works, however this does not explain why it works under Intel chips.

EDIT found #125067 (comment)

@hangxie
Copy link

hangxie commented Feb 8, 2025

3.13.2 solved this problem https://github.com/orgs/Homebrew/discussions/5805#discussioncomment-12100850

@picnixz
Copy link
Member

picnixz commented Feb 8, 2025

I guess this can be closed then?

@hangxie
Copy link

hangxie commented Feb 8, 2025

I guess this can be closed then?

Sounds good to me.

For people who want 3.13.1 specifically (sounds weird but anyway), they can backport the patch to their local formula.

@picnixz picnixz closed this as completed Feb 8, 2025
@trey-pindrop
Copy link

I just ran brew upgrade again today, and I can confirm [email protected] solves the issue. My brew upgrade is still going, but it did get past the [email protected] upgrade without issues.

Again, I'm now on macOS 14.7.3 on an M3 Pro CPU.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.13 bugs and security fixes build The build process and cross-build OS-mac tests Tests in the Lib/test dir topic-XML type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

No branches or pull requests

6 participants