Fix usage of BaseAPITestCase (#1854)

* BaseAPITestCase is a mixin class, so it needs to be combined
with another real TestCase class in order to the tests to run

* Make API v2 tests to pass

* Make API v1 tests to pass

* Add docstring

Author: berinhard

downloads/tests/test_views.py

@@ -5,6 +5,7 @@
 from django.urls import reverse
 from django.test import TestCase, override_settings
 
+from rest_framework.authtoken.models import Token
 from rest_framework.test import APITestCase
 
 from .base import BaseDownloadTests, DownloadMixin
@@ -90,7 +91,7 @@ def test_without_latest_python3_release(self):
         self.assertEqual(len(response.context['python_files']), 3)
 
 
-class BaseDownloadApiViewsTest(BaseAPITestCase):
+class BaseDownloadApiViewsTest(BaseDownloadTests, BaseAPITestCase):
     # This API used by add-to-pydotorg.py in python/release-tools.
     app_label = 'downloads'
 
@@ -101,12 +102,8 @@ def setUp(self):
             password='passworduser',
             is_staff=True,
         )
-        self.staff_key = self.staff_user.api_key.key
-        self.token_header = 'ApiKey'
-        self.Authorization = '{} {}:{}'.format(
-            self.token_header, self.staff_user.username, self.staff_key,
-        )
-        self.Authorization_invalid = '%s invalid:token' % self.token_header
+        self.Authorization = f'Token {self.staff_user.api_v2_token}'
+        self.Authorization_invalid = 'Token invalid-token'
 
     def get_json(self, response):
         json_response = response.json()
@@ -438,6 +435,15 @@ def test_filter_release_file(self):
 class DownloadApiV1ViewsTest(BaseDownloadApiViewsTest, BaseDownloadTests):
     api_version = 'v1'
 
+    def setUp(self):
+        super().setUp()
+        self.staff_key = self.staff_user.api_key.key
+        self.token_header = 'ApiKey'
+        self.Authorization = '{} {}:{}'.format(
+            self.token_header, self.staff_user.username, self.staff_key,
+        )
+        self.Authorization_invalid = '%s invalid:token' % self.token_header
+
 
 class DownloadApiV2ViewsTest(BaseDownloadApiViewsTest, BaseDownloadTests, APITestCase):
     api_version = 'v2'

pydotorg/drf.py

@@ -65,6 +65,10 @@ def qs(self):
 
 
 class BaseAPITestCase:
+    """
+    This is mixin base class to be combined with a real Django's TestCase or
+    DRF's APITestCase implementation in order to run the tests.
+    """
 
     api_version = 'v2'
     app_label = None

users/models.py

@@ -8,6 +8,7 @@
 
 from markupfield.fields import MarkupField
 from tastypie.models import create_api_key
+from rest_framework.authtoken.models import Token
 
 from .managers import UserManager
 
@@ -55,6 +56,13 @@ def sponsorships(self):
         from sponsors.models import Sponsorship
         return Sponsorship.objects.visible_to(self)
 
+    @property
+    def api_v2_token(self):
+        try:
+            return Token.objects.get(user=self).key
+        except Token.DoesNotExist:
+            return ""
+
 
 models.signals.post_save.connect(create_api_key, sender=User)