Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with annotation six.byte2int starting 1.16.21.2 #9145

Closed
levincarmel opened this issue Nov 10, 2022 · 3 comments · Fixed by #9152
Closed

Issue with annotation six.byte2int starting 1.16.21.2 #9145

levincarmel opened this issue Nov 10, 2022 · 3 comments · Fixed by #9152

Comments

@levincarmel
Copy link

levincarmel commented Nov 10, 2022

Hi,
Starting 1.16.21.2 we have an issue with mypy failing for annotations of six.byte2int.
We had this method:

def byte2int(c: Union[bytes, int]) -> int:
    if isinstance(c, bytes):
        return six.byte2int(c)
    return c

which was called the following way:
pp_fingerprint = ":".join("{:02x}".format(byte2int(c)) for c in fingerprint).upper()

This used to work until now, but now we get this failure:
Argument 1 to "byte2int" has incompatible type "bytes"; expected "SupportsGetItem[int, <nothing>]"
Is this an issue with this release? Or are we supposed to fix our annotations in some way?

Thanks in advance!

@AlexWaygood
Copy link
Member

Cc. @Avasam

@Avasam
Copy link
Collaborator

Avasam commented Nov 10, 2022

The example can be simplified to:

import six
six.byte2int(b"1")

Weird mypy-specific issue that I ironically didn't catch because I was specifically trying to not use bytes.
An overload easily fixes this, PR incoming.

Ref python/mypy#14032 because I don't know if it's the same issue we were having with itemgetter.

Update: Seems to be caused by outdated typeshed stub. This can be discussed in the PR below.

@JelleZijlstra
Copy link
Member

@levincarmel what version of mypy are you running?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants