-
Notifications
You must be signed in to change notification settings - Fork 341
CONTRIBUTING.rst has broken links when viewed on GitHub #1910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
It can be more than abbreviated, it can be a single link to the website with zero additional information. |
I'm ok with that option, but might make it more or less a toctree dump for the relevant pages. @pvcraven any objections? I don't see the value of keeping this page seperate then reaching back through the hierarchy to include it. |
Can't we just change README and CONTRIBUTING into markdown files? They don't really need the complexity rst has to offer in the first place. |
Actually the CONTRIBUTING file is included directly in the doc build, though it would be trivial to add in MyST Parser extension to sphinx to allow us to just include the Markdown(and maybe use more markdown in the future?) |
Why don't we just link to the file instead and make it markdown? That has such a lower complecity. It makes sese that the contribution guidelines are part of the code anyway and not the docs. This is pretty standard in other projects. |
This seems done. We switched to markdown for the current file. |
Bug Report
tl;dr
:ref:
s and other directives don't seem to render in a GitHub view of an.rst
file, even for targets within the same fileSystem Info
Actual behavior:
The

Testing
link in After making changes does not link anywhere and does not render correctly:Expected behavior:
The
Testing
link in After making changes:Steps to reproduce/example code:
Correcting the capitalization does not change this either. It appears GitHub cannot render
:ref:
targets.Root causes
There seems to be limited post-processing of directives in GitHub views
Implications
This may block #1302 and affect #1886, both of which I was looking at when I noticed this.
Possible ways to fix it
I'm not in favor of clever scripts because those will probably break at some point.
The text was updated successfully, but these errors were encountered: