Skip to content

Conversation

@Gasoonjia
Copy link
Contributor

@Gasoonjia Gasoonjia commented Jan 5, 2026

Stack from ghstack (oldest at bottom):

Add two item() methods to SlimTensor for extracting scalar values from single-element tensors:

  1. item<T>() - Templated version requiring explicit type specification
  2. item() - Non-templated version that auto-detects dtype and returns double

Both methods:

  • Support all 7 slim dtypes (Float, BFloat16, Long, Int, Short, Char, Bool)
  • Handle CUDA tensors by automatically copying data to CPU
  • Validate that tensor has exactly 1 element

Differential Revision: D90034340

…value extraction

Add two `item()` methods to SlimTensor for extracting scalar values from single-element tensors:

1. **`item<T>()`** - Templated version requiring explicit type specification
2. **`item()`** - Non-templated version that auto-detects dtype and returns double

Both methods:
- Support all 7 slim dtypes (Float, BFloat16, Long, Int, Short, Char, Bool)
- Handle CUDA tensors by automatically copying data to CPU
- Validate that tensor has exactly 1 element

Differential Revision: [D90034340](https://our.internmc.facebook.com/intern/diff/D90034340/)

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Jan 5, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16445

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 2 Unrelated Failures

As of commit e870f0d with merge base 2c59f85 (image):

NEW FAILURE - The following job has failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions
Copy link

github-actions bot commented Jan 5, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 5, 2026
This was referenced Jan 5, 2026
…for scalar value extraction"

Add two `item()` methods to SlimTensor for extracting scalar values from single-element tensors:

1. **`item<T>()`** - Templated version requiring explicit type specification
2. **`item()`** - Non-templated version that auto-detects dtype and returns double

Both methods:
- Support all 7 slim dtypes (Float, BFloat16, Long, Int, Short, Char, Bool)
- Handle CUDA tensors by automatically copying data to CPU
- Validate that tensor has exactly 1 element

Differential Revision: [D90034340](https://our.internmc.facebook.com/intern/diff/D90034340/)

[ghstack-poisoned]
…for scalar value extraction"

Add two `item()` methods to SlimTensor for extracting scalar values from single-element tensors:

1. **`item<T>()`** - Templated version requiring explicit type specification
2. **`item()`** - Non-templated version that auto-detects dtype and returns double

Both methods:
- Support all 7 slim dtypes (Float, BFloat16, Long, Int, Short, Char, Bool)
- Handle CUDA tensors by automatically copying data to CPU
- Validate that tensor has exactly 1 element

Differential Revision: [D90034340](https://our.internmc.facebook.com/intern/diff/D90034340/)

[ghstack-poisoned]
…for scalar value extraction"

Add two `item()` methods to SlimTensor for extracting scalar values from single-element tensors:

1. **`item<T>()`** - Templated version requiring explicit type specification
2. **`item()`** - Non-templated version that auto-detects dtype and returns double

Both methods:
- Support all 7 slim dtypes (Float, BFloat16, Long, Int, Short, Char, Bool)
- Handle CUDA tensors by automatically copying data to CPU
- Validate that tensor has exactly 1 element

Differential Revision: [D90034340](https://our.internmc.facebook.com/intern/diff/D90034340/)

[ghstack-poisoned]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants