From 26667f39496096480008c5f530fdc0f5656e6a56 Mon Sep 17 00:00:00 2001 From: Aaryaman Vasishta Date: Fri, 8 Aug 2025 04:27:12 +0900 Subject: [PATCH] [ROCm] Support GLOO on Windows --- cmake/Dependencies.cmake | 10 ++++++---- cmake/Hipify.cmake | 4 +++- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/cmake/Dependencies.cmake b/cmake/Dependencies.cmake index 14cbcb1b0..63873fc64 100644 --- a/cmake/Dependencies.cmake +++ b/cmake/Dependencies.cmake @@ -140,15 +140,17 @@ if(USE_ROCM) include(cmake/Hip.cmake) if(HAVE_HIP) include(cmake/Hipify.cmake) - list(APPEND HIP_CXX_FLAGS -fPIC) list(APPEND HIP_CXX_FLAGS -D__HIP_PLATFORM_HCC__=1) list(APPEND HIP_CXX_FLAGS -DCUDA_HAS_FP16=1) list(APPEND HIP_CXX_FLAGS -D__HIP_NO_HALF_OPERATORS__=1) list(APPEND HIP_CXX_FLAGS -D__HIP_NO_HALF_CONVERSIONS__=1) list(APPEND HIP_CXX_FLAGS -DHIP_VERSION=${HIP_VERSION_MAJOR}) - list(APPEND HIP_CXX_FLAGS -Wno-shift-count-negative) - list(APPEND HIP_CXX_FLAGS -Wno-shift-count-overflow) - list(APPEND HIP_CXX_FLAGS -Wno-duplicate-decl-specifier) + if(NOT WIN32) + list(APPEND HIP_CXX_FLAGS -fPIC) + list(APPEND HIP_CXX_FLAGS -Wno-shift-count-negative) + list(APPEND HIP_CXX_FLAGS -Wno-shift-count-overflow) + list(APPEND HIP_CXX_FLAGS -Wno-duplicate-decl-specifier) + endif() list(APPEND HIP_CXX_FLAGS -DUSE_MIOPEN) set(HIP_CLANG_FLAGS ${HIP_CXX_FLAGS}) diff --git a/cmake/Hipify.cmake b/cmake/Hipify.cmake index c316cf56d..f48ea4009 100644 --- a/cmake/Hipify.cmake +++ b/cmake/Hipify.cmake @@ -9,8 +9,10 @@ endfunction(prepend) set(HIPIFY_SCRIPTS_DIR ${PROJECT_SOURCE_DIR}/tools/amd_build) file(GLOB HIPIFY_SCRIPTS ${HIPIFY_SCRIPTS_DIR}/*.py) set(HIPIFY_OUTPUT_ROOT_DIR ${PROJECT_BINARY_DIR}/hip) + +find_package (Python3 COMPONENTS Interpreter) set(HIPIFY_COMMAND - ${HIPIFY_SCRIPTS_DIR}/build_amd.py + ${Python3_EXECUTABLE} ${HIPIFY_SCRIPTS_DIR}/build_amd.py --project-directory ${PROJECT_SOURCE_DIR} --output-directory ${HIPIFY_OUTPUT_ROOT_DIR} )