-
Notifications
You must be signed in to change notification settings - Fork 250
Open
Labels
ExecuTorchIssues related to ExecuTorch installation, export, or build. Mobile uses separate tagsIssues related to ExecuTorch installation, export, or build. Mobile uses separate tagsenhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomerstriagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate moduleThis issue has been looked at a team member, and triaged and prioritized into an appropriate module
Description
🚀 The feature, motivation and pitch
First surfaced in #1057, the replace_attention_with_custom_sdpa_attention
function, used when exporting models in torchchat, can be replaced with the equivalent API provided in the Excecutorch https://github.com/pytorch/executorch/blob/main/examples/models/llama2/source_transformation/sdpa.py
Task: Swap the torchchat implementation with that of ExecuTorch's. Delete the then defunct code from torchchat
Alternatives
No response
Additional context
No response
RFC (Optional)
No response
Metadata
Metadata
Assignees
Labels
ExecuTorchIssues related to ExecuTorch installation, export, or build. Mobile uses separate tagsIssues related to ExecuTorch installation, export, or build. Mobile uses separate tagsenhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomerstriagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate moduleThis issue has been looked at a team member, and triaged and prioritized into an appropriate module
Type
Projects
Status
No status