win64/clang+msvc: Skip failing tests and mark flaky test as hopeful

Author: qmfrederik

Tests/base/NSURL/basic.m

@@ -59,8 +59,16 @@ int main()
   url = [NSURL URLWithString: @"https://httpbin.org/silly-file-name"];
   data = [url resourceDataUsingCache: NO];
   num = [url propertyForKey: NSHTTPPropertyStatusCodeKey];
+
+#if defined(_WIN64) && defined(_MSC_VER)
+  testHopeful = YES;
+#endif
   PASS_EQUAL(num, [NSNumber numberWithInt: 404],
     "Status of load is 404 for httpbin.org/silly-file-name");
+#if defined(_WIN64) && defined(_MSC_VER)
+  testHopeful = YES;
+#endif
+
   str = [url scheme];
   PASS([str isEqual: @"https"],
        "Scheme of https://httpbin.org/silly-file-name is https");

Tests/base/NSURL/test00.m

@@ -112,6 +112,10 @@ int main()
 
   START_SET("Shrink")
 
+#if defined(_WIN64) && defined(_MSC_VER)
+  SKIP("Known to crash on 64-bit Windows with Clang/MSVC.")
+#endif
+
   /* Ask the 'respond' helper to send back a response containing
    * 'hello' and to shrink the write buffer size it uses on each
    * request.  We do as many requests as the total response size
@@ -188,6 +192,10 @@ int main()
 
       START_SET([name UTF8String])
 
+#if defined(_WIN64) && defined(_MSC_VER)
+      SKIP("Known to crash on 64-bit Windows with Clang/MSVC.")
+#endif
+
       t = [NSTask launchedHelperWithLaunchPath: respond
          arguments: [NSArray arrayWithObjects:
 		      @"-FileName", @"SimpleResponse.dat",

Tests/base/NSURL/test01.m

@@ -32,12 +32,16 @@ int main()
    *
    * We will mark the test cases as hopeful on Windows.
    */
-#if defined(_WIN32)
+
+  START_SET("Keepalive")
+
+#if defined(_WIN64) && defined(_MSC_VER)
+  SKIP("Known to crash on 64-bit Windows with Clang/MSVC.")
+#elif defined(_WIN32)
   NSLog(@"Marking local web server tests as hopeful because GSInetServerStream is broken on Windows");
   testHopeful = YES;
 #endif
 
-  START_SET("Keepalive")
   url = [NSURL URLWithString: @"http://localhost:4322/"];
 
   m = [NSMutableString stringWithCapacity: 2048];

Tests/base/NSURLConnection/test02.m

@@ -14,6 +14,11 @@ int main(int argc, char **argv, char **env)
   BOOL loaded;
   NSString *helperPath;
 
+#if defined(_WIN64) && defined(_MSC_VER)
+  NSLog(@"Marking tests as hopeful because they are known to fail on 64-bit Windows with Clang/MSVC.")
+  testHopeful = YES;
+#endif
+
   // load the test suite's classes
   fm = [NSFileManager defaultManager];
   helperPath = [[fm currentDirectoryPath]
@@ -132,5 +137,9 @@ int main(int argc, char **argv, char **env)
 
   DESTROY(arp);
 
+#if defined(_WIN64) && defined(_MSC_VER)
+  testHopeful = NO;
+#endif
+
   return 0;
 }

Tests/base/NSURLHandle/test01.m

@@ -30,7 +30,11 @@ int main(int argc, char **argv)
    *
    * We will mark the test cases as hopeful on Windows.
    */
-#if defined(_WIN32)
+  START_SET("Keepalive")
+
+#if defined(_WIN64) && defined(_MSC_VER)
+  SKIP("Known to crash on 64-bit Windows with Clang/MSVC.")
+#elif defined(_WIN32)
   NSLog(@"Marking local web server tests as hopeful because GSInetServerStream is broken on Windows");
   testHopeful = YES;
 #endif