From fc430d14badcbfb85ee67e2bff1c8763023c703d Mon Sep 17 00:00:00 2001 From: Manuel Date: Sat, 4 Nov 2017 23:30:46 +0100 Subject: [PATCH 1/5] Updated README --- README.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index bc7c72a..07b74cf 100644 --- a/README.md +++ b/README.md @@ -1,5 +1,6 @@ # Native UI Inline-editor Angular (version 4+) component ([demo](demos)) +## Updated WIP documentation here . Follow me [![twitter](https://img.shields.io/twitter/follow/carlillo.svg?style=social&label=%20carlillo)](https://twitter.com/carlillo) to be notified about new releases. @@ -137,7 +138,7 @@ export class MyComponent { min="1" max="8" pattern="^[a-zA-Z]{1,3}" - (onError)="myHandleError"> + (onError)="myHandleError()"> ``` * **`type`** [`string`] Specifies the type `` element to display. From 04d41125df6995a4600b697e589648282b636908 Mon Sep 17 00:00:00 2001 From: Manuel Date: Sun, 5 Nov 2017 00:19:13 +0100 Subject: [PATCH 2/5] Just fixing issue --- README.md | 2 -- 1 file changed, 2 deletions(-) diff --git a/README.md b/README.md index 07b74cf..a69d16a 100644 --- a/README.md +++ b/README.md @@ -1,7 +1,5 @@ # Native UI Inline-editor Angular (version 4+) component ([demo](demos)) -## Updated WIP documentation here . - Follow me [![twitter](https://img.shields.io/twitter/follow/carlillo.svg?style=social&label=%20carlillo)](https://twitter.com/carlillo) to be notified about new releases. ngx-inline-editor is a library of Angular (version 4+) that allows you to create editable elements. From e8b421f5eec0322c631a6b49636d1e577a167f13 Mon Sep 17 00:00:00 2001 From: Manuel Date: Sun, 5 Nov 2017 22:08:39 +0100 Subject: [PATCH 3/5] Now you can save pressing shift+enter --- src/inputs/input-textarea.component.ts | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/src/inputs/input-textarea.component.ts b/src/inputs/input-textarea.component.ts index 7ace84c..97ce860 100644 --- a/src/inputs/input-textarea.component.ts +++ b/src/inputs/input-textarea.component.ts @@ -21,4 +21,18 @@ export class InputTextareaComponent extends InputBase implements OnInit { } public config: InlineTextareaConfig; + + public onKeyPress(event) { + if (this.config.saveOnEnter) { + if (event.charCode === 13 && !event.shiftKey) { + this.save(); + this.onEscape(event); + } + } else { + if (event.charCode === 13 && event.shiftKey) { + this.save(); + this.onEscape(event); + } + } + } } From ccbffd294f156b32dbb7f4ff0e3ad21a790da47b Mon Sep 17 00:00:00 2001 From: Manuel Date: Sun, 5 Nov 2017 23:24:36 +0100 Subject: [PATCH 4/5] Tried to fix logic in if statement, added type to event and calling parent from method --- src/inputs/input-textarea.component.ts | 17 ++++++----------- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/src/inputs/input-textarea.component.ts b/src/inputs/input-textarea.component.ts index 97ce860..de4de62 100644 --- a/src/inputs/input-textarea.component.ts +++ b/src/inputs/input-textarea.component.ts @@ -22,17 +22,12 @@ export class InputTextareaComponent extends InputBase implements OnInit { public config: InlineTextareaConfig; - public onKeyPress(event) { - if (this.config.saveOnEnter) { - if (event.charCode === 13 && !event.shiftKey) { - this.save(); - this.onEscape(event); - } - } else { - if (event.charCode === 13 && event.shiftKey) { - this.save(); - this.onEscape(event); - } + public onKeyPress(event: KeyboardEvent) { + super.onKeyPress(event); + if ((this.config.saveOnEnter && event.charCode === 13 && !event.shiftKey) || + (!this.config.saveOnEnter && event.charCode === 13 && event.shiftKey)) { + this.save(); + this.onEscape(event); } } } From 113fc6b1fcb85ef4cd57058424cb2fa700ef684c Mon Sep 17 00:00:00 2001 From: Manuel Date: Sun, 5 Nov 2017 23:44:51 +0100 Subject: [PATCH 5/5] Name given to condition, solved double checking with common factor --- src/inputs/input-textarea.component.ts | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/inputs/input-textarea.component.ts b/src/inputs/input-textarea.component.ts index de4de62..297de1f 100644 --- a/src/inputs/input-textarea.component.ts +++ b/src/inputs/input-textarea.component.ts @@ -24,10 +24,13 @@ export class InputTextareaComponent extends InputBase implements OnInit { public onKeyPress(event: KeyboardEvent) { super.onKeyPress(event); - if ((this.config.saveOnEnter && event.charCode === 13 && !event.shiftKey) || - (!this.config.saveOnEnter && event.charCode === 13 && event.shiftKey)) { + if (event.charCode === 13 && this.isSaving(event)) { this.save(); this.onEscape(event); } } + + private isSaving(event: KeyboardEvent): boolean { + return (this.config.saveOnEnter && !event.shiftKey) || (!this.config.saveOnEnter && event.shiftKey); + } }