<include> fails to load appenders in version 2.0.8

[cannonrush]

Configuration using <include> to modularize appender definitions fails in version 2.0.8, but works in version 2.0.7.

I modified the test configuration found in logback-access-tomcat_11_0_blackbox to reproduce the issue:

Main configuration (logback-stdout.xml):

<configuration>
    <statusListener class="ch.qos.logback.core.status.OnConsoleStatusListener" />

    <include resource="ch/qos/logback/access/list-appender.xml"/>
    <include resource="ch/qos/logback/access/stdout-appender.xml"/>

    <appender-ref ref="LIST" />
    <appender-ref ref="STDOUT" />
</configuration>

Included file (list-appender.xml):

<?xml version="1.0" encoding="UTF-8"?>
<included>
    <appender name="LIST" class="ch.qos.logback.access.tomcat_11_0.ListAppender"/>
</included>

Included file (stdout-appender.xml):

<?xml version="1.0" encoding="UTF-8"?>
<included>
    <appender name="STDOUT" class="ch.qos.logback.core.ConsoleAppender">
        <encoder>
            <pattern>%h %l %u %user %date "%r" %s %b</pattern>
        </encoder>
    </appender>
</included>

Behavior:

• v2.0.7: Configuration loads successfully
• v2.0.8: Configuration fails, breaking EmbeddedTomcatTest

[cannonrush]

It looks like this recent change to AppenderRefDependencyAnalyser in Logback Core broke appender-ref dependency resolution in Logback Access. Before, the Dependency Definitions the analyzer produced had the Appender Ref Model as the depender -- now it's the root Configuration Model.

Seems this shift causes the DefaultProcessor to give up during secondPhaseTraverse before even attempting to handle sub-modules.

[footaku]

I have same issue in 2.0.9.

logback-access.xml

<?xml version="1.0" encoding="UTF-8"?>
<configuration debug="false" scan="false">
    <property name="APPENDER_NAME" value="STDOUT"/>
    <!-- It is same to use appender-ref
        <appender-ref ref="STDOUT"/>
    -->

    <include resource="default-access.xml" />
</configuration>

default-access.xml

<?xml version="1.0" encoding="UTF-8"?>
<included>
  <appender name="STDOUT" class="ch.qos.logback.core.ConsoleAppender">
    <encoder>
      <charset>UTF-8</charset>
      <pattern>%t{yyyy/MM/dd HH:mm:ss.SSS} INFO ACCESS - %r %s</pattern>
    </encoder>
  </appender>

  <appender-ref ref="${APPENDER_NAME}"/>
</included>

ERROR in ch.qos.logback.core.model.processor.AppenderRefModelHandler
 - Failed to find appender named [STDOUT]

[ceki]

Have you tried with logback-core version 1.5.26 and logback-access version 2.0.9?

[cannonrush]

Have you tried with logback-core version 1.5.26 and logback-access version 2.0.9?

Just gave it a go -- issue is still there. I can reproduce it on latest main as well, by having every appender definition in a configuration declared in an included resource.

[Der-Nippel]

Hello!
Using logback-classic:1.5.28 and logback-access-common:2.0.9 fixes the issue.