Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i.ytimg.com is not changed to max resolution #29

Open
speedymaan opened this issue Jan 6, 2019 · 5 comments
Open

i.ytimg.com is not changed to max resolution #29

speedymaan opened this issue Jan 6, 2019 · 5 comments
Labels
bug Something isn't working topic:rules

Comments

@speedymaan
Copy link

For example:
https://i.ytimg.com/vi/sxItyrp55g8/0.jpg -> https://i.ytimg.com/vi/sxItyrp55g8/maxresdefault.jpg

@qsniyg
Copy link
Owner

qsniyg commented Jan 6, 2019

It is in the codebase, but there are cases where the max resolution image is, for some reason, different than the smaller image, so I disabled it for now.

What I think I'll do is that I'll create an option for enabling "experimental" or "broken" rules, which would include rules that could potentially change the image, like this one.

@qsniyg qsniyg added the bug Something isn't working label Apr 13, 2019
@qsniyg
Copy link
Owner

qsniyg commented May 12, 2019

The issue is now fixed in c80520f :) Make sure to enable "Possibly different images" in the settings.

@DevWannabe-dot
Copy link
Collaborator

I potentially don't know what causes this, but for the first time in my life I've came across img.youtube.com and image max url does nothing but loading non-stop. Maybe that's not even the same issue, but it was what I found in a comment, so, the working rule should be:

smaller: https://img.youtube.com/vi/2NbC8kGGNus/0.jpg
original: https://i.ytimg.com/vi/2NbC8kGGNus/maxresdefault.jpg
or https://i.ytimg.com/vi/2NbC8kGGNus/sddefault.jpg
or https://i.ytimg.com/vi/2NbC8kGGNus/hqdefault.jpg

hope this helps :) tried refreshing already

@qsniyg
Copy link
Owner

qsniyg commented Sep 23, 2021

Thank you for reminding me! Yes I need to fix the Youtube rule, it crashes at the moment.

I believe the blocker was that it was a bug in the bigimage_recursive family of functions (the functions that process the rule output) rather than the rule itself.

@qsniyg qsniyg reopened this Sep 23, 2021
@pointydev
Copy link

I'd love to see this issue resolved, especially since there are now large query strings associated with video thumbnails, meaning manually changing to maxresdefault requires more hand-eye coordination.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working topic:rules
Projects
None yet
Development

No branches or pull requests

4 participants