-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i.ytimg.com is not changed to max resolution #29
Comments
It is in the codebase, but there are cases where the max resolution image is, for some reason, different than the smaller image, so I disabled it for now. What I think I'll do is that I'll create an option for enabling "experimental" or "broken" rules, which would include rules that could potentially change the image, like this one. |
The issue is now fixed in c80520f :) Make sure to enable "Possibly different images" in the settings. |
I potentially don't know what causes this, but for the first time in my life I've came across img.youtube.com and image max url does nothing but loading non-stop. Maybe that's not even the same issue, but it was what I found in a comment, so, the working rule should be: smaller: https://img.youtube.com/vi/2NbC8kGGNus/0.jpg hope this helps :) tried refreshing already |
Thank you for reminding me! Yes I need to fix the Youtube rule, it crashes at the moment. I believe the blocker was that it was a bug in the bigimage_recursive family of functions (the functions that process the rule output) rather than the rule itself. |
I'd love to see this issue resolved, especially since there are now large query strings associated with video thumbnails, meaning manually changing to maxresdefault requires more hand-eye coordination. |
For example:
https://i.ytimg.com/vi/sxItyrp55g8/0.jpg -> https://i.ytimg.com/vi/sxItyrp55g8/maxresdefault.jpg
The text was updated successfully, but these errors were encountered: