Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAC with PER #82

Open
xwen24 opened this issue Jul 30, 2024 · 0 comments
Open

SAC with PER #82

xwen24 opened this issue Jul 30, 2024 · 0 comments

Comments

@xwen24
Copy link

xwen24 commented Jul 30, 2024

Hello!

Thanks so much for sharing the codes!

I just have a question about sac_discrete_per.py: why the importance-sampling weights are not used to update the Q-function and the policy function?

weight_update = [min(l1.item(), l2.item()) for l1, l2 in zip(q_value_loss1, q_value_loss2)]

I have seen other SAC-PER repositories that used the weights to calculate the q_value_loss and policy_loss.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant