From a674d49d45975ffa80eac45b9f87658092b269b4 Mon Sep 17 00:00:00 2001
From: quentinDERORY <15911421+quentinDERORY@users.noreply.github.com>
Date: Tue, 2 Nov 2021 16:00:04 +0100
Subject: [PATCH 1/2] feat(ci): group jobs in runners for ci to go quicker

Signed-off-by: quentinDERORY <15911421+quentinDERORY@users.noreply.github.com>
---
 .github/workflows/agw-workflow.yml   |  85 +++++---------
 .github/workflows/cloud-workflow.yml | 159 ++++++++++-----------------
 .github/workflows/cwag-workflow.yml  |  37 +------
 .github/workflows/feg-workflow.yml   |  70 +++++-------
 4 files changed, 115 insertions(+), 236 deletions(-)

diff --git a/.github/workflows/agw-workflow.yml b/.github/workflows/agw-workflow.yml
index c85c923f9bec..2b20af0e4931 100644
--- a/.github/workflows/agw-workflow.yml
+++ b/.github/workflows/agw-workflow.yml
@@ -334,10 +334,10 @@ jobs:
           SLACK_COLOR: "#FF0000"
           SLACK_FOOTER: ' '
 
-  mme-clang-tidy:
+  mme-clang-warnings:
     needs: path_filter
     if: ${{ needs.path_filter.outputs.should_not_skip == 'true' }}
-    name: mme clang tidy job
+    name: mme clang warnings job
     runs-on: ubuntu-latest
     env:
       MAGMA_ROOT: "${{ github.workspace }}"
@@ -348,10 +348,30 @@ jobs:
       - uses: satackey/action-docker-layer-caching@v0.0.11
         continue-on-error: true
       - name: Run mme-clang-tidy
+        continue-on-error: true
+        if: always()
+        id: mme-clang-tidy
         # yamllint disable rule:line-length
         run: |
             docker build --tag magma-mme-build --file ${{ env.MAGMA_ROOT }}/lte/gateway/docker/mme/Dockerfile.ubuntu20.04 .
             docker run --env BRANCH=${{ env.BRANCH}} --env REVISION=${{ env.REVISION }} --volume ${{ env.MAGMA_ROOT }}:/magma --interactive magma-mme-build:latest /bin/bash -c 'cd /magma/lte/gateway;make clang_tidy_oai_upload'
+      - name: Run mme-clang-warnings
+        continue-on-error: true
+        if: always()
+        id: mme-clang-warning
+        # yamllint disable rule:line-length
+        run: |
+            docker build --tag magma-mme-build --file ${{ env.MAGMA_ROOT }}/lte/gateway/docker/mme/Dockerfile.ubuntu20.04 .
+            docker run --env BRANCH=${{ env.BRANCH }} --env REVISION=${{ env.REVISION }} --volume ${{ env.MAGMA_ROOT }}:/magma --volume ${{ env.MAGMA_ROOT }}/lte/gateway/configs:/etc/magma --interactive magma-mme-build:latest /bin/bash -c "cd /magma/lte/gateway;make clang_warning_oai_upload"
+      - name: Run codecov
+        continue-on-error: true
+        if: always()
+        id: c-cpp-codecov
+        # yamllint disable rule:line-length
+        run: |
+            docker build --tag magma/c_cpp_build --file ${{ env.MAGMA_ROOT }}/lte/gateway/docker/mme/Dockerfile.ubuntu20.04 .
+            ci_env=$(bash <(curl -s https://codecov.io/env))
+            docker run $ci_env --env CI=true --volume ${{ env.MAGMA_ROOT }}:/magma --volume ${{ env.MAGMA_ROOT }}/lte/gateway/configs:/etc/magma --interactive magma/c_cpp_build:latest /bin/bash -c "cd /magma/lte/gateway;make coverage;ls -al /tmp/;bash <(curl -s https://codecov.io/bash) -f /build/c/coverage.info -F c_cpp"
       - name: Extract commit title
         # yamllint enable
         if: failure() && github.event_name == 'push'
@@ -360,44 +380,18 @@ jobs:
             str="$(jq '.head_commit.message' $GITHUB_EVENT_PATH)"    # get the head_commit message
             echo ::set-output name=title::${str%%\\n*} | tr -d '"'
       - name: Notify failure to slack
-        if: failure() && github.event_name == 'push'
+        if: steps.c-cpp-codecov.outcome=='failure' && github.event_name == 'push'
         uses: rtCamp/action-slack-notify@v2.2.0
         env:
           SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK_CI }}
-          SLACK_TITLE: "Github action mme-clang-tidy failed"
+          SLACK_TITLE: "Github action c-cpp-codecov failed"
           SLACK_USERNAME: "AGW workflow"
           SLACK_MESSAGE: "${{ steps.commit.outputs.title}}"
           SLACK_ICON_EMOJI: ":boom:"
           SLACK_COLOR: "#FF0000"
           SLACK_FOOTER: ' '
-
-  mme-clang-warnings:
-    needs: path_filter
-    if: ${{ needs.path_filter.outputs.should_not_skip == 'true' }}
-    name: mme clang warnings job
-    runs-on: ubuntu-latest
-    env:
-      MAGMA_ROOT: "${{ github.workspace }}"
-      BRANCH: "${{ github.base_ref }}"
-      REVISION: "${{ github.sha }}"
-    steps:
-      - uses: actions/checkout@v2
-      - uses: satackey/action-docker-layer-caching@v0.0.11
-        continue-on-error: true
-      - name: Run mme-clang-warnings
-        # yamllint disable rule:line-length
-        run: |
-            docker build --tag magma-mme-build --file ${{ env.MAGMA_ROOT }}/lte/gateway/docker/mme/Dockerfile.ubuntu20.04 .
-            docker run --env BRANCH=${{ env.BRANCH }} --env REVISION=${{ env.REVISION }} --volume ${{ env.MAGMA_ROOT }}:/magma --volume ${{ env.MAGMA_ROOT }}/lte/gateway/configs:/etc/magma --interactive magma-mme-build:latest /bin/bash -c "cd /magma/lte/gateway;make clang_warning_oai_upload"
-      - name: Extract commit title
-        # yamllint enable
-        if: failure() && github.event_name == 'push'
-        id: commit
-        run: |
-            str="$(jq '.head_commit.message' $GITHUB_EVENT_PATH)"    # get the head_commit message
-            echo ::set-output name=title::${str%%\\n*} | tr -d '"'
       - name: Notify failure to slack
-        if: failure() && github.event_name == 'push'
+        if: steps.mme-clang-warning.outcome=='failure' && github.event_name == 'push'
         uses: rtCamp/action-slack-notify@v2.2.0
         env:
           SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK_CI }}
@@ -407,37 +401,12 @@ jobs:
           SLACK_ICON_EMOJI: ":boom:"
           SLACK_COLOR: "#FF0000"
           SLACK_FOOTER: ' '
-
-  c-cpp-codecov:
-    needs: path_filter
-    if: ${{ needs.path_filter.outputs.should_not_skip == 'true' }}
-    name: c-cpp code coverage job
-    runs-on: ubuntu-latest
-    env:
-      MAGMA_ROOT: "${{ github.workspace }}"
-    steps:
-      - uses: actions/checkout@v2
-      - uses: satackey/action-docker-layer-caching@v0.0.11
-        continue-on-error: true
-      - name: Run codecov
-        # yamllint disable rule:line-length
-        run: |
-            docker build --tag magma/c_cpp_build --file ${{ env.MAGMA_ROOT }}/lte/gateway/docker/mme/Dockerfile.ubuntu20.04 .
-            ci_env=$(bash <(curl -s https://codecov.io/env))
-            docker run $ci_env --env CI=true --volume ${{ env.MAGMA_ROOT }}:/magma --volume ${{ env.MAGMA_ROOT }}/lte/gateway/configs:/etc/magma --interactive magma/c_cpp_build:latest /bin/bash -c "cd /magma/lte/gateway;make coverage;ls -al /tmp/;bash <(curl -s https://codecov.io/bash) -f /build/c/coverage.info -F c_cpp"
-      - name: Extract commit title
-        # yamllint enable
-        if: failure() && github.event_name == 'push'
-        id: commit
-        run: |
-            str="$(jq '.head_commit.message' $GITHUB_EVENT_PATH)"    # get the head_commit message
-            echo ::set-output name=title::${str%%\\n*} | tr -d '"'
       - name: Notify failure to slack
-        if: failure() && github.event_name == 'push'
+        if: steps.mme-clang-tidy.outcome=='failure' && github.event_name == 'push'
         uses: rtCamp/action-slack-notify@v2.2.0
         env:
           SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK_CI }}
-          SLACK_TITLE: "Github action c-cpp-codecov failed"
+          SLACK_TITLE: "Github action mme-clang-tidy failed"
           SLACK_USERNAME: "AGW workflow"
           SLACK_MESSAGE: "${{ steps.commit.outputs.title}}"
           SLACK_ICON_EMOJI: ":boom:"
diff --git a/.github/workflows/cloud-workflow.yml b/.github/workflows/cloud-workflow.yml
index 9fad8c80a0dd..51c2620c6d0b 100644
--- a/.github/workflows/cloud-workflow.yml
+++ b/.github/workflows/cloud-workflow.yml
@@ -33,10 +33,10 @@ jobs:
               - [".github/workflows/cloud-workflow.yml", "wifi/cloud/**", "lte/proto/**", "cwf/cloud/**", "fbinternal/cloud/**", "feg/cloud/**", "lte/cloud/**", "orc8r/cloud/**", "orc8r/lib/**"]
   # Fail if checked-in generated code doesn't match output from
   # generation command.
-  insync-checkin:
+  cloud-tests:
     needs: path_filter
     if: ${{ needs.path_filter.outputs.should_not_skip == 'true' }}
-    name: insync checkin job
+    name: cloud-tests
     runs-on: ubuntu-latest
     env:
       MAGMA_ROOT: "${{ github.workspace }}"
@@ -45,7 +45,10 @@ jobs:
       - uses: actions/setup-python@v2
         with:
           python-version: '3.7'
-      - name: Run build.py
+      - name: insync-checkin
+        if: always()
+        id: insync-checkin
+        continue-on-error: true
         run: |
             cd ${MAGMA_ROOT}/orc8r/cloud/docker
             python3 build.py --generate
@@ -54,14 +57,55 @@ jobs:
             echo GIT_STATUS=$(git status) >> $GITHUB_ENV
             git status
             git diff-index --quiet HEAD
+      - name: deploy-sync-checkin
+        if: always()
+        id: deploy-sync-checkin
+        continue-on-error: true
+        run: |
+          cd ${MAGMA_ROOT}/orc8r/cloud/deploy/orc8r_deployer/docker
+          ./run_deployer.bash --deploy-dir /tmp/deploy_dir --build --test check_all
+      - name: Lint cloud Go code
+        if: always()
+        continue-on-error: true
+        id: cloud-lint-lint
+        run: |
+          cd ${MAGMA_ROOT}/orc8r/cloud/docker
+          python3 build.py --lint
+      - name: Generate test coverage
+        continue-on-error: true
+        id: cloud-lint-cov
+        run: |
+          cd ${MAGMA_ROOT}/orc8r/cloud/docker
+          python3 build.py --coverage
+      - uses: codecov/codecov-action@v1
+        continue-on-error: true
+        id: cloud-lint-codecov
+        with:
+          files: '${{ env.MAGMA_ROOT}}/orc8r/cloud/coverage/all.gocov'
+          flags: cloud_lint
+      - name: Run tests cloud Go
+        continue-on-error: true
+        if: always()
+        id: cloud-test
+        run: |
+          cd ${MAGMA_ROOT}/orc8r/cloud/docker
+          python3 build.py --tests --up
+          ls ${MAGMA_ROOT}/orc8r/cloud/test-results
+        timeout-minutes: 15
+      - name: Upload Test Results
+        if: always()
+        uses: actions/upload-artifact@v2
+        with:
+          name: Unit Test Results
+          path: "${{ env.MAGMA_ROOT}}/orc8r/cloud/test-results/*"
       - name: Extract commit title
         if: failure() && github.event_name == 'push'
         id: commit
         run: |
           str="$(jq '.head_commit.message' $GITHUB_EVENT_PATH)"    # get the head_commit message
           echo ::set-output name=title::${str%%\\n*} | tr -d '"'
-      - name: Notify failure to Slack
-        if: failure() && github.event_name == 'push'
+      - name: Notify failure to Slack for insync-checkin
+        if: steps.insync-checkin.outcome=='failure' && github.event_name == 'push'
         uses: rtCamp/action-slack-notify@v2.2.0
         env:
           SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK_CI }}
@@ -71,115 +115,30 @@ jobs:
           SLACK_ICON_EMOJI: ":boom:"
           SLACK_COLOR: "#FF0000"
           SLACK_FOOTER: ' '
-  # Fail if terraform variables, helm charts and orcl is out of sync
-  # Ensure all Helm chart values are in-sync across Orc8r deployment mechanisms
-  deploy-sync-checkin:
-    needs: path_filter
-    if: ${{ needs.path_filter.outputs.should_not_skip == 'true' }}
-    name: deploy sync job
-    runs-on: ubuntu-latest
-    env:
-      MAGMA_ROOT: "${{ github.workspace }}"
-    steps:
-      - uses: actions/checkout@v2
-      - uses: actions/setup-python@v2
-        with:
-          python-version: '3.7'
-      - name: Run build.py
-        run: |
-            cd ${MAGMA_ROOT}/orc8r/cloud/deploy/orc8r_deployer/docker
-            ./run_deployer.bash --deploy-dir /tmp/deploy_dir --build --test check_all
-      - name: Extract commit title
-        id: commit
-        run: |
-          str="$(jq '.head_commit.message' $GITHUB_EVENT_PATH)"    # get the head_commit message
-          echo ::set-output name=title::${str%%\\n*} | tr -d '"'
-      - name: Notify failure to Slack
-        if: failure() && github.event_name == 'push'
+      - name: Notify failure to Slack for deploy-sync-checkin
+        if: steps.deploy-sync-checkin.outcome=='failure' && github.event_name == 'push'
         uses: rtCamp/action-slack-notify@v2.2.0
         env:
           SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK_CI }}
-          SLACK_TITLE: "Github action deploy-sync-checkin failed"
-          SLACK_MESSAGE: "${{ steps.commit.outputs.title}}"
+          SLACK_TITLE: "Github action insync-checkin failed"
           SLACK_USERNAME: "Cloud workflow"
+          SLACK_MESSAGE: "COMMIT TITLE:\n ${{steps.commit.outputs.title}}\n\n\n GIT STATUS OUTPUT:\n ${{env.GIT_STATUS}}"
           SLACK_ICON_EMOJI: ":boom:"
           SLACK_COLOR: "#FF0000"
           SLACK_FOOTER: ' '
-  # Fail if code doesn't pass formatting requirements.
-  # Upload test coverage statistics.
-  cloud-lint:
-    needs: path_filter
-    if: ${{ needs.path_filter.outputs.should_not_skip == 'true' }}
-    name: cloud lint job
-    runs-on: ubuntu-latest
-    env:
-      MAGMA_ROOT: "${{ github.workspace }}"
-    steps:
-      - uses: actions/checkout@v2
-      - uses: actions/setup-python@v2
-        with:
-          python-version: '3.7'
-      - name: Lint cloud Go code
-        run: |
-            cd ${MAGMA_ROOT}/orc8r/cloud/docker
-            python3 build.py --lint
-      - name: Generate test coverage
-        run: |
-            cd ${MAGMA_ROOT}/orc8r/cloud/docker
-            python3 build.py --coverage
-      - uses: codecov/codecov-action@v1
-        with:
-          files: '${{ env.MAGMA_ROOT}}/orc8r/cloud/coverage/all.gocov'
-          flags: cloud_lint
-      - name: Extract commit title
-        id: commit
-        if: failure() && github.event_name == 'push'
-        run: |
-          str="$(jq '.head_commit.message' $GITHUB_EVENT_PATH)"    # get the head_commit message
-          echo ::set-output name=title::${str%%\\n*} | tr -d '"'
-      - name: Notify failure to Slack
-        if: failure() && github.event_name == 'push'
+      - name: Notify failure to Slack for cloud-test
+        if: steps.cloud-test.outcome=='failure' && github.event_name == 'push'
         uses: rtCamp/action-slack-notify@v2.2.0
         env:
           SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK_CI }}
-          SLACK_TITLE: "Github action cloud-lint failed"
+          SLACK_TITLE: "Github action cloud-test failed"
           SLACK_MESSAGE: "${{ steps.commit.outputs.title}}"
           SLACK_USERNAME: "Cloud workflow"
           SLACK_ICON_EMOJI: ":boom:"
           SLACK_COLOR: "#FF0000"
           SLACK_FOOTER: ' '
-  cloud-test:
-    needs: path_filter
-    if: ${{ needs.path_filter.outputs.should_not_skip == 'true' }}
-    name: cloud test job
-    runs-on: ubuntu-latest
-    env:
-      MAGMA_ROOT: "${{ github.workspace }}"
-    steps:
-      - uses: actions/checkout@v2
-      - uses: actions/setup-python@v2
-        with:
-          python-version: '3.7'
-      - name: Run tests cloud Go
-        run: |
-            cd ${MAGMA_ROOT}/orc8r/cloud/docker
-            python3 build.py --tests --up
-            ls ${MAGMA_ROOT}/orc8r/cloud/test-results
-        timeout-minutes: 15
-      - name: Upload Test Results
-        if: always()
-        uses: actions/upload-artifact@v2
-        with:
-          name: Unit Test Results
-          path: "${{ env.MAGMA_ROOT}}/orc8r/cloud/test-results/*"
-      - name: Extract commit title
-        id: commit
-        if: failure() && github.event_name == 'push'
-        run: |
-          str="$(jq '.head_commit.message' $GITHUB_EVENT_PATH)"    # get the head_commit message
-          echo ::set-output name=title::${str%%\\n*} | tr -d '"'
-      - name: Notify failure to Slack
-        if: failure() && github.event_name == 'push'
+      - name: Notify failure to Slack for cloud-lint
+        if: ( steps.cloud-lint.outcome=='failure' || steps.cloud-lint-codecov.outcome=='failure' || steps.cloud-lint-cov.outcome=='failure' ) && github.event_name == 'push'
         uses: rtCamp/action-slack-notify@v2.2.0
         env:
           SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK_CI }}
@@ -188,4 +147,4 @@ jobs:
           SLACK_USERNAME: "Cloud workflow"
           SLACK_ICON_EMOJI: ":boom:"
           SLACK_COLOR: "#FF0000"
-          SLACK_FOOTER: ' '
\ No newline at end of file
+          SLACK_FOOTER: ' '
diff --git a/.github/workflows/cwag-workflow.yml b/.github/workflows/cwag-workflow.yml
index 85060fe9a336..fe779c401afa 100644
--- a/.github/workflows/cwag-workflow.yml
+++ b/.github/workflows/cwag-workflow.yml
@@ -77,40 +77,5 @@ jobs:
           SLACK_ICON_EMOJI: ":boom:"
           SLACK_COLOR: "#FF0000"
           SLACK_FOOTER: ' '
-  cwag-build:
-    needs: path_filter
-    if: ${{ needs.path_filter.outputs.should_not_skip == 'true'}}
-    name: cwag build job
-    runs-on: ubuntu-latest
-    env:
-      MAGMA_ROOT: "${{ github.workspace }}"
-    steps:
-      - uses: actions/checkout@v2
-      - name: Run docker compose
-        id: cwag-build-docker-compose
-        continue-on-error: true
-        # yamllint disable rule:line-length
-        env:
-          DOCKER_REGISTRY: cwf_
-        run: |
-          cd ${MAGMA_ROOT}/cwf/gateway/docker
-          docker-compose build --parallel
-      - name: Retry docker compose on failure
-        id: retry-cwag-build-docker-compose
-        continue-on-error: true
-        if: steps.cwag-docker-compose.outcome=='failure'
-        env:
-          DOCKER_REGISTRY: cwf_
-        run: |
-          cd ${MAGMA_ROOT}/cwf/gateway/docker
-          docker-compose build --parallel
-      - name: Set the job status
-        if: always()
-        run: |
-          if ${{ steps.cwag-build-docker-compose.outcome=='success' || steps.retry-cwag-build-docker-compose.outcome=='success' }}; then
-             echo "Docker compose completed successfully"
-          else
-             echo "Docker compose failed"
-             exit 1
-          fi
+
         # TODO bring up the containers and check for crashloops
diff --git a/.github/workflows/feg-workflow.yml b/.github/workflows/feg-workflow.yml
index 2d97641f4b18..a626e3f7168c 100644
--- a/.github/workflows/feg-workflow.yml
+++ b/.github/workflows/feg-workflow.yml
@@ -32,10 +32,10 @@ jobs:
           filters: |
             filesChanged:
               - [".github/workflows/feg-workflow.yml", "orc8r/**", "lte/**", "feg/**"]
-  feg-lint:
+  feg-tests:
     needs: path_filter
     if: ${{ needs.path_filter.outputs.should_not_skip == 'true' }}
-    name: feg lint job
+    name: feg lint and precommit
     runs-on: ubuntu-latest
     env:
       GO111MODULE: on  # yamllint disable-line rule:truthy
@@ -51,21 +51,45 @@ jobs:
               ./circleci/golang_before_install.sh
       - name: Run go mod download with retry
         uses: nick-invision/retry@v2
+        continue-on-error: true
+        if: always()
+        id: feg-lint-init
         with:
           command: cd ${MAGMA_ROOT}/cwf/gateway && go mod download
           timeout_minutes: 10
       - name: Go lint code
+        continue-on-error: true
+        id: feg-lint
         run: |
               cd ${MAGMA_ROOT}/feg/gateway
               make -C ${MAGMA_ROOT}/feg/gateway lint
       - name: Generate test coverage
+        continue-on-error: true
+        id: feg-lint-cov
         run: |
               cd ${MAGMA_ROOT}/feg/gateway
               make -C ${MAGMA_ROOT}/feg/gateway cover
       - uses: codecov/codecov-action@v1
+        continue-on-error: true
+        id: feg-lint-codecov
         with:
           files: '${{ env.MAGMA_ROOT}}/feg/gateway/coverage/feg.gocov'
           flags: feg-lint
+      - name: make feg precommit
+        if: always()
+        continue-on-error: true
+        id: feg-precommit
+        run: |
+          go get gotest.tools/gotestsum
+          cd ${MAGMA_ROOT}/feg/gateway
+          make -C ${MAGMA_ROOT}/feg/gateway precommit
+      - name: Upload Test Results
+        id: feg-precommit-upload
+        if: always()
+        uses: actions/upload-artifact@v2
+        with:
+          name: Unit Test Results
+          path: "/tmp/test-results"
       - name: Extract commit title
         if: failure() && github.event_name == 'push'
         id: commit
@@ -75,7 +99,7 @@ jobs:
       # Notify ci channel when failing
       # Plugin info: https://github.com/marketplace/actions/slack-notify
       - name: Notify failure to slack
-        if: failure() && github.event_name == 'push'
+        if: ( steps.feg-lint-init.outcome=='failure' || steps.feg-lint.outcome=='failure' || steps.feg-lint-cov.outcome=='failure' || steps.feg-lint-codecov.outcome=='failure'  ) && github.event_name == 'push'
         uses: rtCamp/action-slack-notify@v2.2.0
         env:
           SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK_CI }}
@@ -85,48 +109,10 @@ jobs:
           SLACK_ICON_EMOJI: ":boom:"
           SLACK_COLOR: "#FF0000"
           SLACK_FOOTER: ' '
-  feg-precommit:
-    needs: path_filter
-    if: ${{ needs.path_filter.outputs.should_not_skip == 'true' }}
-    name: feg pre-commit job
-    runs-on: ubuntu-latest
-    env:
-      GO111MODULE: on  # yamllint disable-line rule:truthy
-      MAGMA_ROOT: "${{ github.workspace }}"
-    steps:
-      - uses: actions/checkout@v2
-      - uses: actions/setup-go@v2
-        with:
-          go-version: '1.15.7'
-      - run: go version
-      - name: Run golang_before_install.sh script
-        run: ./circleci/golang_before_install.sh
-      - name: Run go mod download with retry
-        uses: nick-invision/retry@v2
-        with:
-          command: cd ${MAGMA_ROOT}/cwf/gateway && go mod download
-          timeout_minutes: 10
-      - name: make feg precommit
-        run: |
-            go get gotest.tools/gotestsum
-            cd ${MAGMA_ROOT}/feg/gateway
-            make -C ${MAGMA_ROOT}/feg/gateway precommit
-      - name: Upload Test Results
-        if: always()
-        uses: actions/upload-artifact@v2
-        with:
-          name: Unit Test Results
-          path: "/tmp/test-results"
-      - name: Extract commit title
-        id: commit
-        if: failure() && github.event_name == 'push'
-        run: |
-          str="$(jq '.head_commit.message' $GITHUB_EVENT_PATH)"    # get the head_commit message
-          echo ::set-output name=title::${str%%\\n*} | tr -d '"'
       # Notify ci channel when failing
       # Plugin info: https://github.com/marketplace/actions/slack-notify
       - name: Notify failure to slack
-        if: failure() && github.event_name == 'push'
+        if: ( steps.feg-precommit.outcome=='failure' || steps.feg-precommit-upload.outcome=='failure' ) && github.event_name == 'push'
         uses: rtCamp/action-slack-notify@v2.2.0
         env:
           SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK_CI }}

From 3df9b26006d64118e658fc4e348aead515fd951a Mon Sep 17 00:00:00 2001
From: quentinDERORY <15911421+quentinDERORY@users.noreply.github.com>
Date: Wed, 3 Nov 2021 19:14:07 +0100
Subject: [PATCH 2/2] clean PR

Signed-off-by: quentinDERORY <15911421+quentinDERORY@users.noreply.github.com>
---
 .github/workflows/agw-workflow.yml  | 4 ++--
 .github/workflows/cwag-workflow.yml | 2 --
 .github/workflows/feg-workflow.yml  | 2 +-
 3 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/.github/workflows/agw-workflow.yml b/.github/workflows/agw-workflow.yml
index 2b20af0e4931..d06e4b3fa378 100644
--- a/.github/workflows/agw-workflow.yml
+++ b/.github/workflows/agw-workflow.yml
@@ -334,10 +334,10 @@ jobs:
           SLACK_COLOR: "#FF0000"
           SLACK_FOOTER: ' '
 
-  mme-clang-warnings:
+  mme-clang-tidy-and-warning-and-cpp-cov:
     needs: path_filter
     if: ${{ needs.path_filter.outputs.should_not_skip == 'true' }}
-    name: mme clang warnings job
+    name: mme clang tidy/warning and cpp cov
     runs-on: ubuntu-latest
     env:
       MAGMA_ROOT: "${{ github.workspace }}"
diff --git a/.github/workflows/cwag-workflow.yml b/.github/workflows/cwag-workflow.yml
index fe779c401afa..a3dbdc386210 100644
--- a/.github/workflows/cwag-workflow.yml
+++ b/.github/workflows/cwag-workflow.yml
@@ -77,5 +77,3 @@ jobs:
           SLACK_ICON_EMOJI: ":boom:"
           SLACK_COLOR: "#FF0000"
           SLACK_FOOTER: ' '
-
-        # TODO bring up the containers and check for crashloops
diff --git a/.github/workflows/feg-workflow.yml b/.github/workflows/feg-workflow.yml
index a626e3f7168c..2132ac2f3310 100644
--- a/.github/workflows/feg-workflow.yml
+++ b/.github/workflows/feg-workflow.yml
@@ -32,7 +32,7 @@ jobs:
           filters: |
             filesChanged:
               - [".github/workflows/feg-workflow.yml", "orc8r/**", "lte/**", "feg/**"]
-  feg-tests:
+  feg-lint-precommit:
     needs: path_filter
     if: ${{ needs.path_filter.outputs.should_not_skip == 'true' }}
     name: feg lint and precommit