Correct 150/ExecType for FIX 4.1/4.2 in Executor example
#1083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks for the PR @wilson-zh |
chrjohn
changed the title
150/ExecType for FIX 4.1/4.2 in Executor example
chrjohn
reviewed
Dec 1, 2025
|
|
||
| quickfix.fix41.ExecutionReport accept = new quickfix.fix41.ExecutionReport(genOrderID(), genExecID(), | ||
| new ExecTransType(ExecTransType.NEW), new ExecType(ExecType.TRADE), new OrdStatus(OrdStatus.NEW), order | ||
| new ExecTransType(ExecTransType.NEW), new ExecType(ExecType.NEW), new OrdStatus(OrdStatus.NEW), order |
Contributor
Author
There was a problem hiding this comment.
thanks, my pleasure
chrjohn
approved these changes
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #968
Summary
This PR fixes validation failures in the Executor example when running FIX 4.1
and FIX 4.2 sessions. The previous implementation used
ExecType.TRADE(valueF) for outgoing ExecutionReport messages, but this ExecType is only validbeginning in FIX 4.3. The FIX 4.1/4.2 data dictionaries reject this value.