Skip to content

Commit fb90b92

Browse files
committed
Correct duration validation tests
1 parent 7e6a96f commit fb90b92

File tree

1 file changed

+8
-35
lines changed

1 file changed

+8
-35
lines changed

tests/test_quixstreams/test_state/test_rocksdb/test_windowed/test_transaction.py

Lines changed: 8 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -220,62 +220,35 @@ def test_expire_windows_with_grace_empty(self, windowed_rocksdb_store_factory):
220220

221221
assert not expired
222222

223-
@pytest.mark.parametrize(
224-
"start_ms, end_ms",
225-
[
226-
(0, 0),
227-
(1, 0),
228-
],
229-
)
230-
def test_get_window_invalid_duration(
231-
self, start_ms, end_ms, windowed_rocksdb_store_factory
232-
):
223+
def test_get_window_invalid_duration(self, windowed_rocksdb_store_factory):
233224
store = windowed_rocksdb_store_factory()
234225
store.assign_partition(0)
235226
prefix = b"__key__"
236227
with store.start_partition_transaction(0) as tx:
237228
with pytest.raises(ValueError, match="Invalid window duration"):
238-
tx.get_window(start_ms=start_ms, end_ms=end_ms, prefix=prefix)
239-
240-
@pytest.mark.parametrize(
241-
"start_ms, end_ms",
242-
[
243-
(0, 0),
244-
(1, 0),
245-
],
246-
)
247-
def test_update_window_invalid_duration(
248-
self, start_ms, end_ms, windowed_rocksdb_store_factory
249-
):
229+
tx.get_window(start_ms=1, end_ms=0, prefix=prefix)
230+
231+
def test_update_window_invalid_duration(self, windowed_rocksdb_store_factory):
250232
store = windowed_rocksdb_store_factory()
251233
store.assign_partition(0)
252234
prefix = b"__key__"
253235
with store.start_partition_transaction(0) as tx:
254236
with pytest.raises(ValueError, match="Invalid window duration"):
255237
tx.update_window(
256-
start_ms=start_ms,
257-
end_ms=end_ms,
238+
start_ms=1,
239+
end_ms=0,
258240
value=1,
259241
timestamp_ms=1,
260242
prefix=prefix,
261243
)
262244

263-
@pytest.mark.parametrize(
264-
"start_ms, end_ms",
265-
[
266-
(0, 0),
267-
(1, 0),
268-
],
269-
)
270-
def test_delete_window_invalid_duration(
271-
self, start_ms, end_ms, windowed_rocksdb_store_factory
272-
):
245+
def test_delete_window_invalid_duration(self, windowed_rocksdb_store_factory):
273246
store = windowed_rocksdb_store_factory()
274247
store.assign_partition(0)
275248
prefix = b"__key__"
276249
with store.start_partition_transaction(0) as tx:
277250
with pytest.raises(ValueError, match="Invalid window duration"):
278-
tx.delete_window(start_ms=start_ms, end_ms=end_ms, prefix=prefix)
251+
tx.delete_window(start_ms=1, end_ms=0, prefix=prefix)
279252

280253
def test_expire_windows_no_expired(self, windowed_rocksdb_store_factory):
281254
store = windowed_rocksdb_store_factory()

0 commit comments

Comments
 (0)