Merge pull request #743 from maiieul/update-to-nx-18

chore: update to nx 18

Author: shairez

.github/actions/setup/action.yml

@@ -6,7 +6,7 @@ inputs:
   node_version:
     description: Node Version
     required: false
-    default: '16'
+    default: '18'
 
 runs:
   using: composite
@@ -25,7 +25,7 @@ runs:
     - name: Setup pnpm
       uses: pnpm/[email protected]
       with:
-        version: 7
+        version: 8
 
     - name: Use Node
       uses: actions/setup-node@v4

.github/workflows/release.yml

@@ -11,7 +11,7 @@ jobs:
 
     strategy:
       matrix:
-        node_version: [16, 18, 20, 21]
+        node_version: [18, 20, 21, 22]
 
     steps:
       - uses: actions/checkout@v3

.github/workflows/test.yml

@@ -10,7 +10,7 @@ jobs:
 
     strategy:
       matrix:
-        node_version: [16, 18, 20, 21]
+        node_version: [18, 20, 21, 22]
 
     steps:
       - name: Cancel Previous Runs

migrations.json

@@ -2,55 +2,87 @@
   "migrations": [
     {
       "cli": "nx",
-      "version": "17.0.0-beta.1",
-      "description": "Updates the default cache directory to .nx/cache",
-      "implementation": "./src/migrations/update-17-0-0/move-cache-directory",
+      "version": "17.3.0-beta.6",
+      "description": "Updates the nx wrapper.",
+      "implementation": "./src/migrations/update-17-3-0/update-nxw",
       "package": "nx",
-      "name": "17.0.0-move-cache-directory"
+      "name": "17.3.0-update-nx-wrapper"
     },
     {
       "cli": "nx",
-      "version": "17.0.0-beta.3",
-      "description": "Use minimal config for tasksRunnerOptions",
-      "implementation": "./src/migrations/update-17-0-0/use-minimal-config-for-tasks-runner-options",
+      "version": "18.0.0-beta.2",
+      "description": "Updates nx.json to disabled adding plugins when generating projects in an existing Nx workspace",
+      "implementation": "./src/migrations/update-18-0-0/disable-crystal-for-existing-workspaces",
+      "x-repair-skip": true,
       "package": "nx",
-      "name": "17.0.0-use-minimal-config-for-tasks-runner-options"
+      "name": "18.0.0-disable-adding-plugins-for-existing-workspaces"
     },
     {
-      "version": "17.0.0-rc.1",
-      "description": "Migration for v17.0.0-rc.1",
-      "implementation": "./src/migrations/update-17-0-0/rm-default-collection-npm-scope",
+      "version": "18.1.0-beta.3",
+      "description": "Moves affected.defaultBase to defaultBase in `nx.json`",
+      "implementation": "./src/migrations/update-17-2-0/move-default-base",
       "package": "nx",
-      "name": "rm-default-collection-npm-scope"
+      "name": "move-default-base-to-nx-json-root"
     },
     {
-      "version": "17.1.0-beta.2",
-      "description": "Move target defaults",
-      "implementation": "./src/migrations/update-17-1-0/move-target-defaults",
+      "cli": "nx",
+      "version": "17.2.6-beta.1",
+      "description": "Rename workspace rules from @nx/workspace/name to @nx/workspace-name",
+      "implementation": "./src/migrations/update-17-2-6-rename-workspace-rules/rename-workspace-rules",
+      "package": "@nx/eslint-plugin",
+      "name": "update-17-2-6-rename-workspace-rules"
+    },
+    {
+      "version": "17.2.0-beta.10",
+      "description": "Update vite config.",
+      "implementation": "./src/migrations/update-17-2-0/update-vite-config",
+      "package": "@nx/vite",
+      "name": "update-vite-config"
+    },
+    {
+      "version": "17.3.0-beta.0",
+      "description": "Move the vitest coverage thresholds in their own object if exists and add reporters.",
+      "implementation": "./src/migrations/update-17-3-0/vitest-coverage-and-reporters",
       "package": "@nx/vite",
-      "name": "move-target-defaults"
+      "name": "vitest-coverage-and-reporters"
+    },
+    {
+      "cli": "nx",
+      "version": "17.3.1-beta.0",
+      "description": "Add project property to playwright config",
+      "implementation": "./src/migrations/update-17-3-1/add-project-to-config",
+      "package": "@nx/playwright",
+      "name": "17-3-1-add-project-to-config"
+    },
+    {
+      "cli": "nx",
+      "version": "18.1.0-beta.3",
+      "description": "Remove invalid baseUrl option from @nx/playwright:playwright targets in project.json.",
+      "implementation": "./src/migrations/update-18-1-0/remove-baseUrl-from-project-json",
+      "package": "@nx/playwright",
+      "name": "18-1-0-remove-baseUrl-from-project-json"
     },
     {
       "cli": "nx",
-      "version": "17.0.2",
-      "description": "Remove deprecated build options",
-      "implementation": "./src/migrations/update-17-0-0/remove-deprecated-build-options",
-      "package": "@nx/js",
-      "name": "update-17-0-0-remove-deprecated-build-options"
+      "version": "18.1.0-beta.3",
+      "description": "Update to Cypress ^13.6.6 if the workspace is using Cypress v13 to ensure workspaces don't use v13.6.5 which has an issue when verifying Cypress.",
+      "implementation": "./src/migrations/update-18-1-0/update-cypress-version-13-6-6",
+      "package": "@nx/cypress",
+      "name": "update-cypress-version-13-6-6"
     },
     {
-      "version": "17.0.0-beta.7",
-      "description": "update-17-0-0-rename-to-eslint",
-      "implementation": "./src/migrations/update-17-0-0-rename-to-eslint/update-17-0-0-rename-to-eslint",
+      "version": "17.2.0-beta.0",
+      "description": "Simplify eslintFilePatterns",
+      "implementation": "./src/migrations/update-17-2-0/simplify-eslint-patterns",
       "package": "@nx/eslint",
-      "name": "update-17-0-0-rename-to-eslint"
+      "name": "simplify-eslint-patterns"
     },
     {
-      "version": "17.1.0-beta.1",
-      "description": "Updates for @typescript-utils/utils v6.9.1+",
-      "implementation": "./src/migrations/update-17-1-0/update-typescript-eslint",
+      "version": "17.2.9",
+      "description": "Move executor options to target defaults",
+      "implementation": "./src/migrations/update-17-2-9/move-options-to-target-defaults",
       "package": "@nx/eslint",
-      "name": "update-typescript-eslint"
+      "name": "move-options-to-target-defaults"
     }
   ]
 }

package.json

@@ -40,9 +40,9 @@
     "test.headless.ci": "nx component-test-ci headless",
     "test.utils": "nx test utils"
   },
-  "packageManager": "pnpm@9.1.1",
+  "packageManager": "pnpm@8.15.8",
   "devDependencies": {
-    "@axe-core/playwright": "4.8.5",
+    "@axe-core/playwright": "4.9.0",
     "@builder.io/qwik": "^1.5.4",
     "@builder.io/qwik-city": "^1.5.4",
     "@builder.io/qwik-react": "0.5.3",
@@ -58,23 +58,23 @@
     "@fontsource-variable/inter": "5.0.8",
     "@img/sharp-linux-x64": "^0.33.0",
     "@jscutlery/semver": "^4.2.0",
-    "@k11r/nx-cloudflare-wrangler": "2.7.1",
-    "@nx/cypress": "17.1.3",
-    "@nx/devkit": "17.1.3",
-    "@nx/eslint": "17.1.3",
-    "@nx/eslint-plugin": "17.1.3",
-    "@nx/jest": "17.1.3",
-    "@nx/js": "17.1.3",
-    "@nx/playwright": "17.1.3",
-    "@nx/plugin": "17.2.3",
-    "@nx/storybook": "17.1.3",
-    "@nx/vite": "17.1.3",
-    "@nx/workspace": "17.1.3",
+    "@k11r/nx-cloudflare-wrangler": "3.0.0-feat-sst-upgrade.1",
+    "@nx/cypress": "18.0.0",
+    "@nx/devkit": "18.0.0",
+    "@nx/eslint": "18.0.0",
+    "@nx/eslint-plugin": "18.0.0",
+    "@nx/jest": "18.0.0",
+    "@nx/js": "18.0.0",
+    "@nx/playwright": "18.0.0",
+    "@nx/plugin": "18.0.0",
+    "@nx/storybook": "18.0.0",
+    "@nx/vite": "18.0.0",
+    "@nx/workspace": "18.0.0",
     "@oddbird/popover-polyfill": "0.4.3",
     "@playwright/test": "^1.41.2",
     "@qwikest/icons": "0.0.13",
     "@radix-ui/react-scroll-area": "1.0.5",
-    "@shikijs/transformers": "1.1.7",
+    "@shikijs/transformers": "1.5.2",
     "@storybook/addon-a11y": "7.6.0",
     "@storybook/addon-coverage": "^0.0.9",
     "@storybook/addon-essentials": "7.6.0",
@@ -87,20 +87,20 @@
     "@storybook/jest": "0.2.3",
     "@storybook/test-runner": "0.13.0",
     "@storybook/testing-library": "0.2.2",
-    "@swc-node/register": "~1.6.7",
+    "@swc-node/register": "1.8.0",
     "@swc/core": "~1.3.85",
     "@testing-library/cypress": "9.0.0",
     "@types/decompress": "4.2.7",
     "@types/eslint": "^8.44.2",
     "@types/estree-jsx": "^1.0.3",
     "@types/jest": "^29.4.0",
-    "@types/node": "^20.5.7",
+    "@types/node": "^20.12.12",
     "@types/react": "18.0.28",
     "@types/react-dom": "18.0.11",
-    "@typescript-eslint/eslint-plugin": "6.13.1",
-    "@typescript-eslint/parser": "6.13.1",
-    "@vitest/coverage-v8": "~0.34.6",
-    "@vitest/ui": "^0.34.3",
+    "@typescript-eslint/eslint-plugin": "7.9.0",
+    "@typescript-eslint/parser": "7.9.0",
+    "@vitest/coverage-v8": "0.34.6",
+    "@vitest/ui": "0.34.7",
     "all-contributors-cli": "^6.26.1",
     "ansis": "2.3.0",
     "autoprefixer": "^10.4.15",
@@ -121,7 +121,7 @@
     "danger": "^11.2.8",
     "decompress": "4.2.1",
     "dotenv": "16.3.1",
-    "eslint": "^8.48.0",
+    "eslint": "8.57.0",
     "eslint-config-prettier": "9.0.0",
     "eslint-plugin-cypress": "^2.14.0",
     "eslint-plugin-playwright": "^1.3.0",
@@ -137,19 +137,19 @@
     "ngx-deploy-npm": "^7.0.1",
     "node-fetch": "^3.3.2",
     "np": "^8.0.4",
-    "nx": "17.1.3",
+    "nx": "18.0.0",
     "postcss": "^8.4.29",
     "prettier": "^3.2.5",
     "prettier-plugin-tailwindcss": "^0.4.1",
     "pretty-quick": "^4.0.0",
-    "qwik-nx": "^1.0.8",
+    "qwik-nx": "^2.2.1",
     "qwik-themes": "^0.2.0",
     "react": "18.2.0",
     "react-dom": "18.2.0",
     "rehype-pretty-code": "^0.13.0",
     "rollup-plugin-pure": "0.2.1",
     "sass": "^1.66.1",
-    "shiki": "1.1.7",
+    "shiki": "1.5.2",
     "specificity": "^1.0.0",
     "storybook": "^7.4.0",
     "storybook-framework-qwik": "^0.2.3",
@@ -159,19 +159,19 @@
     "ts-jest": "^29.1.0",
     "ts-node": "10.9.1",
     "tslib": "^2.6.2",
-    "typescript": "^5.2.2",
+    "typescript": "5.4.5",
     "undici": "^5.23.0",
     "unified": "^11.0.4",
     "unist-util-visit": "^5.0.0",
     "verdaccio": "^5.0.4",
-    "vite": "^5.1.6",
+    "vite": "5.2.11",
     "vite-plugin-dts": "^3.5.3",
     "vite-plugin-eslint": "^1.8.1",
     "vite-plugin-inspect": "0.7.38",
     "vite-plugin-static-copy": "0.17.0",
     "vite-tsconfig-paths": "4.2.0",
-    "vitest": "^0.34.3",
-    "wrangler": "^3.11.0",
+    "vitest": "0.34.6",
+    "wrangler": "^3.57.0",
     "yargs": "17.7.2"
   },
   "config": {

packages/kit-headless/src/components/accordion/accordion.tsx

@@ -37,7 +37,6 @@ export const Accordion: FunctionComponent<AccordionProps> = (props) => {
 
     if (child.type === AccordionItem) {
       const { label } = child.props as AccordionItemProps;
-      console.log('label', label);
       if (label) {
         const currentContent = child.children;
         child.props.children = child.children = [

packages/kit-styled/src/templates/global.css

@@ -1240,11 +1240,19 @@
 
   *::-webkit-scrollbar-thumb {
     /* Thumb color */
-    background-color: var(--qwikui-slate-500);
+    background-color: hsla(var(--foreground) / 0.25);
     border-radius: 0.5rem;
     background-clip: padding-box;
-    border-left: 0.3rem solid transparent;
-    border-right: 0.3rem solid transparent;
+    border-left: 0.15rem solid transparent;
+    border-right: 0.15rem solid transparent;
+  }
+
+  .navigation-docs::-webkit-scrollbar-thumb {
+    background-color: hsla(var(--foreground) / 0.1);
+  }
+
+  .dark .navigation-docs::-webkit-scrollbar-thumb {
+    background-color: hsla(var(--foreground) / 0.2);
   }
 
   *::-webkit-scrollbar-corner {
@@ -1256,10 +1264,6 @@
     border-left: 1px solid var(--qwikui-slate-300);
   }
 
-  .dark *::-webkit-scrollbar-thumb {
-    background-color: var(--qwikui-slate-500);
-  }
-
   .dark *::-webkit-scrollbar-track {
     background: transparent;
     border-left: 1px solid var(--qwikui-slate-800);
@@ -1272,7 +1276,7 @@
   }
 
   .code-example *::-webkit-scrollbar-thumb {
-    background: var(--qwikui-slate-500);
+    background-color: var(--qwikui-slate-600);
     border-radius: 0.5rem;
     background-clip: padding-box;
   }
@@ -1290,6 +1294,10 @@
   .dark .note-link a {
     border-bottom: 1px solid white !important;
   }
+
+  .gif-container {
+    border-radius: var(--border-radius);
+  }
 }
 
 :root {