Skip to content

Commit f50b16f

Browse files
committed
refactor(modal): inline BodyScrollOptions
1 parent e9c57a4 commit f50b16f

File tree

1 file changed

+3
-9
lines changed
  • packages/kit-headless/src/components/modal

1 file changed

+3
-9
lines changed

packages/kit-headless/src/components/modal/modal.tsx

+3-9
Original file line numberDiff line numberDiff line change
@@ -10,19 +10,18 @@ import {
1010
useStyles$,
1111
useTask$,
1212
} from '@builder.io/qwik';
13+
1314
import {
1415
activateFocusTrap,
1516
closeModal,
1617
deactivateFocusTrap,
17-
keepModalInPlaceWhileScrollbarReappears as keepModalInPlaceWhenScrollbarReappears,
18-
lockScroll,
1918
overrideNativeDialogEscapeBehaviorWith,
2019
showModal,
2120
trapFocus,
2221
wasModalBackdropClicked,
2322
} from './modal-behavior';
2423

25-
import { disableBodyScroll, type BodyScrollOptions } from 'body-scroll-lock';
24+
import { disableBodyScroll } from 'body-scroll-lock';
2625

2726
import styles from './modal.css?inline';
2827

@@ -38,10 +37,6 @@ export const Modal = component$((props: ModalProps) => {
3837
useStyles$(styles);
3938
const modalRefSig = useSignal<HTMLDialogElement>();
4039

41-
const scrollOptions: BodyScrollOptions = {
42-
reserveScrollBarGap: true,
43-
};
44-
4540
const { 'bind:show': showSig } = props;
4641

4742
useTask$(async function toggleModal({ track, cleanup }) {
@@ -60,7 +55,7 @@ export const Modal = component$((props: ModalProps) => {
6055

6156
if (isOpen) {
6257
showModal(modal);
63-
disableBodyScroll(modal, scrollOptions);
58+
disableBodyScroll(modal, { reserveScrollBarGap: true });
6459
props.onShow$?.();
6560
activateFocusTrap(focusTrap);
6661
} else {
@@ -70,7 +65,6 @@ export const Modal = component$((props: ModalProps) => {
7065

7166
cleanup(() => {
7267
deactivateFocusTrap(focusTrap);
73-
keepModalInPlaceWhenScrollbarReappears(scrollbar, modalRefSig.value);
7468
});
7569
});
7670

0 commit comments

Comments
 (0)