Also update \linkS4class{} in @inheritParams (#1776)

Fixes #1634

Author: hadley

NEWS.md

@@ -1,5 +1,6 @@
 # roxygen2 (development version)
 
+* `@inheritParams` now correctly updates `\linkS4class{}` links when inheriting parameter documentation from other packages, converting them to absolute links (#1634).
 * Package documentation now lists a person with both `"aut"` and `"cre"` roles in both the Maintainer and Authors sections (#1588).
 * Markdown links now do a better job of resolving package names: the process is cached for better performance (#1724); it works with infix operators (e.g. `[%in%]`) (#1728); no longer changes the link text (#1662); and includes base packages when reporting ambiguous functions (#1725).
 * Package documentation now uses `logo.svg` if available, falling back to `logo.png` (#1640).

R/rd-inherit.R

@@ -472,6 +472,15 @@ tweak_links <- function(x, package) {
           )
         }
       }
+    } else if (!is.null(tag) && tag == "\\linkS4class") {
+      topic <- paste0(x[[1]], "-class")
+      if (has_topic(topic, package)) {
+        attr(x, "Rd_tag") <- "\\link"
+        attr(x, "Rd_option") <- structure(
+          paste0(package, ":", topic),
+          Rd_tag = "TEXT"
+        )
+      }
     } else if (length(x) > 0) {
       x[] <- map(x, tweak_links, package = package)
     }

tests/testthat/test-rd-inherit.R

@@ -57,6 +57,15 @@ test_that("relative links converted to absolute", {
     link_to_base("\\link[foo::abbreviate]{abbr}"),
     "\\link[foo::abbreviate]{abbr}\n"
   )
+
+  # linkS4class converted to absolute link (#1634)
+  link_to_methods <- function(x) {
+    rd2text(parse_rd(x), package = "methods")
+  }
+  expect_equal(
+    link_to_methods("\\linkS4class{genericFunction}"),
+    "\\link[methods:genericFunction-class]{genericFunction}\n"
+  )
 })
 
 # tag parsing -------------------------------------------------------------