Skip to content

Added NavBar #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added NavBar #23

wants to merge 1 commit into from

Conversation

@AAgar
Copy link
Collaborator

@AAgar AAgar commented May 2, 2017

We will need to change the
padding-top:18px;

I just put that for now but we need it to be responsive

AsLogd
AsLogd suggested changes May 2, 2017
View reviewed changes
Copy link
Contributor

@AsLogd AsLogd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a more semantic way would be articles representing pages exclusively (like the landing page, team page, etc). I would move the "nav" in the "header" section (because it will be always visible) and remove the "article id="nav""

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@AsLogd AsLogd AsLogd requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AAgar @AsLogd