PUC-314: adding clean step

Author: haseebsyed12

workflows/argo-events/workflowtemplates/enroll-server.yaml

@@ -1,14 +1,15 @@
 ---
 apiVersion: argoproj.io/v1alpha1
 metadata:
-  name: enroll-server
+  name: enroll-server-clean
   annotations:
     workflows.argoproj.io/title: Perform server discovery and update Nautobot and Ironic
     workflows.argoproj.io/description: |
       Defined in `workflows/argo-events/workflowtemplates/enroll-server.yaml`
 kind: WorkflowTemplate
 spec:
   entrypoint: main
+  serviceAccountName: workflow
   arguments:
     parameters:
       - name: ip_address
@@ -28,10 +29,16 @@ spec:
             arguments:
               parameters:
                 - name: operation
-                  value: "manage"
+                  value: manage
                 - name: device_id
                   value: "{{steps.enroll-server.outputs.result}}"
             when: "{{steps.server-enroll-state.outputs.result}} == enroll"
+        - - name: clean-server
+            template: node-clean-cmd
+            arguments:
+              parameters:
+                - name: device_id
+                  value: "{{steps.enroll-server.outputs.result}}"
         - - name: openstack-set-baremetal-node-raid-config
             template: openstack-set-baremetal-node-raid-config
             arguments:
@@ -49,7 +56,7 @@ spec:
             arguments:
               parameters:
                 - name: operation
-                  value: "provide"
+                  value: provide
                 - name: device_id
                   value: "{{steps.enroll-server.outputs.result}}"
             when: "{{steps.server-manage-state.outputs.result}} == manageable"
@@ -75,18 +82,18 @@ spec:
             name: understack-flavors
             readOnly: true
         env:
-        - name: WF_NS
-          value: "{{workflow.namespace}}"
-        - name: WF_NAME
-          value: "{{workflow.name}}"
-        - name: WF_UID
-          value: "{{workflow.uid}}"
-        - name: FLAVORS_DIR
-          valueFrom:
-            configMapKeyRef:
-              name: understack-flavors
-              key: FLAVORS_DIR
-              optional: true
+          - name: WF_NS
+            value: "{{workflow.namespace}}"
+          - name: WF_NAME
+            value: "{{workflow.name}}"
+          - name: WF_UID
+            value: "{{workflow.uid}}"
+          - name: FLAVORS_DIR
+            valueFrom:
+              configMapKeyRef:
+                name: understack-flavors
+                key: FLAVORS_DIR
+                optional: true
       volumes:
         - name: bmc-master
           secret:
@@ -128,19 +135,49 @@ spec:
         - name: openstack-svc-acct
           secret:
             secretName: openstack-svc-acct
+    - name: node-clean-cmd
+      inputs:
+        parameters:
+          - name: device_id
+      container:
+        image: ghcr.io/rackerlabs/understack/openstack-client:2024.2-ubuntu_jammy
+        command:
+          - openstack
+        args:
+          - baremetal
+          - node
+          - clean
+          - "{{inputs.parameters.device_id}}"
+          - --clean-steps
+          - '[{"interface":"bios","step":"apply_configuration","args":{"settings":[{"name":"HttpDev1EnDis","value":"Enabled"},{"name":"HttpDev1Interface","value":"NIC.Slot.1-1"},{"name":"HttpDev1TlsMode","value":"None"}]}}]'
+        env:
+          - name: OS_CLOUD
+            value: understack
+        volumeMounts:
+          - mountPath: /etc/openstack
+            name: openstack-svc-acct
+            readOnly: true
+      volumes:
+        - name: openstack-svc-acct
+          secret:
+            secretName: openstack-svc-acct
     - name: openstack-set-baremetal-node-raid-config
       inputs:
         parameters:
           - name: device_id
-      # https://rackerlabs.github.io/understack/user-guide/openstack-ironic/#setting-baremetal-node-flavor
       script:
         image: ghcr.io/rackerlabs/understack/openstack-client:2024.2-ubuntu_jammy
-        command: [sh]
-        source: |
+        command:
+          - sh
+        source: >
           echo "setting RAID1 config for node: {{inputs.parameters.device_id}}"
+
           # create the raid1-config.json file. I find this easier to read
+
           # than passing a big json string on command line
+
           cat <<'EOF' >> raid1-config.json
+
           { "logical_disks":
             [ { "controller": "RAID.SL.1-1",
                 "is_root_volume": true,
@@ -153,9 +190,13 @@ spec:
               }
             ]
           }
+
           EOF
+
           # create the initial clean steps which will create a raid config
+
           cat <<'EOF' >> raid-clean-steps.json
+
           [
               {
                   "interface": "raid",
@@ -166,10 +207,15 @@ spec:
                   "step": "create_configuration"
               }
           ]
+
           EOF
+
           # apply the target raid config to the node
+
           openstack baremetal node set {{inputs.parameters.device_id}} --target-raid-config raid1-config.json
+
           # create the raid config
+
           openstack baremetal node clean --wait 0 --clean-steps raid-clean-steps.json --disable-ramdisk {{inputs.parameters.device_id}}
         env:
           - name: OS_CLOUD
@@ -194,9 +240,9 @@ spec:
           - baremetal
           - node
           - show
-          - "-f"
+          - -f
           - value
-          - "-c"
+          - -c
           - provision_state
           - "{{inputs.parameters.device_id}}"
         env: