using generic handler.

Author: syedhaseebahmed

components/site-workflows/kustomization.yaml

@@ -22,8 +22,7 @@ resources:
   - sensors/sensor-neutron-olso-event.yaml
   - sensors/sensor-ironic-reclean.yaml
   - sensors/sensor-ironic-node-port.yaml
-  - sensors/sensor-ironic-oslo-deploying-event.yaml
-  - sensors/sensor-ironic-oslo-inspecting-event.yaml
+  - sensors/sensor-ironic-oslo-event.yaml
 
 helmCharts:
   - name: nautobot-token

components/site-workflows/sensors/sensor-ironic-oslo-deploying-event.yaml renamed to components/site-workflows/sensors/sensor-ironic-oslo-event.yaml

@@ -2,7 +2,7 @@
 apiVersion: argoproj.io/v1alpha1
 kind: Sensor
 metadata:
-  name: ironic-oslo-deploying-event
+  name: ironic-oslo-event
   annotations:
     workflows.argoproj.io/title: Process oslo_events for ironic project
     workflows.argoproj.io/description: |+
@@ -17,7 +17,7 @@ metadata:
       -p event-json "JSON-payload" -p device_id=<UUID> -p project_id=<UUID>
       ```
 
-      Defined in `workflows/argo-events/sensors/sensor-sensor-ironic-oslo-deploying-event.yaml`
+      Defined in `components/site-workflows/sensors/sensor-ironic-oslo-event.yaml`
 spec:
   dependencies:
   - eventName: openstack
@@ -43,6 +43,7 @@ spec:
           type: "string"
           value:
             - "deploying"
+            - "inspecting"
   template:
     serviceAccountName: sensor-submit-workflow
   triggers:
@@ -64,6 +65,10 @@ spec:
               src:
                 dataKey: body.ironic_object.lessee
                 dependencyName: ironic-dep
+            - dest: spec.arguments.parameters.3.value # previous_provision_state
+              src:
+                dataKey: body.ironic_object.previous_provision_state
+                dependencyName: ironic-dep
           source:
             # create a workflow in argo-events prefixed with ironic-prov-
             resource:
@@ -81,6 +86,7 @@ spec:
                     - name: event-json
                     - name: device_id
                     - name: project_id
+                    - name: previous_provision_state
                 templates:
                 - name: main
                   steps:
@@ -93,6 +99,7 @@ spec:
                         - name: event-json
                           value: "{{workflow.parameters.event-json}}"
                     - name: convert-project-id
+                      when: "\"{{workflow.parameters.previous_provision_state}}\" == deploying"
                       inline:
                         script:
                           image: python:alpine
@@ -102,7 +109,7 @@ spec:
                               project_id_without_dashes = "{{workflow.parameters.project_id}}"
                               print(str(uuid.UUID(project_id_without_dashes)))
                   - - name: ansible-storage-update
-                      when: "\"{{steps.oslo-events.outputs.parameters.storage}}\" == wanted"
+                      when: "\"{{steps.oslo-events.outputs.parameters.storage}}\" == wanted && \"{{workflow.parameters.previous_provision_state}}\" == deploying"
                       templateRef:
                         name: ansible-workflow-template
                         template: ansible-run

components/site-workflows/sensors/sensor-ironic-oslo-inspecting-event.yaml

@@ -70,11 +70,11 @@ Server Enrollment → Redfish Inspection → Oslo Event Bus → Argo Events Sens
 
 5. **Workflow Trigger**
    - Sensor creates an Argo Workflow named `update-nautobot-*`
-   - Workflow uses template `update-nautobot-on-openstack-oslo-event`
+   - Workflow uses template `openstack-oslo-event`
    - Event data is passed as workflow parameter
 
 6. **Data Processing**
-   - Workflow executes `update-nautobot-on-openstack-oslo-event` script
+   - Workflow executes `openstack-oslo-event` script
    - Script fetches full inventory data from Ironic API using node UUID
    - Inventory data is parsed and transformed into Nautobot format
 
@@ -88,7 +88,7 @@ Server Enrollment → Redfish Inspection → Oslo Event Bus → Argo Events Sens
 
 ### Sensor Configuration
 
-**File:** `components/site-workflows/sensors/sensor-ironic-oslo-inspecting-event.yaml`
+**File:** `components/site-workflows/sensors/sensor-ironic-oslo-event.yaml`
 
 The sensor configuration defines:
 
@@ -99,11 +99,11 @@ The sensor configuration defines:
 
 ### Workflow Template
 
-**File:** `workflows/argo-events/workflowtemplates/update-nautobot-on-openstack-oslo-event.yaml`
+**File:** `workflows/argo-events/workflowtemplates/openstack-oslo-event.yaml`
 
 The workflow template:
 
-- Runs the `update-nautobot-on-openstack-oslo-event` command
+- Runs the `openstack-oslo-event` command
 - Mounts Nautobot token and OpenStack credentials
 - Passes event JSON as input file
 - Uses service account with appropriate permissions
@@ -135,86 +135,47 @@ LLDP (Link Layer Discovery Protocol) data is extracted from inspection results:
 - **Port ID (Type 2)**: Remote switch port name
 - **Port Description (Type 4)**: Alternative port identifier
 
-The system requires a minimum of 3 LLDP neighbors to be discovered for validation.
-
 #### Device Information
 
 The following device attributes are extracted:
 
-- **Manufacturer**: System vendor (e.g., Dell)
-- **Model**: Product name
-- **Serial Number**: System serial number
-- **BMC IP Address**: Out-of-band management IP
-- **BIOS Version**: Firmware version
-- **Memory**: Total RAM in GiB
-- **CPU**: Processor model
-
-### Nautobot Device Creation
-
-**Module:** `understack_workflows.nautobot_device`
-
-#### Device Creation Process
-
-1. **Switch Discovery**
-   - Identifies switches using LLDP MAC addresses
-   - Queries Nautobot for devices with matching `chassis_mac_address` custom field
-   - Validates all switches are in the same location/rack
-
-2. **Device Lookup**
-   - Searches for existing device by serial number
-   - If not found, creates new device with:
-     - Status: "Planned"
-     - Role: "server"
-     - Location and rack from connected switches
-     - Device type based on manufacturer and model
-
-3. **Interface Creation**
-   - Creates or updates network interfaces
-   - Sets MAC addresses
-   - Assigns interface types:
-     - BMC interfaces: `1000base-t`
-     - Server interfaces: `25gbase-x-sfp28`
-   - Sets status to "Active"
-
-4. **Cable Documentation**
-   - Creates cables between server and switch interfaces
-   - Uses LLDP data to identify correct switch ports
-   - Sets cable status to "Connected"
-
-5. **IP Address Assignment**
-   - Assigns IP addresses to BMC interfaces
-   - Associates IP with interface in Nautobot IPAM
-   - Converts DHCP leases to static assignments if applicable
-
-## Validation and Error Handling
-
-### LLDP Neighbor Validation
-
-The system validates that sufficient LLDP neighbors are discovered:
-
-```python
-MIN_REQUIRED_NEIGHBOR_COUNT = 3
-```
-
-If fewer than 3 neighbors are found, the workflow fails with a detailed error message showing which interfaces have LLDP data.
-
-### Location Consistency
-
-All connected switches must be in the same location and rack. If switches span multiple locations, the workflow fails to prevent topology errors.
-
-### IP Address Conflicts
-
-The system detects and prevents:
-
-- IP addresses already assigned to different interfaces
-- Interfaces already associated with different IP addresses
-
-### Switch Port Conflicts
-
-When creating cables, the system validates:
-
-- Switch interface exists in Nautobot
-- Switch port is not already connected to another device
+- **Manufacturer**: System vendor from `system_vendor.manufacturer` (e.g., Dell)
+- **Model Number**: Product name from `system_vendor.product_name` (stripped of parenthetical suffixes)
+- **Serial Number**: System serial number from `system_vendor.serial_number`
+- **BMC IP Address**: Out-of-band management IP from `bmc_address`
+- **BMC MAC Address**: BMC interface MAC address from `bmc_mac`
+- **BIOS Version**: Firmware version from `system_vendor.firmware.version`
+- **Memory**: Total RAM in GiB (converted from `memory.physical_mb`)
+- **CPU**: Processor model from `cpu.model_name`
+- **Power State**: Assumed to be powered on during inspection
+- **Hostname**: System hostname from inventory
+
+#### Interface Information
+
+For each network interface discovered during inspection, the following attributes are extracted:
+
+**BMC Interface (iDRAC):**
+
+- **Name**: "iDRAC"
+- **Description**: "Dedicated iDRAC interface"
+- **MAC Address**: From `bmc_mac` (normalized to uppercase)
+- **Hostname**: System hostname
+- **IPv4 Address**: From `bmc_address` (assumed /26 subnet)
+- **IPv4 Gateway**: Not set for Ironic-sourced data
+- **DHCP**: False (assumed static)
+- **LLDP Data**: Not collected for BMC interface
+
+**Server Interfaces:**
+
+- **Name**: Linux interface name converted to Redfish format (e.g., `eno8303` → `NIC.Embedded.1-1-1`)
+- **Description**: Network driver name + " interface" (e.g., "bnxt_en interface")
+- **MAC Address**: From interface `mac_address` (normalized to uppercase)
+- **Hostname**: System hostname
+- **IPv4 Address**: Not collected for server interfaces (only BMC has IP)
+- **LLDP Neighbor Data** (parsed from LLDP TLVs):
+    - **Remote Switch MAC Address**: From LLDP TLV Type 1 (Chassis ID, subtype 4 - MAC address)
+    - **Remote Switch Port Name**: From LLDP TLV Type 2 (Port ID) or Type 4 (Port Description)
+    - **Data Staleness**: Marked as fresh (not stale) for Ironic inspection data
 
 ## Monitoring and Troubleshooting
 
@@ -266,13 +227,13 @@ This will publish the Oslo event and trigger Nautobot synchronization.
 You can manually trigger the Nautobot update workflow for testing:
 
 ```bash
-# Capture an event from Ironic
-openstack baremetal node show <node-uuid> -f json > node.json
+# To view inspect inventory data
+openstack baremetal node inventory save [--file <filename>] <node>
 
 # Submit workflow manually
 argo -n argo-events submit \
-  --from workflowtemplate/update-nautobot-on-openstack-oslo-event \
-  -p event-json "$(cat node.json)"
+  --from workflowtemplate/openstack-oslo-event \
+  -p event-json '{"event_type":"baremetal.node.provision_set.end","payload":{"ironic_object.data":{"uuid":"<node-uuid>", "previous_provision_state":"inspecting"}}}'
 ```
 
 ### Verifying Results

docs/operator-guide/openstack-ironic-nautobot-device-interfaces-sync.md

@@ -40,7 +40,6 @@ sync-network-segment-range = "understack_workflows.main.sync_ucvni_group_range:m
 openstack-oslo-event = "understack_workflows.main.openstack_oslo_event:main"
 netapp-create-svm = "understack_workflows.main.netapp_create_svm:main"
 netapp-configure-interfaces = "understack_workflows.main.netapp_configure_net:main"
-update-nautobot-on-openstack-oslo-event = "understack_workflows.main.update_nautobot:main"
 
 [dependency-groups]
 test = [