using generic handler rather than creating new files.

Author: syedhaseebahmed

components/site-workflows/kustomization.yaml

@@ -22,8 +22,7 @@ resources:
   - sensors/sensor-neutron-olso-event.yaml
   - sensors/sensor-ironic-reclean.yaml
   - sensors/sensor-ironic-node-port.yaml
-  - sensors/sensor-ironic-oslo-deploying-event.yaml
-  - sensors/sensor-ironic-oslo-inspecting-event.yaml
+  - sensors/sensor-ironic-oslo-event.yaml
 
 helmCharts:
   - name: nautobot-token

components/site-workflows/sensors/sensor-ironic-oslo-deploying-event.yaml renamed to components/site-workflows/sensors/sensor-ironic-oslo-event.yaml

@@ -2,7 +2,7 @@
 apiVersion: argoproj.io/v1alpha1
 kind: Sensor
 metadata:
-  name: ironic-oslo-deploying-event
+  name: ironic-oslo-event
   annotations:
     workflows.argoproj.io/title: Process oslo_events for ironic project
     workflows.argoproj.io/description: |+
@@ -17,7 +17,7 @@ metadata:
       -p event-json "JSON-payload" -p device_id=<UUID> -p project_id=<UUID>
       ```
 
-      Defined in `workflows/argo-events/sensors/sensor-sensor-ironic-oslo-deploying-event.yaml`
+      Defined in `components/site-workflows/sensors/sensor-ironic-oslo-event.yaml`
 spec:
   dependencies:
   - eventName: openstack
@@ -43,6 +43,7 @@ spec:
           type: "string"
           value:
             - "deploying"
+            - "inspecting"
   template:
     serviceAccountName: sensor-submit-workflow
   triggers:
@@ -64,6 +65,10 @@ spec:
               src:
                 dataKey: body.ironic_object.lessee
                 dependencyName: ironic-dep
+            - dest: spec.arguments.parameters.3.value # previous_provision_state
+              src:
+                dataKey: body.ironic_object.previous_provision_state
+                dependencyName: ironic-dep
           source:
             # create a workflow in argo-events prefixed with ironic-prov-
             resource:
@@ -81,6 +86,7 @@ spec:
                     - name: event-json
                     - name: device_id
                     - name: project_id
+                    - name: previous_provision_state
                 templates:
                 - name: main
                   steps:
@@ -93,6 +99,7 @@ spec:
                         - name: event-json
                           value: "{{workflow.parameters.event-json}}"
                     - name: convert-project-id
+                      when: "\"{{workflow.parameters.previous_provision_state}}\" == deploying"
                       inline:
                         script:
                           image: python:alpine
@@ -102,7 +109,7 @@ spec:
                               project_id_without_dashes = "{{workflow.parameters.project_id}}"
                               print(str(uuid.UUID(project_id_without_dashes)))
                   - - name: ansible-storage-update
-                      when: "\"{{steps.oslo-events.outputs.parameters.storage}}\" == wanted"
+                      when: "\"{{steps.oslo-events.outputs.parameters.storage}}\" == wanted && \"{{workflow.parameters.previous_provision_state}}\" == deploying"
                       templateRef:
                         name: ansible-workflow-template
                         template: ansible-run

components/site-workflows/sensors/sensor-ironic-oslo-inspecting-event.yaml

@@ -70,11 +70,11 @@ Server Enrollment → Redfish Inspection → Oslo Event Bus → Argo Events Sens
 
 5. **Workflow Trigger**
    - Sensor creates an Argo Workflow named `update-nautobot-*`
-   - Workflow uses template `update-nautobot-on-openstack-oslo-event`
+   - Workflow uses template `openstack-oslo-event`
    - Event data is passed as workflow parameter
 
 6. **Data Processing**
-   - Workflow executes `update-nautobot-on-openstack-oslo-event` script
+   - Workflow executes `openstack-oslo-event` script
    - Script fetches full inventory data from Ironic API using node UUID
    - Inventory data is parsed and transformed into Nautobot format
 
@@ -99,11 +99,11 @@ The sensor configuration defines:
 
 ### Workflow Template
 
-**File:** `workflows/argo-events/workflowtemplates/update-nautobot-on-openstack-oslo-event.yaml`
+**File:** `workflows/argo-events/workflowtemplates/openstack-oslo-event.yaml`
 
 The workflow template:
 
-- Runs the `update-nautobot-on-openstack-oslo-event` command
+- Runs the `openstack-oslo-event` command
 - Mounts Nautobot token and OpenStack credentials
 - Passes event JSON as input file
 - Uses service account with appropriate permissions
@@ -135,8 +135,6 @@ LLDP (Link Layer Discovery Protocol) data is extracted from inspection results:
 - **Port ID (Type 2)**: Remote switch port name
 - **Port Description (Type 4)**: Alternative port identifier
 
-The system requires a minimum of 3 LLDP neighbors to be discovered for validation.
-
 #### Device Information
 
 The following device attributes are extracted:
@@ -158,7 +156,6 @@ The following device attributes are extracted:
 1. **Switch Discovery**
    - Identifies switches using LLDP MAC addresses
    - Queries Nautobot for devices with matching `chassis_mac_address` custom field
-   - Validates all switches are in the same location/rack
 
 2. **Device Lookup**
    - Searches for existing device by serial number
@@ -186,36 +183,6 @@ The following device attributes are extracted:
    - Associates IP with interface in Nautobot IPAM
    - Converts DHCP leases to static assignments if applicable
 
-## Validation and Error Handling
-
-### LLDP Neighbor Validation
-
-The system validates that sufficient LLDP neighbors are discovered:
-
-```python
-MIN_REQUIRED_NEIGHBOR_COUNT = 3
-```
-
-If fewer than 3 neighbors are found, the workflow fails with a detailed error message showing which interfaces have LLDP data.
-
-### Location Consistency
-
-All connected switches must be in the same location and rack. If switches span multiple locations, the workflow fails to prevent topology errors.
-
-### IP Address Conflicts
-
-The system detects and prevents:
-
-- IP addresses already assigned to different interfaces
-- Interfaces already associated with different IP addresses
-
-### Switch Port Conflicts
-
-When creating cables, the system validates:
-
-- Switch interface exists in Nautobot
-- Switch port is not already connected to another device
-
 ## Monitoring and Troubleshooting
 
 ### Viewing Workflow Executions
@@ -266,13 +233,13 @@ This will publish the Oslo event and trigger Nautobot synchronization.
 You can manually trigger the Nautobot update workflow for testing:
 
 ```bash
-# Capture an event from Ironic
-openstack baremetal node show <node-uuid> -f json > node.json
+# To view inspect inventory data
+openstack baremetal node inventory save [--file <filename>] <node>
 
 # Submit workflow manually
 argo -n argo-events submit \
-  --from workflowtemplate/update-nautobot-on-openstack-oslo-event \
-  -p event-json "$(cat node.json)"
+  --from workflowtemplate/openstack-oslo-event \
+  -p event-json '{"event_type":"baremetal.node.provision_set.end","payload":{"ironic_object.data":{"uuid":"<node-uuid>", "previous_provision_state":"inspecting"}}}'
 ```
 
 ### Verifying Results

docs/operator-guide/openstack-ironic-nautobot-device-interfaces-sync.md

@@ -40,7 +40,6 @@ sync-network-segment-range = "understack_workflows.main.sync_ucvni_group_range:m
 openstack-oslo-event = "understack_workflows.main.openstack_oslo_event:main"
 netapp-create-svm = "understack_workflows.main.netapp_create_svm:main"
 netapp-configure-interfaces = "understack_workflows.main.netapp_configure_net:main"
-update-nautobot-on-openstack-oslo-event = "understack_workflows.main.update_nautobot:main"
 
 [dependency-groups]
 test = [

python/understack-workflows/pyproject.toml

@@ -11,84 +11,33 @@
 
 
 class IronicClient:
-    def __init__(
-        self,
-        ironic_client: IronicV1Client | None = None,
-    ) -> None:
-        """Initialize our ironicclient wrapper."""
-        self.logged_in = False
-        self._client = ironic_client
-        self._client_factory = get_ironic_client
-
-    @property
-    def client(self) -> IronicV1Client:
-        """Get the ironic client, creating it lazily if needed."""
-        if self._client is None:
-            self._client = self._client_factory()
-        return self._client
-
-    def login(self):
-        self._client = get_ironic_client()
-        self.logged_in = True
+    def __init__(self, cloud: str | None = None) -> None:
+        self.client: IronicV1Client = get_ironic_client(cloud=cloud)
 
     def create_node(self, node_data: dict) -> Node:
-        self._ensure_logged_in()
-
         return cast(Node, self.client.node.create(**node_data))
 
     def list_nodes(self):
-        self._ensure_logged_in()
-
         return self.client.node.list()
 
     def get_node(self, node_ident: str, fields: list[str] | None = None) -> Node:
-        self._ensure_logged_in()
-
-        return cast(
-            Node,
-            self.client.node.get(
-                node_ident,
-                fields,
-            ),
-        )
+        return cast(Node, self.client.node.get(node_ident, fields))
 
     def update_node(self, node_id, patch):
-        self._ensure_logged_in()
-
-        return self.client.node.update(
-            node_id,
-            patch,
-        )
+        return self.client.node.update(node_id, patch)
 
     def create_port(self, port_data: dict):
-        self._ensure_logged_in()
-
         return self.client.port.create(**port_data)
 
     def update_port(self, port_id: str, patch: list):
-        self._ensure_logged_in()
-
-        return self.client.port.update(
-            port_id,
-            patch,
-        )
+        return self.client.port.update(port_id, patch)
 
     def delete_port(self, port_id: str):
-        self._ensure_logged_in()
-
-        return self.client.port.delete(
-            port_id,
-        )
+        return self.client.port.delete(port_id)
 
     def list_ports(self, node_id: str):
-        self._ensure_logged_in()
-
         return self.client.port.list(node=node_id, detail=True)
 
-    def _ensure_logged_in(self):
-        if not self.logged_in:
-            self.login()
-
     def get_node_inventory(self, node_ident: str) -> dict:
         """Fetch node inventory data from Ironic API.