Skip to content

Commit 9bfe0b7

Browse files
fixing pyright errors
1 parent 7321af5 commit 9bfe0b7

File tree

2 files changed

+14
-8
lines changed

2 files changed

+14
-8
lines changed

python/understack-workflows/understack_workflows/ironic/client.py

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
1+
from typing import cast
2+
13
from ironicclient.common.apiclient import exceptions as ironic_exceptions
24
from ironicclient.v1.client import Client as IronicV1Client
5+
from ironicclient.v1.node import Node
36

47
from understack_workflows.helpers import setup_logger
58
from understack_workflows.openstack.client import get_ironic_client
@@ -28,22 +31,25 @@ def login(self):
2831
self._client = get_ironic_client()
2932
self.logged_in = True
3033

31-
def create_node(self, node_data: dict):
34+
def create_node(self, node_data: dict) -> Node:
3235
self._ensure_logged_in()
3336

34-
return self.client.node.create(**node_data)
37+
return cast(Node, self.client.node.create(**node_data))
3538

3639
def list_nodes(self):
3740
self._ensure_logged_in()
3841

3942
return self.client.node.list()
4043

41-
def get_node(self, node_ident: str, fields: list[str] | None = None):
44+
def get_node(self, node_ident: str, fields: list[str] | None = None) -> Node:
4245
self._ensure_logged_in()
4346

44-
return self.client.node.get(
45-
node_ident,
46-
fields,
47+
return cast(
48+
Node,
49+
self.client.node.get(
50+
node_ident,
51+
fields,
52+
),
4753
)
4854

4955
def update_node(self, node_id, patch):

python/understack-workflows/understack_workflows/ironic_node.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,11 @@
22

33
import ironicclient.common.apiclient.exceptions
44
from ironicclient.common.utils import args_array_to_patch
5+
from ironicclient.v1.node import Node
56

67
from understack_workflows.bmc import Bmc
78
from understack_workflows.helpers import setup_logger
89
from understack_workflows.ironic.client import IronicClient
9-
from understack_workflows.node_configuration import IronicNodeConfiguration
1010

1111
STATES_ALLOWING_UPDATES = ["enroll", "manageable"]
1212

@@ -73,7 +73,7 @@ def create_ironic_node(
7373
client: IronicClient,
7474
node_meta: NodeMetadata,
7575
bmc: Bmc,
76-
) -> IronicNodeConfiguration:
76+
) -> Node:
7777
return client.create_node(
7878
{
7979
"uuid": node_meta.uuid,

0 commit comments

Comments
 (0)