Skip to content

Commit d237a17

Browse files
committed
dexop: add missing nil checks
1 parent 1357548 commit d237a17

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

go/dexop/dex/client.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,9 @@ type DexManager struct {
2121

2222
// Creates new Oauth2 client in Dex
2323
func (d *DexManager) CreateOauth2Client(clientSpec *dexv1alpha1.Client) (*dexapi.CreateClientResp, error) {
24+
if clientSpec == nil {
25+
return nil, fmt.Errorf("clientSpec is missing")
26+
}
2427
request := &dexapi.CreateClientReq{
2528
Client: &dexapi.Client{
2629
Id: clientSpec.Spec.Name,

go/dexop/internal/controller/client_controller.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,7 @@ func (r *ClientReconciler) generateSecret(ctx context.Context, secretmgr *Secret
211211
return "", err
212212
}
213213

214-
if secret.Data["secret"] == nil {
214+
if secret.Data == nil || secret.Data["secret"] == nil {
215215
reqLogger.Error(nil, "Secret data is missing", "SecretName", clientSpec.Spec.SecretName)
216216
return "", nil
217217
}

0 commit comments

Comments
 (0)