Merge pull request #1233 from rackerlabs/server-volume-attach-rough

feat(nova): add attach_volume/detach_volume to ironic driver

Author: cardoe

containers/nova/patches/ironic-attach-debug.patch

@@ -0,0 +1,22 @@
+diff --git a/nova/virt/ironic/driver.py b/nova/virt/ironic/driver.py
+index 64ccdaa50c..cf7cc872d8 100644
+--- a/nova/virt/ironic/driver.py
++++ b/nova/virt/ironic/driver.py
+@@ -2237,3 +2237,17 @@ class IronicDriver(virt_driver.ComputeDriver):
+         """IronicDriver manages port bindings for baremetal instances.
+         """
+         return True
++
++    def attach_volume(self, context, connection_info, instance, mountpoint,
++                      disk_bus=None, device_type=None, encryption=None):
++        """Attach the disk to the instance at mountpoint using info.
++
++        :raises TooManyDiskDevices: if the maximum allowed devices to attach
++                                    to a single instance is exceeded.
++        """
++        LOG.debug("attach_volume connection_info %s", connection_info, instance=instance)
++
++    def detach_volume(self, context, connection_info, instance, mountpoint,
++                      encryption=None):
++        """Detach the disk attached to the instance."""
++        LOG.debug("detach_volume connection_info %s", connection_info, instance=instance)

containers/nova/patches/series

@@ -1 +1,2 @@
 0001_trunk_details_metadata.patch
+ironic-attach-debug.patch