Handle the VLAN-type network bind ports

Our provisioning network uses this.

Author: Steve Keay

Diff for: python/neutron-understack/neutron_understack/neutron_understack_mech.py

@@ -308,6 +308,10 @@ def update_port_postcommit(self, context):
         # conditional based on what appears to have changed in the provided
         # context versus the "original".
         vlan_group_name = self._vlan_group_name(context)
+        LOG.debug(
+            "update_port_postcommit vlan_group=%s vif_type=%s",
+            vlan_group_name, context.vif_type
+        )
         if vlan_group_name and context.vif_type == portbindings.VIF_TYPE_OTHER:
             self.invoke_undersync(vlan_group_name)
 
@@ -361,6 +365,9 @@ def bind_port(self, context: PortContext) -> None:
 
         We obtain the dynamic segment for this network and vlan_group.
 
+        If there are no VXLAN segments, then bind a VLAN segment instead (this
+        is required for VALN_type networks like the provisioning network).
+
         We configure the nautobot switch interface with the new VLAN(s).
 
         Then make the required call in to the black box: context.set_binding.
@@ -373,6 +380,29 @@ def bind_port(self, context: PortContext) -> None:
                 self._bind_port_segment(context, segment)
                 return
 
+        for segment in context.network.network_segments:
+            if segment[api.NETWORK_TYPE] == p_const.TYPE_VLAN:
+                self._bind_port_vlan_segment(context, segment)
+                return
+
+    def _bind_port_vlan_segment(self, context: PortContext, segment: dict):
+        LOG.debug("bind_port_vlan_segment %s", segment)
+
+        if is_provisioning_network(network_id):
+            self._set_nautobot_port_status(context, "Provisioning-Interface")
+        else:
+            LOG.info(
+                "bind_port_vlan_segment won't configure segment in nautobot %s",
+                segment
+            )
+
+        context.set_binding(
+            segment[api.ID],
+            portbindings.VIF_TYPE_OTHER,
+            {},
+            status=p_const.PORT_STATUS_ACTIVE,
+        )
+
     def _bind_port_segment(self, context: PortContext, segment):
         trunk_details = context.current.get("trunk_details", {})
         network_id = context.current["network_id"]
@@ -382,11 +412,6 @@ def _bind_port_segment(self, context: PortContext, segment):
         )
         vlan_group_name = self._vlan_group_name(context)
 
-        if is_provisioning_network(network_id):
-            LOG.debug("bind_port_segment side-stepping provisioning interface")
-            self._set_nautobot_port_status(context, "Provisioning-Interface")
-            return
-
         LOG.debug(
             "bind_port_segment interface %s network %s type %s",
             connected_interface_uuid,