Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sleeps or poll in tests need to centrally regulated #7409

Open
robnagler opened this issue Dec 23, 2024 · 0 comments
Open

sleeps or poll in tests need to centrally regulated #7409

robnagler opened this issue Dec 23, 2024 · 0 comments

Comments

@robnagler
Copy link
Member

When pykern test is run in parallel, delays occur. Certain tests, e.g. supervisor_purge_free_sims_test.py, have sleeps to "ensure" that something happens. This particular test can't poll runStatus, because this puts the job back in ComputeJob.instances, and the sim won't get purged. Other tests may be less sensitive. job_cancel_test.py polls runStatus 5 times with 1 second sleeps to see that the job is running, canceled, etc.

Need some centralization on sleeps for tests that can't poll, and for tests that can, they should.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant