Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: bazelbuild/rules_pkg
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: radixbio/rules_pkg
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Can’t automatically merge. Don’t worry, you can still create the pull request.
  • 2 commits
  • 2 files changed
  • 1 contributor

Commits on Jul 13, 2020

  1. Add the format=tarfile.GNU_FORMAT to tarfile.open arguments to addres…

    …s Py3.8 change "The default format for new archives was changed to PAX_FORMAT from GNU_FORMAT."
    
    and resulting
    
    > unsupported PAX tar header type 'x'
    
    on `dpkg --install`
    itdaniher committed Jul 13, 2020
    Copy the full SHA
    b16882f View commit details

Commits on Jul 30, 2020

  1. Copy the full SHA
    0353687 View commit details
Showing with 2 additions and 2 deletions.
  1. +1 −1 pkg/archive.py
  2. +1 −1 pkg/make_deb.py
2 changes: 1 addition & 1 deletion pkg/archive.py
Original file line number Diff line number Diff line change
@@ -146,7 +146,7 @@ def __init__(self,
# Instead, we manually re-implement gzopen from tarfile.py and set mtime.
self.fileobj = gzip.GzipFile(
filename=name, mode='w', compresslevel=9, mtime=self.default_mtime)
self.tar = tarfile.open(name=name, mode=mode, fileobj=self.fileobj)
self.tar = tarfile.open(name=name, mode=mode, fileobj=self.fileobj, format=tarfile.GNU_FORMAT)
self.members = set([])
self.directories = set([])

2 changes: 1 addition & 1 deletion pkg/make_deb.py
Original file line number Diff line number Diff line change
@@ -146,7 +146,7 @@ def CreateDebControl(extrafiles=None, **kwargs):
# Create the control.tar file
tar = BytesIO()
with gzip.GzipFile('control.tar.gz', mode='w', fileobj=tar, mtime=0) as gz:
with tarfile.open('control.tar.gz', mode='w', fileobj=gz) as f:
with tarfile.open('control.tar.gz', mode='w', fileobj=gz, format=tarfile.GNU_FORMAT) as f:
tarinfo = tarfile.TarInfo('./control')
control_file_data = controlfile.encode('utf-8')
tarinfo.size = len(control_file_data)