Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

135 Close Button Missing #895

Closed
KUPOinyourWINDOW opened this issue Jan 8, 2025 · 7 comments · Fixed by #911
Closed

135 Close Button Missing #895

KUPOinyourWINDOW opened this issue Jan 8, 2025 · 7 comments · Fixed by #911
Labels
bug Something isn't working

Comments

@KUPOinyourWINDOW
Copy link

Another beta, another weird bug.
The close button isn't on the toolbar anymore, there isn't even a gap where it should be, its just gone

@KUPOinyourWINDOW KUPOinyourWINDOW added the bug Something isn't working label Jan 8, 2025
@Phong940253
Copy link

I'm facing with close, minimize, fullscreen button is gone in v135.0b2
image

@aravindet
Copy link

Possible workaround: I had this problem in firefox 135 beta (with the beta branch of firefox-gnome-theme). The close/min/max buttons reappeared when I turned on the new firefox sidebar via about:config > sidebar.revamp = true.

@lpapadakos
Copy link

@aravindet This didn't work for me. I now have the sidebar but still no buttons

@Phong940253
Copy link

@aravindet This didn't work for me. I now have the sidebar but still no buttons

me too

@rafaelmardojai
Copy link
Owner

Should be fixed in beta and nightly branches.

@KUPOinyourWINDOW
Copy link
Author

can confirm that its fixed in the beta branch, thank you

This was referenced Feb 4, 2025
@rafaelmardojai rafaelmardojai changed the title 135 Beta Close Button Missing 135 Close Button Missing Feb 4, 2025
@rafaelmardojai rafaelmardojai pinned this issue Feb 4, 2025
@garrett
Copy link
Contributor

garrett commented Feb 5, 2025

As always thanks for the excellent theme. 👍

And also, thanks for pinning this issue! It made it really easy to find.

For anyone else who had Firefox update to 135 and are missing the close button, you can work around this locally by switching to the beta branch for now:

git fetch --all && git checkout -b beta origin/beta

(You'll want to git switch master && git pull after the beta branch merges into master.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants